New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 696666 link

Starred by 1 user

Issue metadata

Status: Duplicate
Merged: issue 696715
Owner:
Closed: Feb 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Bug-Regression



Sign in to add a comment

webrtc.datachannel failing on 2 builders chromium: 451671 - 453197

Project Member Reported by robert...@chromium.org, Feb 27 2017

Issue description

webrtc.datachannel failing on 2 builders

Builders failed on: 
- Android Nexus5X Perf (2): 
  https://build.chromium.org/p/chromium.perf/builders/Android%20Nexus5X%20Perf%20%282%29
- Android Nexus6 Perf (2): 
  https://build.chromium.org/p/chromium.perf/builders/Android%20Nexus6%20Perf%20%282%29


Failure Output:
https://luci-logdog.appspot.com/v/?s=chrome%2Fbb%2Fchromium.perf%2FAndroid_Nexus6_Perf__2_%2F5140%2F%2B%2Frecipes%2Fsteps%2Fwebrtc.datachannel%2F0%2Fstdout

Snippet:
---8<---8<---8<---8<---8<---8<---8<---8<---8<---8<---8<---8<---8<---8<---
Traceback (most recent call last):
  File "/b/c/b/Android_Nexus6_Perf__2_/src/third_party/catapult/telemetry/telemetry/internal/story_runner.py", line 88, in _RunStoryAndProcessErrorIfNeeded
    state.RunStory(results)
  File "/b/c/b/Android_Nexus6_Perf__2_/src/third_party/catapult/common/py_trace_event/py_trace_event/trace_event_impl/decorators.py", line 52, in traced_function
    return func(*args, **kwargs)
  File "/b/c/b/Android_Nexus6_Perf__2_/src/third_party/catapult/telemetry/telemetry/page/shared_page_state.py", line 301, in RunStory
    self._current_page, self._current_tab, results)
  File "/b/c/b/Android_Nexus6_Perf__2_/src/third_party/catapult/common/py_trace_event/py_trace_event/trace_event_impl/decorators.py", line 52, in traced_function
    return func(*args, **kwargs)
  File "/b/c/b/Android_Nexus6_Perf__2_/src/tools/perf/measurements/webrtc.py", line 61, in ValidateAndMeasurePage
    self._power_metric.Stop(page, tab)
  File "/b/c/b/Android_Nexus6_Perf__2_/src/tools/perf/metrics/power.py", line 100, in Stop
    self._StopInternal()
  File "/b/c/b/Android_Nexus6_Perf__2_/src/tools/perf/metrics/power.py", line 52, in _StopInternal
    self._results = self._platform.StopMonitoringPower()
  File "/b/c/b/Android_Nexus6_Perf__2_/src/third_party/catapult/telemetry/telemetry/core/platform.py", line 311, in StopMonitoringPower
    ret_val = self._platform_backend.StopMonitoringPower()
  File "/b/c/b/Android_Nexus6_Perf__2_/src/third_party/catapult/telemetry/telemetry/internal/platform/android_platform_backend.py", line 433, in StopMonitoringPower
    return self._power_monitor.StopMonitoringPower()
  File "/b/c/b/Android_Nexus6_Perf__2_/src/third_party/catapult/telemetry/telemetry/internal/platform/power_monitor/android_power_monitor_controller.py", line 79, in StopMonitoringPower
    self._MergePowerResults(results, monitor.StopMonitoringPower())
  File "/b/c/b/Android_Nexus6_Perf__2_/src/third_party/catapult/telemetry/telemetry/internal/platform/power_monitor/sysfs_power_monitor.py", line 76, in StopMonitoringPower
    self._platform.ParseCStateSample(self._initial_cstate),
  File "/b/c/b/Android_Nexus6_Perf__2_/src/third_party/catapult/telemetry/telemetry/internal/platform/android_platform_backend.py", line 497, in ParseCStateSample
    cstates[state] = int(times[i])
ValueError: invalid literal for int() with base 10: ''

INFO:root:Closing power monitors
INFO:root:IsMonitoringPower: True
INFO:root:Try printing formatted exception: None None None

Exception raised when cleaning story run: 

Traceback (most recent call last):
  _RunStoryAndProcessErrorIfNeeded at /b/c/b/Android_Nexus6_Perf__2_/src/third_party/catapult/telemetry/telemetry/internal/story_runner.py:113
    test.DidRunPage(state.platform)
  traced_function at /b/c/b/Android_Nexus6_Perf__2_/src/third_party/catapult/common/py_trace_event/py_trace_event/trace_event_impl/decorators.py:52
    return func(*args, **kwargs)
  DidRunPage at /b/c/b/Android_Nexus6_Perf__2_/src/tools/perf/measurements/webrtc.py:69
    self._power_metric.Close()
  Close at /b/c/b/Android_Nexus6_Perf__2_/src/tools/perf/metrics/power.py:106
    self._platform.StopMonitoringPower()
  StopMonitoringPower at /b/c/b/Android_Nexus6_Perf__2_/src/third_party/catapult/telemetry/telemetry/core/platform.py:311
    ret_val = self._platform_backend.StopMonitoringPower()
  StopMonitoringPower at /b/c/b/Android_Nexus6_Perf__2_/src/third_party/catapult/telemetry/telemetry/internal/platform/android_platform_backend.py:433
    return self._power_monitor.StopMonitoringPower()
  StopMonitoringPower at /b/c/b/Android_Nexus6_Perf__2_/src/third_party/catapult/telemetry/telemetry/internal/platform/power_monitor/android_power_monitor_controller.py:74
    self._CheckStop()
  _CheckStop at /b/c/b/Android_Nexus6_Perf__2_/src/third_party/catapult/telemetry/telemetry/internal/platform/power_monitor/__init__.py:35
    assert self._monitoring, "Not monitoring power."
AssertionError: Not monitoring power.

Locals:
  No locals!

[  FAILED  ] 30s_datachannel_transfer (50059 ms)
--->8--->8--->8--->8--->8--->8--->8--->8--->8--->8---
 
Project Member

Comment 2 by 42576172...@developer.gserviceaccount.com, Feb 27 2017


=== BISECT JOB RESULTS ===
Test failure found but unable to narrow commit range

Build failures prevented the bisect from narrowing the range further.


Bisect Details
  Configuration: android_nexus6_perf_bisect
  Benchmark    : webrtc.datachannel
  Metric       : application_energy_consumption_mwh/application_energy_consumption_mwh

Suspected Commit Range
  4 commits in range
  https://chromium.googlesource.com/chromium/src/+log/a6ea9dfa43640a82f3c7d07da387d67d485db1c8..f82a5a8d7a819348f63dfd94e08901a5808645f1


Revision             Exit Code      N
chromium@453179      0 +- N/A       20       good
chromium@453188      0 +- N/A       20       good
chromium@453193      0 +- N/A       20       good
chromium@453194      ---            ---      build failure
chromium@453195      ---            ---      build failure
chromium@453196      ---            ---      build failure
chromium@453197      1 +- N/A       20       bad

To Run This Test
  src/tools/perf/run_benchmark -v --browser=android-chromium --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests webrtc.datachannel

Debug Info
  https://chromeperf.appspot.com/buildbucket_job_status/8986478474473283904

Is this bisect wrong?
  https://chromeperf.appspot.com/bad_bisect?try_job_id=5212496471785472


| O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq
|  X  | for more information addressing perf regression bugs. For feedback,
| / \ | file a bug with component Speed>Bisection.  Thank you!
Cc: perezju@chromium.org
Juan, does this seem like a possible culprit?
The narrowed range includes a catapult roll with this single change.
And if so, could  bug 696715  also be caused by the same?


[Telemetry] Switch RunShellCommand clients to check_return=True

In all files where check_return was missing within /telemetry:
- enable check_return=True,
- pass the command as a list (rather than a string) where appropriate,
- replace calls to RunShellCommand with higher level commands (e.g.
  RemovePath) where appropriate.

BUG=chromium:628617

Review-Url: https://codereview.chromium.org/2709523005
Cc: -perezju@chromium.org
Owner: perezju@chromium.org
Status: Assigned (was: Available)
Yes, that's likely. I'll have a look.
Mergedinto: 696715
Status: Duplicate (was: Assigned)

Sign in to add a comment