New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 696661 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Jan 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 3
Type: Feature



Sign in to add a comment

Add nullability annotations to headers in ios/web_view/public

Project Member Reported by michaeldo@chromium.org, Feb 27 2017

Issue description

All headers in ios/web_view/public should include nullability annotations.
 

Comment 1 by pkl@chromium.org, Feb 27 2017

Cc: eugene...@chromium.org sdefresne@chromium.org
Owner: michaeldo@chromium.org
Status: Assigned (was: Untriaged)

Comment 2 Deleted

Comment 3 Deleted

 Issue 719323  has been merged into this issue.
Owner: ichikawa@chromium.org
Status: Started (was: Available)
Project Member

Comment 6 by bugdroid1@chromium.org, Jan 18 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0df2f5441276d78d86a5936f3640f34374cc89d6

commit 0df2f5441276d78d86a5936f3640f34374cc89d6
Author: Hiroshi Ichikawa <ichikawa@chromium.org>
Date: Thu Jan 18 01:37:04 2018

Add NS_ASSUME_NONNULL_BEGIN/END to files in //ios/web_view.

Bug:  696661 
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I4fd7e1f098c7179f813149e565f4c8f29aa92e47
Reviewed-on: https://chromium-review.googlesource.com/867149
Reviewed-by: Mike Dougherty <michaeldo@chromium.org>
Commit-Queue: Hiroshi Ichikawa <ichikawa@chromium.org>
Cr-Commit-Position: refs/heads/master@{#530005}
[modify] https://crrev.com/0df2f5441276d78d86a5936f3640f34374cc89d6/ios/web_view/internal/cwv_html_element_internal.h
[modify] https://crrev.com/0df2f5441276d78d86a5936f3640f34374cc89d6/ios/web_view/internal/cwv_navigation_action_internal.h
[modify] https://crrev.com/0df2f5441276d78d86a5936f3640f34374cc89d6/ios/web_view/internal/cwv_navigation_type_internal.h
[modify] https://crrev.com/0df2f5441276d78d86a5936f3640f34374cc89d6/ios/web_view/internal/cwv_preferences_internal.h
[modify] https://crrev.com/0df2f5441276d78d86a5936f3640f34374cc89d6/ios/web_view/internal/cwv_scroll_view_internal.h
[modify] https://crrev.com/0df2f5441276d78d86a5936f3640f34374cc89d6/ios/web_view/internal/cwv_user_content_controller_internal.h
[modify] https://crrev.com/0df2f5441276d78d86a5936f3640f34374cc89d6/ios/web_view/internal/cwv_web_view_configuration_internal.h
[modify] https://crrev.com/0df2f5441276d78d86a5936f3640f34374cc89d6/ios/web_view/internal/cwv_web_view_internal.h
[modify] https://crrev.com/0df2f5441276d78d86a5936f3640f34374cc89d6/ios/web_view/internal/signin/cwv_authentication_controller_internal.h
[modify] https://crrev.com/0df2f5441276d78d86a5936f3640f34374cc89d6/ios/web_view/public/cwv_html_element.h
[modify] https://crrev.com/0df2f5441276d78d86a5936f3640f34374cc89d6/ios/web_view/public/cwv_navigation_action.h
[modify] https://crrev.com/0df2f5441276d78d86a5936f3640f34374cc89d6/ios/web_view/public/cwv_scroll_view.h
[modify] https://crrev.com/0df2f5441276d78d86a5936f3640f34374cc89d6/ios/web_view/public/cwv_scroll_view_delegate.h
[modify] https://crrev.com/0df2f5441276d78d86a5936f3640f34374cc89d6/ios/web_view/public/cwv_ui_delegate.h
[modify] https://crrev.com/0df2f5441276d78d86a5936f3640f34374cc89d6/ios/web_view/public/cwv_user_content_controller.h
[modify] https://crrev.com/0df2f5441276d78d86a5936f3640f34374cc89d6/ios/web_view/public/cwv_user_script.h
[modify] https://crrev.com/0df2f5441276d78d86a5936f3640f34374cc89d6/ios/web_view/public/cwv_web_view.h
[modify] https://crrev.com/0df2f5441276d78d86a5936f3640f34374cc89d6/ios/web_view/public/cwv_web_view_configuration+sync.h
[modify] https://crrev.com/0df2f5441276d78d86a5936f3640f34374cc89d6/ios/web_view/public/cwv_web_view_configuration.h
[modify] https://crrev.com/0df2f5441276d78d86a5936f3640f34374cc89d6/ios/web_view/shell/shell_app_delegate.h
[modify] https://crrev.com/0df2f5441276d78d86a5936f3640f34374cc89d6/ios/web_view/shell/shell_autofill_delegate.h
[modify] https://crrev.com/0df2f5441276d78d86a5936f3640f34374cc89d6/ios/web_view/shell/shell_translation_delegate.h
[modify] https://crrev.com/0df2f5441276d78d86a5936f3640f34374cc89d6/ios/web_view/shell/shell_view_controller.h
[modify] https://crrev.com/0df2f5441276d78d86a5936f3640f34374cc89d6/ios/web_view/shell/test/earl_grey/web_view_shell_matchers.h
[modify] https://crrev.com/0df2f5441276d78d86a5936f3640f34374cc89d6/ios/web_view/test/observer.h
[modify] https://crrev.com/0df2f5441276d78d86a5936f3640f34374cc89d6/ios/web_view/test/web_view_int_test.h
[modify] https://crrev.com/0df2f5441276d78d86a5936f3640f34374cc89d6/ios/web_view/test/web_view_test_util.h

Status: Fixed (was: Started)

Sign in to add a comment