Crash hit when setting MediaControlsEnabled for videos without controls |
||
Issue descriptionThis happens before the video gets inserted into the DOMTree, while the controls haven't been initialized yet. The consequence is that we are calling MediaControls::onMediaControlsEnabledChange() on a null pointer, hitting a crash.
,
Feb 28 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e48ec244742e350bb55ad07dde1150022c536f84 commit e48ec244742e350bb55ad07dde1150022c536f84 Author: zqzhang <zqzhang@chromium.org> Date: Tue Feb 28 14:33:58 2017 Fix a crash when setting MediaControlsEnabled setting for videos without controls There's a crash which is triggered when we set MediaControlsEnabled setting before the video controls get created. This CL adds null-check before calling MediaControls::onMediaControlsEnabledChange(). BUG= 696645 Review-Url: https://codereview.chromium.org/2722623002 Cr-Commit-Position: refs/heads/master@{#453595} [modify] https://crrev.com/e48ec244742e350bb55ad07dde1150022c536f84/third_party/WebKit/LayoutTests/media/controls/settings-disable-controls.html [modify] https://crrev.com/e48ec244742e350bb55ad07dde1150022c536f84/third_party/WebKit/Source/core/html/HTMLMediaElement.cpp
,
Mar 7 2017
|
||
►
Sign in to add a comment |
||
Comment 1 by zqzh...@chromium.org
, Feb 27 2017