New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 696641 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Feb 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug



Sign in to add a comment

Android Builder (dbg) is failing at "isolate tests" step

Project Member Reported by gmanikpure@chromium.org, Feb 27 2017

Issue description

Android building is failing since 24Feb due to which Android chromedriver (https://build.chromium.org/p/chromium.fyi/builders/Android%20ChromeDriver%20Tests%20%28dbg%29) is idle and not running any builds.

https://uberchromegw.corp.google.com/i/chromium.fyi/builders/Android%20Builder%20%28dbg%29/builds/79569

isolate: read(chrome/test/data/android) failed: read /b/c/b/Android_Builder__dbg_/src/chrome/test/data/android: is a directory


step returned non-zero exit code: 1
@@@STEP_LOG_LINE@json.output (invalid)@null@@@
@@@STEP_LINK@logdog-->json.output (invalid)@https://luci-logdog.appspot.com/v/?s=chromium%2Fbb%2Fchromium.fyi%2FAndroid_Builder__dbg_%2F79569%2F%2B%2Frecipes%2Fsteps%2Fisolate_tests%2F0%2Flogs%2Fjson.output__invalid_%2F0@@@
@@@STEP_LOG_END@json.output (invalid)@@@
@@@STEP_FAILURE@@@

Can someone please look into it?

Prior to this isolate test failure, there was a compile error which was resolved in https://codereview.chromium.org/2714953002/.So CC'ing bsheedy@ to check if it's related.
 
Cc: -bsheedy@chromium.org
Components: -Infra
Labels: -Infra-Troopers -Pri-3 Pri-2
Owner: bsheedy@chromium.org
Status: Assigned (was: Untriaged)
https://codesearch.chromium.org/chromium/src/chrome/android/BUILD.gn?rcl=138ae10a7041202a4ac73b2dd21b1dc7e3634f3d&l=492 should end in /

Removing from trooper queue
https://codereview.chromium.org/2721673002 is out to fix this.

This seems like something that could be fixed on Luci's side - shouldn't it be checking whether something is actually file or directory instead of assuming that directories end with / and files don't?
Cc: mar...@chromium.org
+maruel for #2, though I suspect that that's WAI.

Comment 4 by mar...@chromium.org, Feb 27 2017

The trailing slash is a way to document what inputs are directories and what are files. It is optimizing for readability, not writability; this is more scalable. This is normally caught by the CQ.

The check is done explicitly to catch people being sloppy about their BUILD.gn.
Builder is green now https://build.chromium.org/p/chromium.fyi/builders/Android%20Builder%20%28dbg%29/builds/79680

I'll go ahead and close this.
Status: Verified (was: Assigned)
Thanks for fixing it, Brian!

Chromedriver android is also up and running.
https://build.chromium.org/p/chromium.fyi/builders/Android%20ChromeDriver%20Tests%20%28dbg%29/builds/32674

Sign in to add a comment