New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 696637 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jul 10
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Task
Proj-VR
Proj-XR
Proj-XR-VR



Sign in to add a comment

Expose controller battery level in VR UI

Project Member Reported by mthiesse@chromium.org, Feb 27 2017

Issue description

b/33662650 covers exposing the battery level through the GVR api, and it looks like that's landed (I don't know if we're using the GVR version with that API exposed yet).

We should expose the battery level in the UI somewhere. I believe it's typically displayed on the controller model itself, which we don't yet have. We could potentially display this in menu mode for now until we have the controller model hooked up.
 
Cc: joshcarpenter@chromium.org
Labels: Restrict-View-Google
ccing josh for comments on where to expose this in the UI.
Labels: Proj-VR-Shell
Labels: -VR-DF VR-Triage-Close
We'll need to be at parity w/ other Daydream first party apps. The new approach (not sure as of what version of DD software) is to expose controller battery life as a series of glowing dots on the side of the rendered model, in VR.
Labels: -VR-Triage-Close
As per David's comment at go/chrome-vr-backlog, unmarking this for closure and slating for M-63 (tentatively).
Blocking: 768564
Cc: -joshcarpenter@chromium.org gordonbrander@chromium.org
Labels: M-66
Labels: -Pri-2 Pri-1
Owner: tiborg@chromium.org
Status: Assigned (was: Available)
Tibor, you've done a lot of good stuff with the controller. Is this something you'd own?
Labels: -Pri-1 -Type-Bug -M-66 M-67 Pri-2 Type-Feature
Blocking: -768564
Labels: -M-67 VRB-MVP-Next
Labels: -VRB-MVP-Next Hostlist-VRB-MVP-Next
Labels: VRB-Next-Triage
Cc: tiborg@chromium.org
Labels: -Restrict-View-Google -Type-Feature -Proj-VR-Shell -Hostlist-VRB-MVP-Next -VRB-Next-Triage M-69 Target-69 Type-Task
Owner: bajones@chromium.org
Assigning to you Brandon since you are working on this.
Project Member

Comment 14 by bugdroid1@chromium.org, Jul 10

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/266f30ca824eef7419191c467834206172bf6f08

commit 266f30ca824eef7419191c467834206172bf6f08
Author: Brandon Jones <bajones@chromium.org>
Date: Tue Jul 10 23:18:24 2018

Added battery indicator to the controller in VRShell

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:linux_vr;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: I5dfaa8182e83eb20c459ab9363ee7de41a627a43
Bug:  696637 
Reviewed-on: https://chromium-review.googlesource.com/1125341
Commit-Queue: Brandon Jones <bajones@chromium.org>
Reviewed-by: Ian Vollick <vollick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#573976}
[modify] https://crrev.com/266f30ca824eef7419191c467834206172bf6f08/chrome/browser/android/vr/vr_controller.cc
[modify] https://crrev.com/266f30ca824eef7419191c467834206172bf6f08/chrome/browser/android/vr/vr_controller.h
[modify] https://crrev.com/266f30ca824eef7419191c467834206172bf6f08/chrome/browser/android/vr/vr_shell_gl.cc
[modify] https://crrev.com/266f30ca824eef7419191c467834206172bf6f08/chrome/browser/vr/elements/ui_element_name.cc
[modify] https://crrev.com/266f30ca824eef7419191c467834206172bf6f08/chrome/browser/vr/elements/ui_element_name.h
[modify] https://crrev.com/266f30ca824eef7419191c467834206172bf6f08/chrome/browser/vr/model/color_scheme.cc
[modify] https://crrev.com/266f30ca824eef7419191c467834206172bf6f08/chrome/browser/vr/model/color_scheme.h
[modify] https://crrev.com/266f30ca824eef7419191c467834206172bf6f08/chrome/browser/vr/model/controller_model.cc
[modify] https://crrev.com/266f30ca824eef7419191c467834206172bf6f08/chrome/browser/vr/model/controller_model.h
[modify] https://crrev.com/266f30ca824eef7419191c467834206172bf6f08/chrome/browser/vr/platform_controller.h
[modify] https://crrev.com/266f30ca824eef7419191c467834206172bf6f08/chrome/browser/vr/ui_scene_constants.h
[modify] https://crrev.com/266f30ca824eef7419191c467834206172bf6f08/chrome/browser/vr/ui_scene_creator.cc
[modify] https://crrev.com/266f30ca824eef7419191c467834206172bf6f08/chrome/browser/vr/ui_unittest.cc

Status: Fixed (was: Assigned)

Sign in to add a comment