Add haptic feedback for other HUD displays |
|||
Issue descriptionWe should add more haptic feedback for additional HUD displays: - Add bookmark. - Delete/move bookmark/folder. - Long press in contextual search. - Undo remove Most Visited item. - Copy Chrome version from the About Chrome settings screen. - Copy password succeeded/failed from the password details screen (is behind feature flag, IIRC). - Resettings Translate settings. ios/chrome/browser/ui/bookmarks/bookmark_interaction_controller.mm:161: MDCSnackbarMessageAction* action = ios/chrome/browser/ui/bookmarks/bookmark_interaction_controller.mm:162: [[[MDCSnackbarMessageAction alloc] init] autorelease]; ios/chrome/browser/ui/bookmarks/bookmark_interaction_controller.mm:183: MDCSnackbarMessage* message = [MDCSnackbarMessage messageWithText:text]; ios/chrome/browser/ui/bookmarks/bookmark_interaction_controller.mm:186: [MDCSnackbarManager showMessage:message]; ios/chrome/browser/ui/bookmarks/bookmark_utils_ios.mm:263: MDCSnackbarMessageAction* action = ios/chrome/browser/ui/bookmarks/bookmark_utils_ios.mm:264: [[[MDCSnackbarMessageAction alloc] init] autorelease]; ios/chrome/browser/ui/bookmarks/bookmark_utils_ios.mm:274: MDCSnackbarMessage* message = [MDCSnackbarMessage messageWithText:text]; ios/chrome/browser/ui/bookmarks/bookmark_utils_ios.mm:277: [MDCSnackbarManager showMessage:message]; ios/chrome/browser/ui/contextual_search/contextual_search_controller.mm:802: MDCSnackbarMessage* message = ios/chrome/browser/ui/contextual_search/contextual_search_controller.mm:803: [MDCSnackbarMessage messageWithText:messageText]; ios/chrome/browser/ui/contextual_search/contextual_search_controller.mm:806: [MDCSnackbarManager showMessage:message]; ios/chrome/browser/ui/ntp/google_landing_controller.mm:1440: MDCSnackbarMessageAction* action = ios/chrome/browser/ui/ntp/google_landing_controller.mm:1441: [[[MDCSnackbarMessageAction alloc] init] autorelease]; ios/chrome/browser/ui/ntp/google_landing_controller.mm:1453: MDCSnackbarMessage* message = [MDCSnackbarMessage ios/chrome/browser/ui/ntp/google_landing_controller.mm:1458: [MDCSnackbarManager showMessage:message]; ios/chrome/browser/ui/settings/about_chrome_collection_view_controller.mm:161: MDCSnackbarMessage* message = ios/chrome/browser/ui/settings/about_chrome_collection_view_controller.mm:162: [MDCSnackbarMessage messageWithText:messageText]; ios/chrome/browser/ui/settings/about_chrome_collection_view_controller.mm:164: [MDCSnackbarManager showMessage:message]; ios/chrome/browser/ui/settings/password_details_collection_view_controller.mm:276: MDCSnackbarMessage* copyPasswordResultMessage = ios/chrome/browser/ui/settings/password_details_collection_view_controller.mm:277: [MDCSnackbarMessage messageWithText:message]; ios/chrome/browser/ui/settings/password_details_collection_view_controller.mm:278: [MDCSnackbarManager showMessage:copyPasswordResultMessage]; ios/chrome/browser/ui/settings/translate_collection_view_controller.mm:170: MDCSnackbarMessage* message = ios/chrome/browser/ui/settings/translate_collection_view_controller.mm:171: [MDCSnackbarMessage messageWithText:messageText]; ios/chrome/browser/ui/settings/translate_collection_view_controller.mm:173: [MDCSnackbarManager showMessage:message];
,
Mar 2 2017
Manual test required. Check the following situations: - Add bookmark. - Delete/move bookmark/folder. - Long press in contextual search. - Remove Most Visited item. - Copy Chrome version from the About Chrome settings screen. - Copy password succeeded/failed from the password details screen. - Resettings Translate settings. (Note that comment #0 specified the undo of removing most visited, which is incorrect, this list is correct).
,
Mar 2 2017
,
Mar 2 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/64e253a51c34eeb59a13559aa52961aeab60aa34 commit 64e253a51c34eeb59a13559aa52961aeab60aa34 Author: pinkerton <pinkerton@chromium.org> Date: Thu Mar 02 19:41:27 2017 Adding haptics for more HUD uses. Covers the following cases: - Add bookmark. - Delete/move bookmark/folder. - Long press in contextual search. - Remove Most Visited item. - Copy Chrome version from the About Chrome settings screen. - Copy password succeeded/failed from the password details screen. - Resettings Translate settings. BUG= 696634 TEST=Manual testing required. See https://bugs.chromium.org/p/chromium/issues/detail?id=696634#c2 for things to test manually. Review-Url: https://codereview.chromium.org/2724233003 Cr-Commit-Position: refs/heads/master@{#454343} [modify] https://crrev.com/64e253a51c34eeb59a13559aa52961aeab60aa34/ios/chrome/browser/ui/bookmarks/bookmark_interaction_controller.mm [modify] https://crrev.com/64e253a51c34eeb59a13559aa52961aeab60aa34/ios/chrome/browser/ui/bookmarks/bookmark_utils_ios.mm [modify] https://crrev.com/64e253a51c34eeb59a13559aa52961aeab60aa34/ios/chrome/browser/ui/ntp/google_landing_controller.mm [modify] https://crrev.com/64e253a51c34eeb59a13559aa52961aeab60aa34/ios/chrome/browser/ui/settings/about_chrome_collection_view_controller.mm [modify] https://crrev.com/64e253a51c34eeb59a13559aa52961aeab60aa34/ios/chrome/browser/ui/settings/password_details_collection_view_controller.mm [modify] https://crrev.com/64e253a51c34eeb59a13559aa52961aeab60aa34/ios/chrome/browser/ui/settings/translate_collection_view_controller.mm
,
Mar 2 2017
,
Mar 7 2017
Verified the below on build 59.0.3033.0 Canary on iPhone7+ iOS 10.2.1 - Add bookmark - PASS - Delete/move bookmark/folder - PASS - Long press in contextual search - PASS - Remove Most Visited item - PASS - Copy Chrome version from the About Chrome settings screen - PASS - Copy password succeeded/failed from the password details screen - PASS - Resettings Translate settings - PASS
,
Mar 8 2017
Correction to the above verification: Long press in contextual search - FAIL
,
Mar 8 2017
Apologies, i should have removed contextual search from the testing list. I didn't implement that, since we're not shipping it. |
|||
►
Sign in to add a comment |
|||
Comment 1 by pinkerton@chromium.org
, Feb 27 2017