New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 696632 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner:
Closed: Mar 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug



Sign in to add a comment

[TTS] Address recognition doesn't select the full address

Project Member Reported by donnd@chromium.org, Feb 27 2017

Issue description

With Quick Actions we recognize addresses, but Tommy just showed me a case where we don't expand the selection to select the full address (which is confusing).  I thought we'd already landed a server-side change to fully extend the selection to include the recognized coca action text range, but maybe there's a bug there.
 

Comment 1 by donnd@chromium.org, Feb 27 2017

The case that failed was in this URL.  Selecting "River" selected "River Oaks Place" in "55 River Oaks Place, #70"

http://www.bamboo-gardens.com/locations##SanJoseCA
I found an example where we expand too far after coca recognizes a URL. The intent we get back is correct and navigates to the expected URL but the selection and display text are incorrect if I tap on most parts of the URL. If I tap toward the start of the URL on "http" or "www" then the selection is correct.

"http://www.example.com/index.html" on https://en.wikipedia.org/wiki/Uniform_Resource_Locator


Screenshot_20170227-142937.png
462 KB View Download
Cc: mzuluaga@google.com

Comment 5 by donnd@chromium.org, Mar 7 2017

There are actually two different bugs here: The first has a selection that's too short due to Coca not returning a content-reference for the whole address.  I'll filed a Coca bug for this (at https://b.corp.google.com/issues/36006993).  The second is due to our GWS plugin trying to find a content-reference that includes the whole search term we've determined, but in these cases it's too long. I think we should instead find a content-reference that just includes the original selection. https://b.corp.google.com/issues/36008206. I'll send out a CL to make that change. 
Project Member

Comment 6 by sheriffbot@chromium.org, Mar 7 2018

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available. If you change it back, also remove the "Hotlist-Recharge-Cold" label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 7 by donnd@google.com, Mar 7 2018

Status: WontFix (was: Untriaged)
Addressed with server-side bugs.

Sign in to add a comment