Offline Version of the page allows "Request Desktop Site" |
||||
Issue descriptionApp Version (from "Chrome Settings > About Chrome"): 58.0.3024.0 iOS Version: All Device: All Steps to reproduce: 1.) Add an article to a reading list 2.) Open that article (it will be displayed as Offline Version 3.) Tap on Tools menu Observed behavior: "Request Desktop Site" is enabled Expected behavior: "Request Desktop Site" should be disabled (as it is disabled for NTP, chrome://version, etc..)
,
Feb 28 2017
No direct consequence to the user (choosing Desktop version just reloads the page), so moving to M-58.
,
Mar 1 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/889af53fad72676272dd249f039a12aec8845f8c commit 889af53fad72676272dd249f039a12aec8845f8c Author: olivierrobin <olivierrobin@chromium.org> Date: Wed Mar 01 14:56:32 2017 Test URL instead of VirtualURL in [BVC isTabNativePage] The "native" character is linked to the loaded URL and not to the displayed URL. Test the URL instead of the VirtualURL. BUG= 696628 Review-Url: https://codereview.chromium.org/2723683002 Cr-Commit-Position: refs/heads/master@{#453933} [modify] https://crrev.com/889af53fad72676272dd249f039a12aec8845f8c/ios/chrome/browser/ui/browser_view_controller.mm
,
Mar 1 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/013ba67833cc40fbc072a1f59ffd67ec22bb6a44 commit 013ba67833cc40fbc072a1f59ffd67ec22bb6a44 Author: olivierrobin <olivierrobin@chromium.org> Date: Wed Mar 01 21:16:24 2017 [Reading List] Show page info for offline pages Offline pages pages show informations about offline state in the page info model. Clean-up after https://codereview.chromium.org/2723683002 BUG= 696628 Review-Url: https://codereview.chromium.org/2721403002 Cr-Commit-Position: refs/heads/master@{#454030} [modify] https://crrev.com/013ba67833cc40fbc072a1f59ffd67ec22bb6a44/ios/chrome/browser/ui/browser_view_controller.mm
,
Mar 1 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/013ba67833cc40fbc072a1f59ffd67ec22bb6a44 commit 013ba67833cc40fbc072a1f59ffd67ec22bb6a44 Author: olivierrobin <olivierrobin@chromium.org> Date: Wed Mar 01 21:16:24 2017 [Reading List] Show page info for offline pages Offline pages pages show informations about offline state in the page info model. Clean-up after https://codereview.chromium.org/2723683002 BUG= 696628 Review-Url: https://codereview.chromium.org/2721403002 Cr-Commit-Position: refs/heads/master@{#454030} [modify] https://crrev.com/013ba67833cc40fbc072a1f59ffd67ec22bb6a44/ios/chrome/browser/ui/browser_view_controller.mm
,
Mar 2 2017
,
Mar 7 2017
Verified on 58.0.3029.6 canary on iPhone7(10.2.1), iPad Air 2(10.2.1). Request Desktop site menu options is disabled for all offline pages. |
||||
►
Sign in to add a comment |
||||
Comment 1 by pkl@chromium.org
, Feb 27 2017Labels: M-57
Owner: olivierrobin@chromium.org
Status: Assigned (was: Untriaged)