Accuracy metric may not be recorded if the network quality is too slow |
||||||
Issue descriptionIn Network Quality Estimator (NQE), the accuracy metric may not be recorded in RecordAccuracyAfterMainFrame(). This may happen if the network quality was too slow, and NQE was unable to take any bandwidth sample in the last 15 seconds. This would cause GetRecentEffectiveConnectionType() to return UNKNOWN as the ECT, and ECT prediction accuracy would not be recorded. This can be fixed by making kbps as an optional metric when computing ECT. This would be a no-op change for the method GetEffectiveConnectionType(), and would only affect GetRecentEffectiveConnectionType().
,
Feb 28 2017
,
Feb 28 2017
This bug requires manual review: We are only 13 days from stable. Please contact the milestone owner if you have questions. Owners: amineer@(clank), cmasso@(bling), ketakid@(cros), govind@(desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Feb 28 2017
Before we approve merge to M57, could you please confirm whether this change is well baked/verified in Canary and safe to merge to M57? Also this is reported as P3 can this wait until M58 as we're very close to M57 Stable promotion?
,
Feb 28 2017
This is a very safe change, and affects UMA logging only. It is not super critical, but it would be very helpful in collecting the data.
,
Feb 28 2017
Approving merge to M57 branch 2987 per comment #5. Please merge ASAP. Thank you.
,
Feb 28 2017
Could you please merge your changes into M57 branch 2987 latest before 5:00 PM PT today so we can take it in for tomorrow's Beta release. Thank you.
,
Feb 28 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3b97fc71698dc30f5a51e6c16565b85868a3d1ab commit 3b97fc71698dc30f5a51e6c16565b85868a3d1ab Author: Tarun Bansal <tbansal@google.com> Date: Tue Feb 28 20:56:05 2017 Make kbps optional when computing effective connection type Make kbps optional when computing effective connection type since the kbps is always available. This change only affects GetRecentEffectiveConnectionType(), and not GetEffectiveConnectionType(). The former is used only for recording accuracy. BUG= 696616 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester Review-Url: https://codereview.chromium.org/2717883002 Cr-Commit-Position: refs/heads/master@{#453394} (cherry picked from commit 73f1a3b3440892c277003ef73862420592b93ab6) Review-Url: https://codereview.chromium.org/2719993006 . Cr-Commit-Position: refs/branch-heads/2987@{#722} Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943} [modify] https://crrev.com/3b97fc71698dc30f5a51e6c16565b85868a3d1ab/net/nqe/network_quality_estimator.cc
,
Feb 28 2017
|
||||||
►
Sign in to add a comment |
||||||
Comment 1 by bugdroid1@chromium.org
, Feb 27 2017