Regression: Chrome crashes on clicking clicking Fetch/View JSON buttons in chrome://ntp-tiles-internals |
|||
Issue descriptionChrome Version: 58.0.3025.0 dev OS: Ubuntu 14.04,Windows What steps will reproduce the problem? (1)Launch chrome and go to chrome://ntp-tiles-internals in Guest/Incognito mode (2)Click on Fetch/View JSON buttons and observe Actual: Chrome crashes on clicking those buttons. Expected: No crash should be seen. This is a regression issue broken in M58. Good Build: 58.0.3005.2 dev Bad Build: 58.0.3006.0 dev Crash ids: 1bb4e251c0000000 , 1a342251c0000000
,
Feb 27 2017
Bisect Information: --------------------- Using the per-revision bisect providing the bisect results, You are probably looking for a change made after 448592 (known good), but no later than 448593 (first known bad). CHANGE-LOG URL: ----------------- https://chromium.googlesource.com/chromium/src/+log/ea826e787b9356bf03d88dd43045af019270ee7d..65cefe9d0f5cd6a7892476b55e6431a91c05d11b From the CL above, assigning the issue to the concern owner Review-Url: https://codereview.chromium.org/2572133002 sfiera@ Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner. Note: Since this is a recent regression adding RB-Stable, Please feel free to edit if this is not the case. Thanks!
,
Feb 27 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d6336797781587abf6c3fa648d034315714d1134 commit d6336797781587abf6c3fa648d034315714d1134 Author: sfiera <sfiera@chromium.org> Date: Mon Feb 27 15:44:08 2017 chrome://ntp-tiles-internals: hide when incognito Previously I just disabled the callbacks. In addition to that, send back an empty configuration and site list, to make the page properly display that everything is disabled and there are no sites in incognito. Without this change, the "View JSON" button appears for popular sites, but causes a crash because there's no PopularSites object. BUG= 682622 , 696471 ,681774 Review-Url: https://codereview.chromium.org/2721603002 Cr-Commit-Position: refs/heads/master@{#453220} [modify] https://crrev.com/d6336797781587abf6c3fa648d034315714d1134/components/ntp_tiles/webui/ntp_tiles_internals_message_handler.cc [modify] https://crrev.com/d6336797781587abf6c3fa648d034315714d1134/components/ntp_tiles/webui/resources/ntp_tiles_internals.js
,
Feb 27 2017
|
|||
►
Sign in to add a comment |
|||
Comment 1 by ajha@chromium.org
, Feb 27 2017Status: Untriaged (was: Unconfirmed)