New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 696458 link

Starred by 2 users
Status: Fixed
Owner:
hcarmona@chromium.org
Closed: Mar 2017
Cc:
nyerramilli@chromium.org
rbasuvula@chromium.org
█ msrchandra@chromium.org
█ ranjitkan@chromium.org
hcarmona@chromium.org
dpa...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression: [MD_settings]Navigation issue is observed on chrome://settings/

Reported by dmascare...@etouch.net, Feb 27 2017 
Chrome Version:58.0.3025.0 636f441be350ec76e73b4e4f407bf8a7e86984fd-refs/heads/master@{#453134}
OS: Windows (7,8,8.1,10),Linux (14.04 LTS),Mac OS X(10.11.6,10.12.1)

What steps will reproduce the problem?
1. Launch chrome, navigate to chrome://md-settings, open "Main menu" side bar and click on “Advanced” ,select “Download”.
2. Click on ‘Back’ navigation arrow and observe url,Forward navigation arrow.

Actual:Page and url does not change and forward navigation arrow gets enable.
       (i.e. Twice Back navigation arrow should be clicked to reach main page.)

Expected:Page should navigate to Main page after step 2.

This is  a regression issue broken in ‘M-58’, below is the Manual Regression range and will soon update other info.
Good build : 58.0.3014.0
Bad build : 58.0.3015.0
Actual_nav.mov
2.2 MB Download
Expected_nav.mov
1.7 MB Download

Comment 1 by rbasuvula@chromium.org, Feb 27 2017

Cc: rbasuvula@chromium.org
Labels: hasbisect-per-revision
Owner: hcarmona@chromium.org
Status: Assigned (was: Unconfirmed)
Using the per-revision bisect providing the bisect results,
Good build: 58.0.3014.0 (Revision: 450840).
Bad build: 58.0.3015.0 (Revision: 451180).

You are probably looking for a change made after 451006 (known good), but no later than 451007 (first known bad).

CHANGE-LOG URL:
---------------
https://chromium.googlesource.com/chromium/src/+log/953322582e01e05f831456fecea0d48af331f16f..f26ccb9043c276fb76b875f90361ef5b58acc510

From the CL above, assigning the issue to the concern owner

@hcarmona : Could you please look into the issue, pardon me if it has nothing to do with your changes and if possible please assign it to concern owner.

Review-Url:https://codereview.chromium.org/2651293003
Note :Able to reproduce the issue in Ubuntu 14.04,Win 10.0 and Mac 10.12.2. and Able to reproduce in latest Canary #58.0.3024.0

Comment 2 by hcarmona@chromium.org, Mar 6 2017

Status: Started (was: Assigned)
This is caused by my change. I'll investigate, but at a glance the issue may be caused by setSelectedUrl_ triggering a duplicate notification.
Project Member

Comment 3 by bugdroid1@chromium.org, Mar 16 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fc3c4c428da2efaacc676dc40a1f2973daadc71d

commit fc3c4c428da2efaacc676dc40a1f2973daadc71d
Author: hcarmona <hcarmona@chromium.org>
Date: Thu Mar 16 17:34:38 2017

MD Settings: Debounce navigation event in side nav.

Side nav was causing 2 navigation events because |setSelectedUrl_| sets
the selected URL on both selectors. Debounce will make sure only one of
these events is handled. Timeout is not necessary.

R=dschuyler@gmail.com
BUG= 696458 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2733963002
Cr-Commit-Position: refs/heads/master@{#457475}

[modify] https://crrev.com/fc3c4c428da2efaacc676dc40a1f2973daadc71d/chrome/browser/resources/settings/settings_menu/settings_menu.html

Comment 4 by hcarmona@chromium.org, Mar 22 2017

Status: Fixed (was: Started)
►

Sign in to add a comment