Headless: product/user agent is missing chrome version and is not passed to DevTools. |
||
Issue descriptionCross-posting from headless-dev, originally posted by james@getadmiral.com: I'm running Chrome using: $ google-chrome-unstable --headless --remote-debugging-port=9222 Version is: $ google-chrome-unstable --version Google Chrome 58.0.3018.3 dev I'm installing google-chrome-unstable using yum and the repo is https://dl.google.com/linux/chrome/rpm/stable/$basearch. The response from /json/version is: { "Browser": "", "Protocol-Version": "1.2", "User-Agent": "Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) HeadlessChrome Safari/537.36", "V8-Version": "5.8.244", "WebKit-Version": "537.36 (@9f90720567a93b798d314c9d4af6bdd092a07767)" } The empty "Browser" is causing the client library, chrome-remote-interface (https://github.com/cyrus-and/chrome-remote-interface), to not understand what browser it's talking to. Is there a command-line flag I need to pass so it sends back "Chrome/..." or do I have to just make the client library assume it's always Chrome if its empty?
,
Feb 27 2017
The problem is in StartLocalDevToolsHttpHandler: https://cs.chromium.org/chromium/src/headless/lib/browser/headless_devtools.cc?dr=CSs&l=64 We need to pass meaningful second parameter.
,
Feb 27 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/38ff88e55d8c151e1559da02fa1c52aff31c44eb commit 38ff88e55d8c151e1559da02fa1c52aff31c44eb Author: eseckler <eseckler@chromium.org> Date: Mon Feb 27 11:17:18 2017 [headless] Use version for product name and user agent. Also sets the product name on DevTools server. BUG= 696457 Review-Url: https://codereview.chromium.org/2720673003 Cr-Commit-Position: refs/heads/master@{#453189} [modify] https://crrev.com/38ff88e55d8c151e1559da02fa1c52aff31c44eb/headless/lib/browser/headless_browser_context_impl.cc [modify] https://crrev.com/38ff88e55d8c151e1559da02fa1c52aff31c44eb/headless/lib/browser/headless_browser_context_options.cc [modify] https://crrev.com/38ff88e55d8c151e1559da02fa1c52aff31c44eb/headless/lib/browser/headless_browser_context_options.h [modify] https://crrev.com/38ff88e55d8c151e1559da02fa1c52aff31c44eb/headless/lib/browser/headless_devtools.cc [modify] https://crrev.com/38ff88e55d8c151e1559da02fa1c52aff31c44eb/headless/lib/headless_content_client.cc [modify] https://crrev.com/38ff88e55d8c151e1559da02fa1c52aff31c44eb/headless/lib/headless_content_client.h [modify] https://crrev.com/38ff88e55d8c151e1559da02fa1c52aff31c44eb/headless/public/headless_browser.cc [modify] https://crrev.com/38ff88e55d8c151e1559da02fa1c52aff31c44eb/headless/public/headless_browser.h [modify] https://crrev.com/38ff88e55d8c151e1559da02fa1c52aff31c44eb/headless/public/headless_browser_context.h
,
Feb 27 2017
,
Feb 27 2017
|
||
►
Sign in to add a comment |
||
Comment 1 by eseckler@chromium.org
, Feb 27 2017