New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 696437 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Apr 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 1
Type: Bug-Regression

Blocking:
issue 671375


Show other hotlists

Hotlists containing this issue:
MD-Settings-Launch-Blockers


Sign in to add a comment

We need a solution for <paper-slider> in RTL

Reported by dmascare...@etouch.net, Feb 27 2017

Issue description

Chrome Version:58.0.3025.0 636f441be350ec76e73b4e4f407bf8a7e86984fd-refs/heads/master@{#453134}
OS: Windows (7,8,8.1,10),Linux (14.04 LTS),Mac OS X(10.11.6,10.12.1)

Pre-Condition: Set ‘Right-to-left’ direction in Force UI direction flag.

What steps will reproduce the problem?
1. Launch chrome and navigate to chrome://md-settings/fonts
2. Drag the ‘Font size’ slider towards ‘Tiny’ and observe the font.

Actual:  Font size increases even if the slider is dragged towards ‘Tiny’ and vice-verse.
Expected: Font size should decrease if the slider is dragged towards tiny and increase when slider is dragged towards huge.

This is regression issue, broken in ‘M 57’ and below in Manual bisect info:
Good build:57.0.2964.0
Bad build:57.0.2965.0

 
Actual_rtl.mov
2.1 MB Download
Labels: hasbisect-per-revision Proj-MaterialDesign-WebUI
Owner: steve...@chromium.org
Status: Assigned (was: Unconfirmed)
Using the per-revision bisect providing the bisect results,
Good Build -- 57.0.2964.0 (revision : 440723)
Bad Build  -- 57.0.2965.0 (revision : 440816)

You are probably looking for a change made after 440784 (known good), but no later than 440785 (first known bad).
CHANGELOG URL:
  https://chromium.googlesource.com/chromium/src/+log/59ec2c1b938fc633a64079b176283b800d96f689..26b1599ba3f24f4124d8d78227fb815dc1c2e696

@stevenjb -- Could you please look into the issue, kindly re-assign if this is not related to your changes.
Thank You.
Labels: -M-57 M-59
Will fix this for 59.

Comment 3 by dbeam@chromium.org, Feb 27 2017

Labels: Hotlist-MD-Settings-Appearance
btw, the appearance of the ripple is already fixed in RTL (https://codereview.chromium.org/2719213002/)
Cc: dbeam@chromium.org dschuyler@chromium.org hcarmona@chromium.org
Owner: hcarmona@chromium.org
This seems like something we may want to fix in paper-slider. It does not currently appear to support RTL:
https://github.com/Polymer/paper-slider/issues/22

hcarmona@, dbeam@ - thoughts?

Any updates on this? If it's not a launch-blocker, let's move it to Pri-2.
Blocking: 671375
Owner: dschuyler@chromium.org
Hector is cool with me taking this, fyi on the owner change.
Making some notes because I need to switch to a higher priority issue:

This can be hack-fixed in paper-slider-extracted.js by reversing the values in _trackX. Though I'm not sure that's the right fix yet.

I've started looking at reversing the values in iron-range-behavior-extracted.js instead. That behavior is used in the sliders and progress bars. The progress elements are also not switching in RTL. (So this may be a better location to make the change since it can help both elements).

The progress bars could also be reversed easily in CSS using transform scale x -1. That doesn't work great for the slider though, since the item is interactive (mirroring the image kinda fails when interacting with, rather than just looking at the element).

Comment 9 by dbeam@chromium.org, Apr 4 2017

Cc: n...@chromium.org
Summary: We need a solution for <paper-slider> in RTL (was: Regression: Wrong action is seen for slider bar of Customise fonts page in RTL mode.)
Cc: keanulee@chromium.org
Status: Started (was: Assigned)
There is a possible fix at CL https://codereview.chromium.org/2796903004/

I say possible fix because while that works, I'm looking for something better. The initial patch handles the RTL/LTR in the settings_slider.js. It would be nicer if the RTL handling were done at a lower level, such as within paper-slider.*.
An alternate fix (that changes paper-slider in Polymer) is at https://codereview.chromium.org/2800953002/
Status: Fixed (was: Started)
Cc: brajkumar@chromium.org
Labels: Needs-Feedback
Verified this issue on Windows-10 and Ubuntu 14.04 using chrome latest Dev #59.0.3067.0 by following steps mentioned in the original comment, Observed the font size gets decreases if the slider is dragged towards tiny and increased when slider is dragged towards huge.

Tested the same on Mac OS 10.12.4, After step-1 observed the tabs are not displayed right to left instead it displays by default left to right. Due to this issue unable to drag the slider and verify this issue it from chrome-TE end. 

dschuyler@ Attaching scree-cast for reference could you please let us know is this is a known issue or do we need to file a separate one on this?

Thanks! 
696437.mp4
1.2 MB View Download

Comment 17 by dbeam@chromium.org, Apr 11 2017

brajkumar@: don't use that flag, actually change your language to Hebrew or Arabic in system settings

Sign in to add a comment