We need a solution for <paper-slider> in RTL
Reported by
dmascare...@etouch.net,
Feb 27 2017
|
|||||||||||
Issue descriptionChrome Version:58.0.3025.0 636f441be350ec76e73b4e4f407bf8a7e86984fd-refs/heads/master@{#453134} OS: Windows (7,8,8.1,10),Linux (14.04 LTS),Mac OS X(10.11.6,10.12.1) Pre-Condition: Set ‘Right-to-left’ direction in Force UI direction flag. What steps will reproduce the problem? 1. Launch chrome and navigate to chrome://md-settings/fonts 2. Drag the ‘Font size’ slider towards ‘Tiny’ and observe the font. Actual: Font size increases even if the slider is dragged towards ‘Tiny’ and vice-verse. Expected: Font size should decrease if the slider is dragged towards tiny and increase when slider is dragged towards huge. This is regression issue, broken in ‘M 57’ and below in Manual bisect info: Good build:57.0.2964.0 Bad build:57.0.2965.0
,
Feb 27 2017
Will fix this for 59.
,
Feb 27 2017
btw, the appearance of the ripple is already fixed in RTL (https://codereview.chromium.org/2719213002/)
,
Mar 7 2017
This seems like something we may want to fix in paper-slider. It does not currently appear to support RTL: https://github.com/Polymer/paper-slider/issues/22 hcarmona@, dbeam@ - thoughts?
,
Mar 29 2017
Any updates on this? If it's not a launch-blocker, let's move it to Pri-2.
,
Apr 3 2017
,
Apr 3 2017
Hector is cool with me taking this, fyi on the owner change.
,
Apr 4 2017
Making some notes because I need to switch to a higher priority issue: This can be hack-fixed in paper-slider-extracted.js by reversing the values in _trackX. Though I'm not sure that's the right fix yet. I've started looking at reversing the values in iron-range-behavior-extracted.js instead. That behavior is used in the sliders and progress bars. The progress elements are also not switching in RTL. (So this may be a better location to make the change since it can help both elements). The progress bars could also be reversed easily in CSS using transform scale x -1. That doesn't work great for the slider though, since the item is interactive (mirroring the image kinda fails when interacting with, rather than just looking at the element).
,
Apr 4 2017
,
Apr 4 2017
,
Apr 4 2017
,
Apr 5 2017
There is a possible fix at CL https://codereview.chromium.org/2796903004/ I say possible fix because while that works, I'm looking for something better. The initial patch handles the RTL/LTR in the settings_slider.js. It would be nicer if the RTL handling were done at a lower level, such as within paper-slider.*.
,
Apr 5 2017
An alternate fix (that changes paper-slider in Polymer) is at https://codereview.chromium.org/2800953002/
,
Apr 7 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6a6df4ec7e64dfc890c6450cd4a86e39f6754da1 commit 6a6df4ec7e64dfc890c6450cd4a86e39f6754da1 Author: dschuyler <dschuyler@chromium.org> Date: Fri Apr 07 19:17:09 2017 [Polymer] update paper-slider for RTL support This CL applies a pull request submitted to Polymer to add RTL support for paper-sliders. BUG= 696437 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2801193002 Cr-Commit-Position: refs/heads/master@{#462953} [modify] https://crrev.com/6a6df4ec7e64dfc890c6450cd4a86e39f6754da1/third_party/polymer/v1_0/bower.json [modify] https://crrev.com/6a6df4ec7e64dfc890c6450cd4a86e39f6754da1/third_party/polymer/v1_0/components-chromium/paper-slider/bower.json [modify] https://crrev.com/6a6df4ec7e64dfc890c6450cd4a86e39f6754da1/third_party/polymer/v1_0/components-chromium/paper-slider/paper-slider-extracted.js [modify] https://crrev.com/6a6df4ec7e64dfc890c6450cd4a86e39f6754da1/third_party/polymer/v1_0/components-chromium/paper-slider/paper-slider.html [modify] https://crrev.com/6a6df4ec7e64dfc890c6450cd4a86e39f6754da1/third_party/polymer/v1_0/components_summary.txt [modify] https://crrev.com/6a6df4ec7e64dfc890c6450cd4a86e39f6754da1/third_party/web-animations-js/sources/.bower.json
,
Apr 7 2017
,
Apr 11 2017
Verified this issue on Windows-10 and Ubuntu 14.04 using chrome latest Dev #59.0.3067.0 by following steps mentioned in the original comment, Observed the font size gets decreases if the slider is dragged towards tiny and increased when slider is dragged towards huge. Tested the same on Mac OS 10.12.4, After step-1 observed the tabs are not displayed right to left instead it displays by default left to right. Due to this issue unable to drag the slider and verify this issue it from chrome-TE end. dschuyler@ Attaching scree-cast for reference could you please let us know is this is a known issue or do we need to file a separate one on this? Thanks!
,
Apr 11 2017
brajkumar@: don't use that flag, actually change your language to Hebrew or Arabic in system settings |
|||||||||||
►
Sign in to add a comment |
|||||||||||
Comment 1 by msrchandra@chromium.org
, Feb 27 2017Owner: steve...@chromium.org
Status: Assigned (was: Unconfirmed)