New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 696434 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Apr 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression: Broken boarders is seen in the network overlay at OOBE screen in Swanky

Project Member Reported by sandeepkumars@chromium.org, Feb 27 2017

Issue description

Chrome Version: 58.0.3015.0/9312.0/9312.0.0 dev-channel Swanky
OS: Chrome

What steps will reproduce the problem?
(1)Recover OS via USB>> go to Connect to network overlay at OOBE screen>> try click on any network>> and observe

Expected: Broken boarders should not be seen
Actual: Instead broken boarders is seen

Issue is not seen in today's build M58: 58.0.3015.0/9312.0/9312.0.0 dev-channel  Banjo, Squawks

Issue is not applicable to Linux and Windows

Issue is specific to Swanky only
 
Actual-1.jpg
41.2 KB View Download
Actual-2.jpg
43.8 KB View Download
Cc: osh...@chromium.org
+oshima@

Do you have any ideas on what could be wrong here. This is native UI.
Is it somehow connected to dpi ?
Oshima, friendly ping.

Comment 3 by osh...@chromium.org, Mar 30 2017

Cc: malaykeshav@chromium.org
Is Squawks Full HD machine? malay, can you do quick test this with scalable view and see if it helps?

Comment 4 by r...@chromium.org, Apr 7 2017

Owner: wzang@chromium.org

Comment 5 by wzang@chromium.org, Apr 7 2017

Cc: zalcorn@chromium.org
+zalcorn@

Zach, do we need this for 58? 
Yes Colin please try and chase this, it's a pretty bad regression.
We should first bring device with this issue to oshima@ ;)
This sounds like high/fractional DPI issue.

Comment 8 by wzang@chromium.org, Apr 13 2017

Labels: -ReleaseBlock-Stable -M-58 M-59
Project Member

Comment 9 by bugdroid1@chromium.org, Apr 18 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bc1501887b1ed2b82fc04b01d94ca44fc9fbc1d9

commit bc1501887b1ed2b82fc04b01d94ca44fc9fbc1d9
Author: estade <estade@chromium.org>
Date: Tue Apr 18 00:38:00 2017

FocusableBorder/fractional scales: snap to different pixel

A view can have a fractional pixel size. The pixel size of the canvas we
draw to can get rounded down instead of up. By using
gfx::ScaleToEnclosedRect instead of gfx::ScaleToEnclosingRect we'll
be sure to draw within the canvas's bounds.

The linked bug also exhibited itself in the bookmark bubble's inputs at
various scale factors --- 1.75, for example.

BUG= 696434 

Review-Url: https://codereview.chromium.org/2818713006
Cr-Commit-Position: refs/heads/master@{#465080}

[modify] https://crrev.com/bc1501887b1ed2b82fc04b01d94ca44fc9fbc1d9/ui/views/controls/focusable_border.cc

Comment 10 by wzang@chromium.org, Apr 18 2017

Status: Fixed (was: Assigned)
Status: Verified (was: Fixed)

Sign in to add a comment