Issue metadata
Sign in to add a comment
|
Search spins endlessly |
||||||||||||||||||||||||
Issue description@dpapad could you please try reproducing this? I'm on M57 and can't. [See b/35662363] Version: 58.0.3015.0 dev OS: Chrome Steps To Reproduce: (1) Open Settings UI (2) Search for "s" (3) Wait for results to come up (4) Search for any other string, say "network" Expected Result: Second search request shows results for "network" Actual Result: Spinner runs forever and search results are still showing the results for "s"
,
Feb 27 2017
@stevenjb: At first glance, the fingerprint subpage is a sub-sub-page, which makes it hard to properly display the search bubble that guides the user to that subpage. Specifically - the subpage resides at https://cs.chromium.org/chromium/src/chrome/browser/resources/settings/people_page/people_page.html?l=339. - The associated control resides at https://cs.chromium.org/chromium/src/chrome/browser/resources/settings/people_page/lock_screen.html?l=61. This is not something that is currently handled. The only other UI with sub-sub pages is content settings, which handles it by having the sub-sub pages not be searchable (using no-search attribute, example https://cs.chromium.org/chromium/src/chrome/browser/resources/settings/privacy_page/privacy_page.html?l=212). So the easiest way to fix the error is to add a no-search attribute for now. That would mean that the contents of the /lockScreen/fingerprint sub-subpage will not be searched, but perhaps that is good enough (since the subpage leading to the sub-subpage is still searched).
,
Feb 27 2017
Also I just realized that the /lockScreen subpage is already annotated with no-search [1], which makes a no-search in the /lockScreen/fingerprint sub-subpage even more justified. [1] https://cs.chromium.org/chromium/src/chrome/browser/resources/settings/people_page/people_page.html?l=330
,
Feb 28 2017
Upgrading this to a P1
,
Mar 1 2017
|
|||||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||||
Comment 1 by dpa...@chromium.org
, Feb 27 201731.5 KB
31.5 KB View Download