New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 696420 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner:
Closed: Sep 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 3
Type: Bug-Regression



Sign in to add a comment

[MD History] Invalid pages names are allowed in route

Reported by rk...@etouch.net, Feb 27 2017

Issue description

Chrome Version: 58.0.3025.0 Revision 636f441be350ec76e73b4e4f407bf8a7e86984fd-refs/heads/master@{#453134}
OS: Windows (7,8,10), Mac (10.11.6,10.12.1), Linux (14.04 LTS)

What steps will reproduce the problem?
(1) Launch chrome, navigate to chrome://history page.
(2) Click on omnibox and 'Copy' url then 'Paste' it 2 times.
(3) Hitt Enter and observe omnibox url.

Actual: Omnibox url is not correct for chrome://history page.

Expected: Omnibox url should be correct for chrome://history page.

This is a regression issue, broken in 'M-58', will soon update the other info:

Good Build: 58.0.2997.0
Bad Build: 58.0.2998.0
 
Actual_History.mp4
322 KB View Download
Expected_History.mp4
160 KB View Download
Labels: hasbisect-per-revision
Owner: tsergeant@chromium.org
Status: Assigned (was: Unconfirmed)
Using the per-revision bisect providing the bisect results,
Good Build: 58.0.2997.0 (Revision: (446949)
Bad Build: 58.0.2998.0 (Revision: 447146)

You are probably looking for a change made after 446954 (known good), but no later than 446955 (first known bad).
CHANGELOG URL:
The script might not always return single CL as suspectas some perf builds might get missing due to failure.
  https://chromium.googlesource.com/chromium/src/+log/86bf5f7085db57c142eebd84d7da7dc4b81c181a..2112ddfabe748e6a6a6f9fdbb7de7ade58326957


tsergeant@, could you please check the issue and help.
Labels: -Pri-1 Pri-3
Summary: [MD History] Invalid pages names are allowed in route (was: Regression: Omnibox url is not correct for chrome://history page after performing Copy/Paste.)
This is really low priority. We only really support a handful of URLs, and so long as any invalid URLs (like the one in the original report) don't break the page, I'm happy.

The original bug can be rephrased as:

1. Navigate to chrome://history/foo

Expected behavior:
'foo' should be stripped from the URL. The history-list should display results, and the sidebar should highlight 'Chrome History'.

Actual behavior:
'foo' is not stripped from the URL. The history-list displays results, but the sidebar does not highlight any item as selected.

Fixing this will probably require adding a list of valid pages into router.js
Labels: Proj-MaterialDesign-WebUI

Comment 4 by hdodda@chromium.org, Mar 20 2017

Able to reproduce the issue on mac os 10.12.3 using chrome canary M59 #59.0.3046.0 , following steps mentioned in comment #2.

Gentle ping , to get an update on this.

Thanks!
Owner: calamity@chromium.org
Reassigning to calamity. Realistically, I'm not sure that we'll ever fix this. Feel free to WontFix.
Status: WontFix (was: Assigned)
I can live with this.

Sign in to add a comment