New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 696419 link

Starred by 1 user
Status: Fixed
Owner:
█ tsergeant@chromium.org
Not on Chrome
Closed: Feb 2017
Cc:
nyerramilli@chromium.org
rbasuvula@chromium.org
tbuck...@chromium.org
█ msrchandra@chromium.org
█ ranjitkan@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression: 'You can clear your browsing data from this menu' tool tip does not vanish after clicking on Main menu icon

Reported by jshan...@etouch.net, Feb 27 2017 
Chrome Version: 58.0.3025.0 (Official Build) 636f441be350ec76e73b4e4f407bf8a7e86984fd-refs/heads/master@{#453134}-32/64 bit
OS: Windows (7,8,10),Linux (14.04 LTS),Mac OS X(10.11.6,10.12.1)

Steps:
1. Freshly launch Chrome and navigate to chrome://history
2. Resize the browser window such that 'You can clear your browsing data from this menu' tool tip is seen.
3. Click on Main menu icon and observe

Actual: 'You can clear your browsing data from this menu' tool tip does not vanish after clicking on Main menu icon

Expected: 'You can clear your browsing data from this menu' tool tip should vanish after clicking on Main menu icon

This is regression issue broken in M 57 and will soon update bisect info :

Good build:57.0.2985.0
Bad build: 57.0.2986.0
Actual_video.mp4
575 KB View Download
Expected_video.mp4
312 KB View Download

Comment 1 by rbasuvula@chromium.org, Feb 27 2017

Cc: rbasuvula@chromium.org
Labels: hasbisect-per-revision
Owner: tsergeant@chromium.org
Status: Assigned (was: Unconfirmed)
Using the per-revision bisect providing the bisect results,
Good build: 57.0.2985.0 (Revision: 444244).
Bad build: 57.0.2986.0 (Revision: 444600).

You are probably looking for a change made after 444256 (known good), but no later than 444257 (first known bad).

CHANGE-LOG URL:
---------------
https://chromium.googlesource.com/chromium/src/+log/9413cffb4fdc7dbcfc40a8da0530942e2f6ae0f2..e316eda37d7a3b330320fcad850dd62902123dd4

From the CL above, assigning the issue to the concern owner

@ tsergeant : Could you please look into the issue, pardon me if it has nothing to do with your changes and if possible please assign it to concern owner.

Review-Url:  https://codereview.chromium.org/2627383002
Note :Able to reproduce the issue in Ubuntu 14.04,Win 10.0 and Mac 10.12.2. and Able to reproduce in latest Canary #58.0.3024.0

Comment 2 by tsergeant@chromium.org, Feb 27 2017

Status: Started (was: Assigned)
Project Member

Comment 3 by bugdroid1@chromium.org, Feb 28 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2b2426cce14b23d2d91c363c1c65c0d38917b853

commit 2b2426cce14b23d2d91c363c1c65c0d38917b853
Author: tsergeant <tsergeant@chromium.org>
Date: Tue Feb 28 02:06:43 2017

MD History: Fix menu promo not hiding when menu button is clicked

BUG= 696419 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2720903003
Cr-Commit-Position: refs/heads/master@{#453451}

[modify] https://crrev.com/2b2426cce14b23d2d91c363c1c65c0d38917b853/chrome/browser/resources/md_history/app.js
[modify] https://crrev.com/2b2426cce14b23d2d91c363c1c65c0d38917b853/chrome/test/data/webui/md_history/history_toolbar_test.js

Comment 4 by tsergeant@chromium.org, Feb 28 2017

Cc: tbuck...@chromium.org
Status: Fixed (was: Started)
This is now fixed.

I don't think this needs a merge back to M57, but tbuckley@: can you please take a look and confirm?

Comment 5 by tbuck...@chromium.org, Feb 28 2017 

Would this occur for users who already opened the menu / dismissed the tooltip prior to M57?

Assuming that (1) it does not appear for users who previously opened the menu / dismissed the tooltip and (2) users can still dismiss the tooltip, I don't think a merge is necessary.

Comment 6 by tsergeant@chromium.org, Mar 1 2017 

No, it only affects users who see it for the first time and then click the menu button. It can still be dismissed by clicking the close button, and it will only show up once.

So, yup, let's not merge this to beta.
►

Sign in to add a comment