New issue
Advanced search Search tips

Issue 696365 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Apr 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

Server cards last use dates get reset after any modification in Payments

Project Member Reported by se...@chromium.org, Feb 26 2017

Issue description

If one card is modified, they all get their use_date overwritten.
 
What are the steps to reproduce?

Comment 2 by se...@chromium.org, Feb 26 2017

you can see it most visibly if you enable the #enable-autofill-credit-card-last-used-date-display flag.

1- Look at their current last used date value.
2- Add-remove-etc a card in Payments
3- Look at the last used date again, they will show today
Project Member

Comment 4 by bugdroid1@chromium.org, Mar 1 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/76cd49480c8acf3a4ade533c0b9988b33c40ce89

commit 76cd49480c8acf3a4ade533c0b9988b33c40ce89
Author: sebsg <sebsg@chromium.org>
Date: Wed Mar 01 21:19:06 2017

Revert of [Autofill] Split server card data and metadata updates. (patchset #3 id:60001 of https://codereview.chromium.org/2719723002/ )

Reason for revert:
Breaks the Wallet address conversion feature

Original issue's description:
> This caused a bug where the use_date would be reset when adding a new server card.
> The metadata should not be updated in this case.
>
> BUG= 696365 
>
> Review-Url: https://codereview.chromium.org/2719723002
> Cr-Commit-Position: refs/heads/master@{#453210}
> Committed: https://chromium.googlesource.com/chromium/src/+/464db18fe97e6e7f73667db90a761239447d8e97

TBR=mathp@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG= 696365 

Review-Url: https://codereview.chromium.org/2728733002
Cr-Commit-Position: refs/heads/master@{#454032}

[modify] https://crrev.com/76cd49480c8acf3a4ade533c0b9988b33c40ce89/components/autofill/core/browser/autofill_test_utils.cc
[modify] https://crrev.com/76cd49480c8acf3a4ade533c0b9988b33c40ce89/components/autofill/core/browser/webdata/autofill_table.cc
[modify] https://crrev.com/76cd49480c8acf3a4ade533c0b9988b33c40ce89/components/autofill/core/browser/webdata/autofill_table_unittest.cc

Comment 5 by se...@chromium.org, Apr 3 2017

Status: Fixed (was: Started)
Components: -UI>Browser>Autofill>Payments UI>Browser>Payments

Sign in to add a comment