New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 696251 link

Starred by 2 users

Issue metadata

Status: Verified
Owner:
Closed: Feb 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 1
Type: Bug-Security



Sign in to add a comment

Heap-buffer-overflow in v8::internal::Invoke

Project Member Reported by ClusterFuzz, Feb 26 2017

Issue description

Detailed report: https://cluster-fuzz.appspot.com/testcase?key=6614862227832832

Fuzzer: decoder_langfuzz
Job Type: linux_asan_chrome_v8_d8
Platform Id: linux

Crash Type: Heap-buffer-overflow READ 1
Crash Address: 0x622000002c89
Crash State:
  v8::internal::Invoke
  v8::internal::Execution::Call
  v8::Script::Run
  
Sanitizer: address (ASAN)

Recommended Security Severity: Medium

Regressed: V8: 43421:43428

Reproducer Testcase: https://cluster-fuzz.appspot.com/download/AMIfv97huhK6ZFLR1AybbA-b8Wa0asAYTadoTHlOmLVmCMU4Upla9fwvQOJtm_T469aOtxwVttXGjmxF1ukjQLfQ7XmxXFGQ0qGTzm-P35iBhtbNcsIlA-QPt6OnuC-XBtHdjG1abUGldk-SyHTQgvY7gUk8YHaBSl6HNGUAMfNr_Dlx6PK2momwtAdSghXnIWCenxbKCFBhBT1O7lfSKAu1a8C96FiSXGHEblmxmPul6Ll2KxPULps50iWu4aky_eHWPGjBQRYbb8AGQpHGrw2RYsrZylbSWZK6xgYh-ZQw18N4ZFZsgts9uFXcp4csBN2sqZnbbFCIBsbfubgxb-7xfd0tzm6ZzZVFVhSCNlTRHIqLCp-4G1k?testcase_id=6614862227832832


Issue filed automatically.

See https://dev.chromium.org/Home/chromium-security/bugs/reproducing-clusterfuzz-bugs for more information.
 
Project Member

Comment 1 by sheriffbot@chromium.org, Feb 26 2017

Labels: M-58
Project Member

Comment 2 by sheriffbot@chromium.org, Feb 26 2017

Labels: ReleaseBlock-Beta
This issue is a security regression. If you are not able to fix this quickly, please revert the change that introduced it.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 3 by sheriffbot@chromium.org, Feb 26 2017

Labels: Pri-1
Cc: cwhan.t...@gmail.com
Owner: bmeu...@chromium.org
Status: Assigned (was: Untriaged)
This looks like it's triggered by a sort, so I'm suspecting https://codereview.chromium.org/2693043009 from the blame range. Assigning to bmeurer who reviewed the CL and cwhan.tunz@gmail.com who wrote it. Can you please look at this ASAP.
I don't have a permission to see the testcase.
seems there are some cases that do not follow strict weak ordering relation in the comparison function of std::sort.
Being worked on here: https://chromium-review.googlesource.com/c/447036/
Project Member

Comment 8 by bugdroid1@chromium.org, Feb 27 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/cd3a76d56f544c5c90cd262d2576b7bb1ef04c13

commit cd3a76d56f544c5c90cd262d2576b7bb1ef04c13
Author: Choongwoo Han <cwhan.tunz@gmail.com>
Date: Mon Feb 27 11:41:25 2017

[typedarrays] Fix Out of Bound Access in TypedArraySortFast

Compare function for std::sort should satisfy strict weak ordering
relation.

BUG= chromium:696251 

Change-Id: I1c07e3bb1b012fd203bc059a21a75ae0fc61f5ac
Reviewed-on: https://chromium-review.googlesource.com/447036
Reviewed-by: Benedikt Meurer <bmeurer@chromium.org>
Commit-Queue: Peter Marshall <petermarshall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#43446}
[modify] https://crrev.com/cd3a76d56f544c5c90cd262d2576b7bb1ef04c13/src/runtime/runtime-typedarray.cc
[add] https://crrev.com/cd3a76d56f544c5c90cd262d2576b7bb1ef04c13/test/mjsunit/regress/regress-696251.js

Project Member

Comment 9 by ClusterFuzz, Feb 28 2017

ClusterFuzz has detected this issue as fixed in range 43445:43458.

Detailed report: https://cluster-fuzz.appspot.com/testcase?key=6614862227832832

Fuzzer: decoder_langfuzz
Job Type: linux_asan_chrome_v8_d8
Platform Id: linux

Crash Type: Heap-buffer-overflow READ 1
Crash Address: 0x622000002c89
Crash State:
  v8::internal::Invoke
  v8::internal::Execution::Call
  v8::Script::Run
  
Sanitizer: address (ASAN)

Recommended Security Severity: Medium

Regressed: V8: 43421:43428
Fixed: V8: 43445:43458

Reproducer Testcase: https://cluster-fuzz.appspot.com/download/AMIfv97huhK6ZFLR1AybbA-b8Wa0asAYTadoTHlOmLVmCMU4Upla9fwvQOJtm_T469aOtxwVttXGjmxF1ukjQLfQ7XmxXFGQ0qGTzm-P35iBhtbNcsIlA-QPt6OnuC-XBtHdjG1abUGldk-SyHTQgvY7gUk8YHaBSl6HNGUAMfNr_Dlx6PK2momwtAdSghXnIWCenxbKCFBhBT1O7lfSKAu1a8C96FiSXGHEblmxmPul6Ll2KxPULps50iWu4aky_eHWPGjBQRYbb8AGQpHGrw2RYsrZylbSWZK6xgYh-ZQw18N4ZFZsgts9uFXcp4csBN2sqZnbbFCIBsbfubgxb-7xfd0tzm6ZzZVFVhSCNlTRHIqLCp-4G1k?testcase_id=6614862227832832


See https://dev.chromium.org/Home/chromium-security/bugs/reproducing-clusterfuzz-bugs for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Project Member

Comment 10 by ClusterFuzz, Feb 28 2017

Labels: ClusterFuzz-Verified
Status: Verified (was: Assigned)
ClusterFuzz testcase 6614862227832832 is verified as fixed, so closing issue.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.
Project Member

Comment 11 by sheriffbot@chromium.org, Mar 1 2017

Labels: -Restrict-View-SecurityTeam Restrict-View-SecurityNotify
Cc: titzer@chromium.org ishell@chromium.org hablich@chromium.org machenb...@chromium.org
 Issue 698113  has been merged into this issue.
Labels: Merge-Request-58
Project Member

Comment 14 by sheriffbot@chromium.org, Mar 8 2017

Labels: -Merge-Request-58 Hotlist-Merge-Approved Merge-Approved-58
Your change meets the bar and is auto-approved for M58. Please go ahead and merge the CL to branch 3029 manually. Please contact milestone owner if you have questions.
Owners: amineer@(clank), cmasso@(bling), bhthompson@(cros), govind@(desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Cc: petermarshall@chromium.org
 Issue 696462  has been merged into this issue.
Please merge your change to M58 branch 3029 before 5:00 PM PT, Monday (03/13/17) so we can take it in for next week dev release. Thank you!

Labels: -Merge-Approved-58 merge-merged-5.8 Merge-Merged
All three fixes mentioned in c#8 and c#15 are merged: https://codereview.chromium.org/2740943002/
Labels: -ReleaseBlock-Beta
Labels: -reward-topanel reward-unpaid reward-1500
Congratulations! The panel decided to award $1,500 for this bug - cheers!
Labels: -reward-unpaid reward-inprocess
Project Member

Comment 23 by sheriffbot@chromium.org, Jun 7 2017

Labels: -Restrict-View-SecurityNotify allpublic
This bug has been closed for more than 14 weeks. Removing security view restrictions.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Sign in to add a comment