Issue metadata
Sign in to add a comment
|
[A11y Assessment - Downloads Bar] Close button needs better label |
||||||||||||||||||||||||
Issue descriptionChrome Version: 56.0.2924.87 OS: Mac What steps will reproduce the problem? (1) Enable VoiceOver (2) Navigate to the downloads bar (if it's on screen) with Option Ctrl Right The close button on the downloads bar at the bottom just says "close button". This could be confusing if you didn't know where you were and didn't want to close the wrong thing. The label should be "close downloads bar button".
,
Mar 2 2017
,
Mar 7 2017
,
Mar 27 2017
,
Apr 21 2017
,
Nov 17 2017
This affects all platforms, right? It sounds reasonable to me, but I don't think the string exists yet. I'm not sure how to go about getting translations, but maybe you or someone watching the UI>Localization component knows :-)?
,
Nov 20 2017
sdy: you can add a new IDS_ constant to a .grd file and it will be translated without further intervention from you I think. That's probably the right path forward here.
,
Nov 20 2017
Oh, cool. This control is usually referred to as the download shelf, but I don't think it's named in user-facing strings at all yet. Would "close download shelf" be a reasonable name — or just "close downloads"?
,
Nov 20 2017
+srahim@ for c#8
,
Nov 21 2017
I like "hide downloads" for this button and started a CL that changes it to this. However, I'll wait for srahim@ to chime in before I land it.
,
Nov 22 2017
Hi Team, This is a non-localization case. The issue is more on functional case and has to be forwarded to the Engineering Team for review. I'll loop them in to see what they can do about it. Kind Regards, Marvin oLPC
,
Nov 22 2017
Tested the issue on Mac Os 10.12.6 using chrome stable M62 #62.0.3202.94 and M64 #64.0.3275.0 and followed below steps : 1. launched chrome and added chromevox extension. 2. Downloaded sample pdf file and tried house hovering on the downloads close bar at the right bottom end of the browser and observed that chromevox is not spelling anything out. Chromevox is not focusing on the downloads bar . Attached screencast for reference. @ Could someone let us know if we have missed any steps in reproducing the issue and help us in traiging this. Thanks!
,
Nov 22 2017
Re. #12: This is part of the browser UI, so I think you'll have to use VoiceOver.
,
Nov 22 2017
,
Nov 28 2017
Hi Sydney, I agree w/lpalmaro's recommendation, ""Close downloads bar button". It's helpful when a11y labels can help the user visualize what's on the screen. "Hide downloads" may not do that as well as adding a descriptive noun like "bar" or "shelf." Given that we currently use "bar" to describe the bookmarks bar and toolbar, I think "bar" is a good bet over "shelf." "hide" implies that there is an affordance to "show" the downloads bar. Once hidden, is there a way to show it without downloading a new file? If not, then "close" is a more accurate verb to use.
,
Nov 29 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f77b60b7986bb1b248bfe6fbd18832dbf8f6c097 commit f77b60b7986bb1b248bfe6fbd18832dbf8f6c097 Author: Sidney San Martín <sdy@chromium.org> Date: Wed Nov 29 05:25:42 2017 Add a custom a11y label for the download shelf close button. Bug: 696238 Change-Id: Ic689ac6bb245612016467540605cd2b51d9e671e Reviewed-on: https://chromium-review.googlesource.com/783310 Commit-Queue: Sidney San Martín <sdy@chromium.org> Reviewed-by: Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#520016} [modify] https://crrev.com/f77b60b7986bb1b248bfe6fbd18832dbf8f6c097/chrome/app/generated_resources.grd [modify] https://crrev.com/f77b60b7986bb1b248bfe6fbd18832dbf8f6c097/chrome/browser/ui/cocoa/download/download_shelf_controller.mm
,
Nov 29 2017
|
|||||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||||
Comment 1 by lpalmaro@chromium.org
, Feb 26 2017