The NextAction date has arrived: 2017-08-18

I looked at what Cocoa's NSTextView does for completions. Their completions are not accessible with voiceover's navigation keys either, only with keyboard keys, and they are read like this:

with input text "def", press f5:
"initely". [down arrow]
"ense. defense, text (2 of 20)." [down arrow]
"iantly. defiantly, text (3 of 20)."

... and so on. Ours are announced *extremely* inconsistently by comparison - we read random fragments of the *previous* completion with no rhyme or reason. Safari's are read like this:

"Google - google.com [huge hex string] image completion selected"
"w, MagnitfyingGlassCompletionList image, column 2, row 5 empty cell completion selected ww.google.com text deleted"

these are pretty clunky too so I don't think we want to look to Safari for an example.

I'm going to work on making our announcements line up with how the system autocomplete works. I'm on the fence about supporting the VO navigation keys for them - neither Safari nor NSTextView support them so probably we shouldn't.

I think our announcements should be like this:
page result: "www.google.com - Google (suggestion k of n)"
search suggestion: "Search Google for foo (suggestion k of n)"

so I'll implement that.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2c324c1670d06a25eef4fc58896dfc9d614f7d55

commit 2c324c1670d06a25eef4fc58896dfc9d614f7d55
Author: Elly Fong-Jones <ellyjones@chromium.org>
Date: Tue Nov 07 12:18:21 2017

cocoa: announce omnibox autocompletes

This change:
1) Adds AutocompleteMatchType::ToAccessibilityLabel, which turns a match type
   and match text into a descriptive string for an accessibility label;
2) Adds descriptive string templates for most types of autocomplete match;
3) Has OmniboxViewMac announce when the temporary text changes, instead of just
   when the autocomplete text changes.

Bug:  696233 
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: If1df0e49e212810ad7d3bc49c0b5d262e107f7c7
Reviewed-on: https://chromium-review.googlesource.com/728900
Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org>
Reviewed-by: Rohit Rao (ping after 24h) <rohitrao@chromium.org>
Reviewed-by: Mark Pearson <mpearson@chromium.org>
Reviewed-by: Robert Sesek <rsesek@chromium.org>
Reviewed-by: Bret Sepulveda <bsep@chromium.org>
Cr-Commit-Position: refs/heads/master@{#514452}
[modify] https://crrev.com/2c324c1670d06a25eef4fc58896dfc9d614f7d55/chrome/browser/ui/cocoa/omnibox/omnibox_view_mac.h
[modify] https://crrev.com/2c324c1670d06a25eef4fc58896dfc9d614f7d55/chrome/browser/ui/cocoa/omnibox/omnibox_view_mac.mm
[modify] https://crrev.com/2c324c1670d06a25eef4fc58896dfc9d614f7d55/chrome/browser/ui/views/omnibox/omnibox_view_views.cc
[modify] https://crrev.com/2c324c1670d06a25eef4fc58896dfc9d614f7d55/chrome/browser/ui/views/omnibox/omnibox_view_views.h
[modify] https://crrev.com/2c324c1670d06a25eef4fc58896dfc9d614f7d55/components/omnibox/browser/BUILD.gn
[modify] https://crrev.com/2c324c1670d06a25eef4fc58896dfc9d614f7d55/components/omnibox/browser/autocomplete_match_type.cc
[modify] https://crrev.com/2c324c1670d06a25eef4fc58896dfc9d614f7d55/components/omnibox/browser/autocomplete_match_type.h
[add] https://crrev.com/2c324c1670d06a25eef4fc58896dfc9d614f7d55/components/omnibox/browser/autocomplete_match_type_unittest.cc
[modify] https://crrev.com/2c324c1670d06a25eef4fc58896dfc9d614f7d55/components/omnibox/browser/omnibox_edit_model.cc
[modify] https://crrev.com/2c324c1670d06a25eef4fc58896dfc9d614f7d55/components/omnibox/browser/omnibox_edit_unittest.cc
[modify] https://crrev.com/2c324c1670d06a25eef4fc58896dfc9d614f7d55/components/omnibox/browser/omnibox_view.h
[modify] https://crrev.com/2c324c1670d06a25eef4fc58896dfc9d614f7d55/components/omnibox_strings.grdp
[modify] https://crrev.com/2c324c1670d06a25eef4fc58896dfc9d614f7d55/ios/chrome/browser/ui/omnibox/omnibox_view_ios.h
[modify] https://crrev.com/2c324c1670d06a25eef4fc58896dfc9d614f7d55/ios/chrome/browser/ui/omnibox/omnibox_view_ios.mm

There we go :)