The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/39063b7bab59e08486157cf48cd6b159c50a677c

commit 39063b7bab59e08486157cf48cd6b159c50a677c
Author: ellyjones <ellyjones@chromium.org>
Date: Tue Apr 25 18:36:54 2017

cocoa: fix a11y labeling & state on search icon

When this icon is present, it means that there is no current page info to show,
and so it has no tooltip and does not accept mouse presses. This change:

1) Makes the button always have its a11y label, even when it doesn't respond to
   mouse presses
2) Adds LocationBarDecoration::UpdateAccessibilityView to keep the a11y view's
   state synchronized with the decoration's state
3) Makes the Search icon actually reject mouse presses when they won't do
   anything

A side-effect of (3) is that clicking the Search icon now acts as though the
user had clicked the omnibox and focuses the omnibox, instead of doing nothing
at all with no feedback.

BUG=696232

Review-Url: https://codereview.chromium.org/2841963002
Cr-Commit-Position: refs/heads/master@{#467059}

[modify] https://crrev.com/39063b7bab59e08486157cf48cd6b159c50a677c/chrome/browser/ui/cocoa/location_bar/location_bar_decoration.h
[modify] https://crrev.com/39063b7bab59e08486157cf48cd6b159c50a677c/chrome/browser/ui/cocoa/location_bar/location_bar_decoration.mm
[modify] https://crrev.com/39063b7bab59e08486157cf48cd6b159c50a677c/chrome/browser/ui/cocoa/location_bar/location_bar_view_mac.h
[modify] https://crrev.com/39063b7bab59e08486157cf48cd6b159c50a677c/chrome/browser/ui/cocoa/location_bar/location_bar_view_mac.mm
[modify] https://crrev.com/39063b7bab59e08486157cf48cd6b159c50a677c/chrome/browser/ui/cocoa/location_bar/location_icon_decoration.h
[modify] https://crrev.com/39063b7bab59e08486157cf48cd6b159c50a677c/chrome/browser/ui/cocoa/location_bar/location_icon_decoration.mm

This is now fixed on Mac. Who should it go to for Chrome OS?

+emshec to help route

+pkasting

For views, I suggest estade.

+dmazzoni

ChromeVox on CrOS has been broken for me for months. Is there a workaround? I used to be able to see spoken feedback as text in the header bar. Now I just get a million console errors:

[16384:16384:0427/161910.013169:ERROR:CONSOLE(1863)] "Uncaught TypeError: Cannot read property 'updateIndicatorIfChanged' of null", source: chrome-extension://chromevox/chromeVoxChromePageScript.js (1863)
[16384:16384:0427/161910.025105:ERROR:CONSOLE(1863)] "Uncaught TypeError: Cannot read property 'updateIndicatorIfChanged' of null", source: chrome-extension://chromevox/chromeVoxChromePageScript.js (1863)
[16384:16384:0427/161910.026017:ERROR:CONSOLE(1863)] "Uncaught TypeError: Cannot read property 'updateIndicatorIfChanged' of null", source: chrome-extension://chromevox/chromeVoxChromePageScript.js (1863)
[16384:16384:0427/161910.500325:ERROR:CONSOLE(2029)] "Uncaught TypeError: cvox.ChromeVox.recallInit_ is not a function", source: chrome-extension://chromevox/chromeVoxChromePageScript.js (2029)
[16384:16384:0427/161911.414748:ERROR:CONSOLE(264)] "Uncaught TypeError: Cannot read property 'activeIndicator' of null", source: chrome-extension://chromevox/chromevox/injected/event_watcher.js (264)
[16384:16384:0427/161911.415309:ERROR:CONSOLE(1863)] "Uncaught TypeError: Cannot read property 'updateIndicatorIfChanged' of null", source: chrome-extension://chromevox/chromeVoxChromePageScript.js (1863)
[16384:16384:0427/161911.415771:ERROR:CONSOLE(1863)] "Uncaught TypeError: Cannot read property 'updateIndicatorIfChanged' of null", source: chrome-extension://chromevox/chromeVoxChromePageScript.js (1863)
[16384:16384:0427/161911.422967:ERROR:CONSOLE(1852)] "Uncaught TypeError: Cannot read property 'activeIndicator' of null", source: chrome-extension://chromevox/chromeVoxChromePageScript.js (1852)
[16384:16384:0427/161911.423336:ERROR:CONSOLE(264)] "Uncaught TypeError: Cannot read property 'activeIndicator' of null", source: chrome-extension://chromevox/chromevox/injected/event_watcher.js (264)
[16384:16384:0427/161911.423698:ERROR:CONSOLE(1852)] "Uncaught TypeError: Cannot read property 'activeIndicator' of null", source: chrome-extension://chromevox/chromeVoxChromePageScript.js (1852)
[16384:16384:0427/161911.667155:ERROR:CONSOLE(264)] "Uncaught TypeError: Cannot read property 'activeIndicator' of null", source: chrome-extension://chromevox/chromevox/injected/event_watcher.js (264)

[etc]

+dtseng might also be able to help with the question in comment 14. David, any tips on what I'm doing wrong and how I can get ChromeVox (Next) to work?

Are you trying to install the extension by any chance? If you try to install the extension on Chrome OS I can see that being broken. You should just press Ctrl+Alt+Z or toggle it in the settings and the built-in extension should work fine.

Other gotchas I can think of:
* Need nacl (are you building with --enable-nacl)?
* Possibly a profile in a weird state - try a fresh profile to see?

I did try a fresh profile, I did not install the extension manually. I didn't disable nacl and it seems that it's enabled by default. Everything works except the text in the header bar. (I even installed the text to speech library to see if that had an effect, but no dice.)

This P-1 bug seems to have been abandoned.  Oops. :-P  It looks like dmazzoni@ and estade@ didn't manage to get figure out how to get an appropriate development environment set up?  I'm putting this contentless comment on this bug thread in hopes of jump-starting the conversation again.

It does have a label on Mac now, so it should go to a Views UI person to fix the Views labelling.

Assigning to dmazzoni@ to help estade@ get a setup that works.  It sounds estade@ is willing to fix this bug if you can test his fix.

Friendly ping to see if we can pick up work here.