New issue
Advanced search Search tips

Issue 696216 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

AA blending might be wrong

Project Member Reported by liyuqian@google.com, Feb 25 2017

Issue description

Components: Internals>Skia
Cc: mtklein@chromium.org
Status: Available (was: Untriaged)
Thanks to fmalita@, I find out that removing "#define SK_SUPPORT_LEGACY_BROKEN_LERP" will fix the bug. Should I just close this bug, or merge this bug into the one that aims to remove the legacy broken lerp?
Either one sounds fine.  I gave up trying to rebaseline that flag in Chrome.
Do you also have thousands of files to rebaseline like my analyltic AA CL?

If that's the case, the good news is that Gerrit is now available.
According to my experience, it's much simpler to use Gerrit the land such
massive rebaseline CL.
Owner: fmalita@chromium.org
Status: Assigned (was: Available)
I've uploaded at test CL at some point and there were lots of diffs (>1000?).  Never got around to rebaseline everything, but good point about Gerrit.  I'll give it a shot.
Project Member

Comment 6 by bugdroid1@chromium.org, Mar 7 2017

Project Member

Comment 7 by bugdroid1@chromium.org, Mar 12 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/393cf62456bcd37c4dd4dd2c995597c5d5012ea6

commit 393cf62456bcd37c4dd4dd2c995597c5d5012ea6
Author: Florin Malita <fmalita@chromium.org>
Date: Sun Mar 12 17:20:51 2017

Remove SK_SUPPORT_LEGACY_BROKEN_LERP

Turn on improved Skia LERP functions.  This is expected to trivially affect lots of
pixel tests (minor anti-aliasing diffs).

BUG= 696216 
TBR=mtklein@google.com,liyuquian@google.com
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2731393002 .
Cr-Commit-Position: refs/heads/master@{#456303}

[modify] https://crrev.com/393cf62456bcd37c4dd4dd2c995597c5d5012ea6/cc/test/data/background_filter_on_scaled_layer_sw.png
[modify] https://crrev.com/393cf62456bcd37c4dd4dd2c995597c5d5012ea6/cc/test/data/rotated_drop_shadow_filter_sw.png
[modify] https://crrev.com/393cf62456bcd37c4dd4dd2c995597c5d5012ea6/cc/test/data/rotated_filter_sw.png
[modify] https://crrev.com/393cf62456bcd37c4dd4dd2c995597c5d5012ea6/skia/config/SkUserConfig.h
[modify] https://crrev.com/393cf62456bcd37c4dd4dd2c995597c5d5012ea6/third_party/WebKit/LayoutTests/canvas/philip/tests/2d.path.arcTo.shape.curve2.html
[modify] https://crrev.com/393cf62456bcd37c4dd4dd2c995597c5d5012ea6/third_party/WebKit/LayoutTests/compositing/background-color/background-color-outside-document-expected.png
[delete] https://crrev.com/12fb4ebfdafb2660d75e85b8b4d233fd3cfe1507/third_party/WebKit/LayoutTests/compositing/overflow/clip-parent-reset-expected.html
[modify] https://crrev.com/393cf62456bcd37c4dd4dd2c995597c5d5012ea6/third_party/WebKit/LayoutTests/compositing/overflow/grandchild-composited-with-border-radius-ancestor-expected.png
[modify] https://crrev.com/393cf62456bcd37c4dd4dd2c995597c5d5012ea6/third_party/WebKit/LayoutTests/compositing/overflow/grandchild-with-border-radius-ancestor-expected.png
[add] https://crrev.com/393cf62456bcd37c4dd4dd2c995597c5d5012ea6/third_party/WebKit/LayoutTests/compositing/overflow/nested-render-surfaces-expected.png
[add] https://crrev.com/393cf62456bcd37c4dd4dd2c995597c5d5012ea6/third_party/WebKit/LayoutTests/compositing/overflow/nested-render-surfaces-with-intervening-clip-expected.png
[modify] https://crrev.com/393cf62456bcd37c4dd4dd2c995597c5d5012ea6/third_party/WebKit/LayoutTests/compositing/overflow/siblings-composited-with-border-radius-ancestor-expected.png
[modify] https://crrev.com/393cf62456bcd37c4dd4dd2c995597c5d5012ea6/third_party/WebKit/LayoutTests/compositing/overflow/siblings-composited-with-border-radius-ancestor-one-clipped-expected.png
[modify] https://crrev.com/393cf62456bcd37c4dd4dd2c995597c5d5012ea6/third_party/WebKit/LayoutTests/compositing/overflow/siblings-with-border-radius-ancestor-expected.png
[modify] https://crrev.com/393cf62456bcd37c4dd4dd2c995597c5d5012ea6/third_party/WebKit/LayoutTests/css3/blending/background-blend-mode-svg-color-expected.png
[modify] https://crrev.com/393cf62456bcd37c4dd4dd2c995597c5d5012ea6/third_party/WebKit/LayoutTests/css3/filters/css-opacity-with-drop-shadow-expected.png
[modify] https://crrev.com/393cf62456bcd37c4dd4dd2c995597c5d5012ea6/third_party/WebKit/LayoutTests/css3/filters/nested-filter-expected.png
[modify] https://crrev.com/393cf62456bcd37c4dd4dd2c995597c5d5012ea6/third_party/WebKit/LayoutTests/css3/masking/clip-path-circle-filter-expected.png
[delete] https://crrev.com/12fb4ebfdafb2660d75e85b8b4d233fd3cfe1507/third_party/WebKit/LayoutTests/fast/backgrounds/animated-gif-as-background-rounded-expected.html
[modify] https://crrev.com/393cf62456bcd37c4dd4dd2c995597c5d5012ea6/third_party/WebKit/LayoutTests/fast/backgrounds/background-color-image-border-radius-bleed-expected.png
[modify] https://crrev.com/393cf62456bcd37c4dd4dd2c995597c5d5012ea6/third_party/WebKit/LayoutTests/fast/backgrounds/background-leakage-expected.png
[modify] https://crrev.com/393cf62456bcd37c4dd4dd2c995597c5d5012ea6/third_party/WebKit/LayoutTests/fast/backgrounds/background-multi-image-border-radius-bleed-expected.png
[modify] https://crrev.com/393cf62456bcd37c4dd4dd2c995597c5d5012ea6/third_party/WebKit/LayoutTests/fast/backgrounds/background-svg-scaling-expected.png
[modify] https://crrev.com/393cf62456bcd37c4dd4dd2c995597c5d5012ea6/third_party/WebKit/LayoutTests/fast/backgrounds/gradient-background-leakage-2-expected.png
[modify] https://crrev.com/393cf62456bcd37c4dd4dd2c995597c5d5012ea6/third_party/WebKit/LayoutTests/fast/backgrounds/gradient-background-leakage-expected.png
[modify] https://crrev.com/393cf62456bcd37c4dd4dd2c995597c5d5012ea6/third_party/WebKit/LayoutTests/fast/backgrounds/gradient-background-leakage-hidpi-expected.png
[modify] https://crrev.com/393cf62456bcd37c4dd4dd2c995597c5d5012ea6/third_party/WebKit/LayoutTests/fast/backgrounds/mask-box-image-expected.png
[modify] https://crrev.com/393cf62456bcd37c4dd4dd2c995597c5d5012ea6/third_party/WebKit/LayoutTests/fast/backgrounds/size/contain-and-cover-expected.png
[modify] https://crrev.com/393cf62456bcd37c4dd4dd2c995597c5d5012ea6/third_party/WebKit/LayoutTests/fast/backgrounds/size/contain-and-cover-zoomed-expected.png
[modify] https://crrev.com/393cf62456bcd37c4dd4dd2c995597c5d5012ea6/third_party/WebKit/LayoutTests/fast/backgrounds/svg-as-mask-expected.png
[modify] https://crrev.com/393cf62456bcd37c4dd4dd2c995597c5d5012ea6/third_party/WebKit/LayoutTests/fast/backgrounds/transformed-body-background-expected.png
[modify] https://crrev.com/393cf62456bcd37c4dd4dd2c995597c5d5012ea6/third_party/WebKit/LayoutTests/fast/backgrounds/transformed-body-html-background-expected.png
[modify] https://crrev.com/393cf62456bcd37c4dd4dd2c995597c5d5012ea6/third_party/WebKit/LayoutTests/fast/backgrounds/transformed-html-body-background-expected.png
[modify] https://crrev.com/393cf62456bcd37c4dd4dd2c995597c5d5012ea6/third_party/WebKit/LayoutTests/fast/block/basic/quirk-percent-height-table-cell-expected.png
[modify] https://crrev.com/393cf62456bcd37c4dd4dd2c995597c5d5012ea6/third_party/WebKit/LayoutTests/fast/borders/border-image-rotate-transform-expected.png
[modify] https://crrev.com/393cf62456bcd37c4dd4dd2c995597c5d5012ea6/third_party/WebKit/LayoutTests/fast/borders/border-left-right-same-bottom-different-color-expected.png
[modify] https://crrev.com/393cf62456bcd37c4dd4dd2c995597c5d5012ea6/third_party/WebKit/LayoutTests/fast/borders/border-mixed-alpha-expected.png
[modify] https://crrev.com/393cf62456bcd37c4dd4dd2c995597c5d5012ea6/third_party/WebKit/LayoutTests/fast/borders/border-mixed-alpha2-expected.png
[modify] https://crrev.com/393cf62456bcd37c4dd4dd2c995597c5d5012ea6/third_party/WebKit/LayoutTests/fast/borders/border-radius-circle-expected.png
[modify] https://crrev.com/393cf62456bcd37c4dd4dd2c995597c5d5012ea6/third_party/WebKit/LayoutTests/fast/borders/border-radius-different-width-001-double-expected.png
[modify] https://crrev.com/393cf62456bcd37c4dd4dd2c995597c5d5012ea6/third_party/WebKit/LayoutTests/fast/borders/border-radius-different-width-001-expected.png
[modify] https://crrev.com/393cf62456bcd37c4dd4dd2c995597c5d5012ea6/third_party/WebKit/LayoutTests/fast/borders/border-radius-groove-03-expected.png
[modify] https://crrev.com/393cf62456bcd37c4dd4dd2c995597c5d5012ea6/third_party/WebKit/LayoutTests/fast/borders/border-radius-inset-outset-expected.png
[modify] https://crrev.com/393cf62456bcd37c4dd4dd2c995597c5d5012ea6/third_party/WebKit/LayoutTests/fast/borders/border-radius-wide-border-01-expected.png
[modify] https://crrev.com/393cf62456bcd37c4dd4dd2c995597c5d5012ea6/third_party/WebKit/LayoutTests/fast/borders/border-radius-wide-border-03-expected.png
[modify] https://crrev.com/393cf62456bcd37c4dd4dd2c995597c5d5012ea6/third_party/WebKit/LayoutTests/fast/borders/border-radius-wide-border-04-expected.png
[modify] https://crrev.com/393cf62456bcd37c4dd4dd2c995597c5d5012ea6/third_party/WebKit/LayoutTests/fast/borders/border-radius-wide-border-05-expected.png
[modify] https://crrev.com/393cf62456bcd37c4dd4dd2c995597c5d5012ea6/third_party/WebKit/LayoutTests/fast/borders/border-radius-with-box-shadow-expected.png
[modify] https://crrev.com/393cf62456bcd37c4dd4dd2c995597c5d5012ea6/third_party/WebKit/LayoutTests/fast/borders/border-shadow-large-radius-expected.png
[modify] https://crrev.com/393cf62456bcd37c4dd4dd2c995597c5d5012ea6/third_party/WebKit/LayoutTests/fast/borders/borderRadiusDotted02-expected.png
[modify] https://crrev.com/393cf62456bcd37c4dd4dd2c995597c5d5012ea6/third_party/WebKit/LayoutTests/fast/borders/borderRadiusDotted03-expected.png
[modify] https://crrev.com/393cf62456bcd37c4dd4dd2c995597c5d5012ea6/third_party/WebKit/LayoutTests/fast/borders/borderRadiusDotted05-expected.png
[modify] https://crrev.com/393cf62456bcd37c4dd4dd2c995597c5d5012ea6/third_party/WebKit/LayoutTests/fast/borders/borderRadiusDotted06-expected.png
[modify] https://crrev.com/393cf62456bcd37c4dd4dd2c995597c5d5012ea6/third_party/WebKit/LayoutTests/fast/borders/borderRadiusDouble01-expected.png
[modify] https://crrev.com/393cf62456bcd37c4dd4dd2c995597c5d5012ea6/third_party/WebKit/LayoutTests/fast/borders/borderRadiusDouble02-expected.png
[modify] https://crrev.com/393cf62456bcd37c4dd4dd2c995597c5d5012ea6/third_party/WebKit/LayoutTests/fast/borders/borderRadiusDouble03-expected.png
[modify] https://crrev.com/393cf62456bcd37c4dd4dd2c995597c5d5012ea6/third_party/WebKit/LayoutTests/fast/borders/borderRadiusDouble05-expected.png
[modify] https://crrev.com/393cf62456bcd37c4dd4dd2c995597c5d5012ea6/third_party/WebKit/LayoutTests/fast/borders/borderRadiusDouble09-expected.png
[modify] https://crrev.com/393cf62456bcd37c4dd4dd2c995597c5d5012ea6/third_party/WebKit/LayoutTests/fast/borders/borderRadiusInset01-expected.png
[modify] https://crrev.com/393cf62456bcd37c4dd4dd2c995597c5d5012ea6/third_party/WebKit/LayoutTests/fast/borders/borderRadiusSolid01-expected.png
[modify] https://crrev.com/393cf62456bcd37c4dd4dd2c995597c5d5012ea6/third_party/WebKit/LayoutTests/fast/borders/borderRadiusSolid02-expected.png
[modify] https://crrev.com/393cf62456bcd37c4dd4dd2c995597c5d5012ea6/third_party/WebKit/LayoutTests/fast/borders/borderRadiusSolid03-expected.png
[modify] https://crrev.com/393cf62456bcd37c4dd4dd2c995597c5d5012ea6/third_party/WebKit/LayoutTests/fast/borders/fieldsetBorderRadius-expected.png
[modify] https://crrev.com/393cf62456bcd37c4dd4dd2c995597c5d5012ea6/third_party/WebKit/LayoutTests/fast/borders/mixed-border-styles-expected.png
[modify] https://crrev.com/393cf62456bcd37c4dd4dd2c995597c5d5012ea6/third_party/WebKit/LayoutTests/fast/borders/mixed-border-styles-radius-expected.png
[modify] https://crrev.com/393cf62456bcd37c4dd4dd2c995597c5d5012ea6/third_party/WebKit/LayoutTests/fast/borders/mixed-border-styles-radius2-expected.png
[modify] https://crrev.com/393cf62456bcd37c4dd4dd2c995597c5d5012ea6/third_party/WebKit/LayoutTests/fast/borders/webkit-border-radius-expected.png
[modify] https://crrev.com/393cf62456bcd37c4dd4dd2c995597c5d5012ea6/third_party/WebKit/LayoutTests/fast/box-shadow/box-shadow-clipped-slices-expected.png
[modify] https://crrev.com/393cf62456bcd37c4dd4dd2c995597c5d5012ea6/third_party/WebKit/LayoutTests/fast/box-shadow/box-shadow-radius-expected.png
[modify] https://crrev.com/393cf62456bcd37c4dd4dd2c995597c5d5012ea6/third_party/WebKit/LayoutTests/fast/box-shadow/box-shadow-with-zero-radius-expected.png
[modify] https://crrev.com/393cf62456bcd37c4dd4dd2c995597c5d5012ea6/third_party/WebKit/LayoutTests/fast/box-shadow/inset-box-shadow-radius-expected.png
[modify] https://crrev.com/393cf62456bcd37c4dd4dd2c995597c5d5012ea6/third_party/WebKit/LayoutTests/fast/box-shadow/inset-box-shadows-expected.png
[modify] https://crrev.com/393cf62456bcd37c4dd4dd2c995597c5d5012ea6/third_party/WebKit/LayoutTests/fast/box-shadow/inset-with-extraordinary-radii-and-border-expected.png
[modify] https://crrev.com/393cf62456bcd37c4dd4dd2c995597c5d5012ea6/third_party/WebKit/LayoutTests/fast/box-shadow/scaled-box-shadow-expected.png
[modify] https://crrev.com/393cf62456bcd37c4dd4dd2c995597c5d5012ea6/third_party/WebKit/LayoutTests/fast/box-shadow/spread-expected.png
[modify] https://crrev.com/393cf62456bcd37c4dd4dd2c995597c5d5012ea6/third_party/WebKit/LayoutTests/fast/box-shadow/spread-multiple-normal-expected.png
[modify] https://crrev.com/393cf62456bcd37c4dd4dd2c995597c5d5012ea6/third_party/WebKit/LayoutTests/fast/canvas/canvas-drawImage-video-expected.png
[modify] https://crrev.com/393cf62456bcd37c4dd4dd2c995597c5d5012ea6/third_party/WebKit/LayoutTests/fast/canvas/canvas-ellipse-connecting-line-expected.png
[modify] https://crrev.com/393cf62456bcd37c4dd4dd2c995597c5d5012ea6/third_party/WebKit/LayoutTests/fast/canvas/canvas-pattern-no-repeat-with-transformations-expected.png
[modify] https://crrev.com/393cf62456bcd37c4dd4dd2c995597c5d5012ea6/third_party/WebKit/LayoutTests/fast/canvas/yuv-video-on-accelerated-canvas-expected.png
[modify] https://crrev.com/393cf62456bcd37c4dd4dd2c995597c5d5012ea6/third_party/WebKit/LayoutTests/fast/css/background-clip-radius-values-expected.png
[modify] https://crrev.com/393cf62456bcd37c4dd4dd2c995597c5d5012ea6/third_party/WebKit/LayoutTests/fast/css/border-radius-non-negative-expected.png
[modify] https://crrev.com/393cf62456bcd37c4dd4dd2c995597c5d5012ea6/third_party/WebKit/LayoutTests/fast/css/border-solid-single-edge-antialias-expected.png
[modify] https://crrev.com/393cf62456bcd37c4dd4dd2c995597c5d5012ea6/third_party/WebKit/LayoutTests/fast/css/box-shadow-and-border-radius-expected.png
[modify] https://crrev.com/393cf62456bcd37c4dd4dd2c995597c5d5012ea6/third_party/WebKit/LayoutTests/fast/css3-text/css3-text-decoration/text-decoration-skip-expected.png
[modify] https://crrev.com/393cf62456bcd37c4dd4dd2c995597c5d5012ea6/third_party/WebKit/LayoutTests/fast/frames/frame-set-scaling-skew-expected.png
[modify] https://crrev.com/393cf62456bcd37c4dd4dd2c995597c5d5012ea6/third_party/WebKit/LayoutTests/fast/gradients/background-clipped-expected.png
[add] https://crrev.com/393cf62456bcd37c4dd4dd2c995597c5d5012ea6/third_party/WebKit/LayoutTests/fast/layers/add-layer-with-nested-stacking-expected.png
[modify] https://crrev.com/393cf62456bcd37c4dd4dd2c995597c5d5012ea6/third_party/WebKit/LayoutTests/fast/table/border-radius-with-image-expected.png
[modify] https://crrev.com/393cf62456bcd37c4dd4dd2c995597c5d5012ea6/third_party/WebKit/LayoutTests/fast/table/table-with-border-radius-expected.png
[add] https://crrev.com/393cf62456bcd37c4dd4dd2c995597c5d5012ea6/third_party/WebKit/LayoutTests/fast/text/decorations-transformed-expected.png
[modify] https://crrev.com/393cf62456bcd37c4dd4dd2c995597c5d5012ea6/third_party/WebKit/LayoutTests/http/tests/inspector/network/waterfall-images-expected.png
[modify] https://crrev.com/393cf62456bcd37c4dd4dd2c995597c5d5012ea6/third_party/WebKit/LayoutTests/http/tests/mime/png-image-with-x-png-mime-type-expected.png
[modify] https://crrev.com/393cf62456bcd37c4dd4dd2c995597c5d5012ea6/third_party/WebKit/LayoutTests/images/drag-svg-image-expected.png
[modify] https://crrev.com/393cf62456bcd37c4dd4dd2c995597c5d5012ea6/third_party/WebKit/LayoutTests/images/sprite-no-bleed-expected.png
[modify] https://crrev.com/393cf62456bcd37c4dd4dd2c995597c5d5012ea6/third_party/WebKit/LayoutTests/paint/invalidation/border-radius-repaint-2-expected.png
[delete] https://crrev.com/12fb4ebfdafb2660d75e85b8b4d233fd3cfe1507/third_party/WebKit/LayoutTests/paint/invalidation/column-float-under-stacked-inline-expected.html
[add] https://crrev.com/393cf62456bcd37c4dd4dd2c995597c5d5012ea6/third_party/WebKit/LayoutTests/paint/invalidation/column-float-under-stacked-inline-expected.png
[add] https://crrev.com/393cf62456bcd37c4dd4dd2c995597c5d5012ea6/third_party/WebKit/LayoutTests/paint/invalidation/column-float-under-stacked-inline-expected.txt
[delete] https://crrev.com/12fb4ebfdafb2660d75e85b8b4d233fd3cfe1507/third_party/WebKit/LayoutTests/paint/invalidation/invalidate-caret-before-text-node-update-expected.png
[modify] https://crrev.com/393cf62456bcd37c4dd4dd2c995597c5d5012ea6/third_party/WebKit/LayoutTests/paint/invalidation/nested-iframe-scroll-inner-expected.png
[modify] https://crrev.com/393cf62456bcd37c4dd4dd2c995597c5d5012ea6/third_party/WebKit/LayoutTests/paint/invalidation/nested-iframe-scroll-outer-expected.png
[modify] https://crrev.com/393cf62456bcd37c4dd4dd2c995597c5d5012ea6/third_party/WebKit/LayoutTests/paint/invalidation/rotated-subpixel-expected.png
[add] https://crrev.com/393cf62456bcd37c4dd4dd2c995597c5d5012ea6/third_party/WebKit/LayoutTests/paint/invalidation/svg/absolute-sized-document-no-scrollbars-expected.png
[add] https://crrev.com/393cf62456bcd37c4dd4dd2c995597c5d5012ea6/third_party/WebKit/LayoutTests/paint/invalidation/svg/absolute-sized-document-no-scrollbars-text-zoom-expected.png
[add] https://crrev.com/393cf62456bcd37c4dd4dd2c995597c5d5012ea6/third_party/WebKit/LayoutTests/paint/invalidation/svg/absolute-sized-document-scrollbars-expected.png
[modify] https://crrev.com/393cf62456bcd37c4dd4dd2c995597c5d5012ea6/third_party/WebKit/LayoutTests/paint/invalidation/svg/animate-path-morphing-expected.png
[modify] https://crrev.com/393cf62456bcd37c4dd4dd2c995597c5d5012ea6/third_party/WebKit/LayoutTests/paint/invalidation/svg/deep-dynamic-updates-expected.png
[modify] https://crrev.com/393cf62456bcd37c4dd4dd2c995597c5d5012ea6/third_party/WebKit/LayoutTests/paint/invalidation/svg/fill-opacity-update-expected.png
[modify] https://crrev.com/393cf62456bcd37c4dd4dd2c995597c5d5012ea6/third_party/WebKit/LayoutTests/paint/invalidation/svg/foreign-object-repaint-expected.png
[modify] https://crrev.com/393cf62456bcd37c4dd4dd2c995597c5d5012ea6/third_party/WebKit/LayoutTests/paint/invalidation/svg/js-late-marker-and-object-creation-expected.png
[modify] https://crrev.com/393cf62456bcd37c4dd4dd2c995597c5d5012ea6/third_party/WebKit/LayoutTests/paint/invalidation/svg/js-late-marker-creation-expected.png
[modify] https://crrev.com/393cf62456bcd37c4dd4dd2c995597c5d5012ea6/third_party/WebKit/LayoutTests/paint/invalidation/svg/js-repaint-rect-on-path-with-stroke-expected.png
[modify] https://crrev.com/393cf62456bcd37c4dd4dd2c995597c5d5012ea6/third_party/WebKit/LayoutTests/paint/invalidation/svg/js-update-bounce-expected.png
[modify] https://crrev.com/393cf62456bcd37c4dd4dd2c995597c5d5012ea6/third_party/WebKit/LayoutTests/paint/invalidation/svg/js-update-container-expected.png
[modify] https://crrev.com/393cf62456bcd37c4dd4dd2c995597c5d5012ea6/third_party/WebKit/LayoutTests/paint/invalidation/svg/js-update-container2-expected.png
[modify] https://crrev.com/393cf62456bcd37c4dd4dd2c995597c5d5012ea6/third_party/WebKit/LayoutTests/paint/invalidation/svg/js-update-polygon-changes-expected.png
[modify] https://crrev.com/393cf62456bcd37c4dd4dd2c995597c5d5012ea6/third_party/WebKit/LayoutTests/paint/invalidation/svg/js-update-polygon-removal-expected.png
[modify] https://crrev.com/393cf62456bcd37c4dd4dd2c995597c5d5012ea6/third_party/WebKit/LayoutTests/paint/invalidation/svg/js-update-transform-addition-expected.png
[modify] https://crrev.com/393cf62456bcd37c4dd4dd2c995597c5d5012ea6/third_party/WebKit/LayoutTests/paint/invalidation/svg/js-update-transform-changes-expected.png
[modify] https://crrev.com/393cf62456bcd37c4dd4dd2c995597c5d5012ea6/third_party/WebKit/LayoutTests/paint/invalidation/svg/mask-clip-target-transform-expected.png
[modify] https://crrev.com/393cf62456bcd37c4dd4dd2c995597c5d5012ea6/third_party/WebKit/LayoutTests/paint/invalidation/svg/object-sizing-no-width-height-change-content-box-size-expected.png
[modify] https://crrev.com/393cf62456bcd37c4dd4dd2c995597c5d5012ea6/third_party/WebKit/LayoutTests/paint/invalidation/svg/paintorder-filtered-expected.png
[add] https://crrev.com/393cf62456bcd37c4dd4dd2c995597c5d5012ea6/third_party/WebKit/LayoutTests/paint/invalidation/svg/relative-sized-document-scrollbars-expected.png
[add] https://crrev.com/393cf62456bcd37c4dd4dd2c995597c5d5012ea6/third_party/WebKit/LayoutTests/paint/invalidation/svg/relative-sized-document-scrollbars-text-zoom-expected.png
[modify] https://crrev.com/393cf62456bcd37c4dd4dd2c995597c5d5012ea6/third_party/WebKit/LayoutTests/paint/invalidation/svg/repaint-paintorder-expected.png
[modify] https://crrev.com/393cf62456bcd37c4dd4dd2c995597c5d5012ea6/third_party/WebKit/LayoutTests/paint/invalidation/svg/repaint-stroke-width-changes-expected.png
[modify] https://crrev.com/393cf62456bcd37c4dd4dd2c995597c5d5012ea6/third_party/WebKit/LayoutTests/paint/invalidation/svg/stroke-opacity-update-expected.png
[add] https://crrev.com/393cf62456bcd37c4dd4dd2c995597c5d5012ea6/third_party/WebKit/LayoutTests/paint/invalidation/svg/text-dom-removal-expected.png
[delete] https://crrev.com/12fb4ebfdafb2660d75e85b8b4d233fd3cfe1507/third_party/WebKit/LayoutTests/paint/invalidation/textarea-caret-expected.png
[modify] https://crrev.com/393cf62456bcd37c4dd4dd2c995597c5d5012ea6/third_party/WebKit/LayoutTests/paint/transforms/percentage-transform-fractional-box-size-expected.png
[modify] https://crrev.com/393cf62456bcd37c4dd4dd2c995597c5d5012ea6/third_party/WebKit/LayoutTests/platform/linux/compositing/direct-image-compositing-expected.png
[modify] https://crrev.com/393cf62456bcd37c4dd4dd2c995597c5d5012ea6/third_party/WebKit/LayoutTests/platform/linux/compositing/generated-content-expected.png
[modify] https://crrev.com/393cf62456bcd37c4dd4dd2c995597c5d5012ea6/third_party/WebKit/LayoutTests/platform/linux/compositing/geometry/abs-position-inside-opacity-expected.png
[modify] https://crrev.com/393cf62456bcd37c4dd4dd2c995597c5d5012ea6/third_party/WebKit/LayoutTests/platform/linux/compositing/geometry/fixed-position-iframe-composited-page-scale-expected.png
[modify] https://crrev.com/393cf62456bcd37c4dd4dd2c995597c5d5012ea6/third_party/WebKit/LayoutTests/platform/linux/compositing/gestures/gesture-tapHighlight-pixel-rotated-div-expected.png
[modify] https://crrev.com/393cf62456bcd37c4dd4dd2c995597c5d5012ea6/third_party/WebKit/LayoutTests/platform/linux/compositing/gestures/gesture-tapHighlight-with-box-shadow-expected.png
[add] https://crrev.com/393cf62456bcd37c4dd4dd2c995597c5d5012ea6/third_party/WebKit/LayoutTests/platform/linux/compositing/overflow/clip-parent-reset-expected.png
[add] https://crrev.com/393cf62456bcd37c4dd4dd2c995597c5d5012ea6/third_party/WebKit/LayoutTests/platform/linux/compositing/overflow/clip-parent-reset-expected.txt
[modify] https://crrev.com/393cf62456bcd37c4dd4dd2c995597c5d5012ea6/third_party/WebKit/LayoutTests/platform/linux/compositing/overflow/mask-with-filter-expected.png
[modify] https://crrev.com/393cf62456bcd37c4dd4dd2c995597c5d5012ea6/third_party/WebKit/LayoutTests/platform/linux/compositing/overflow/mask-with-small-content-rect-expected.png
[modify] https://crrev.com/393cf62456bcd37c4dd4dd2c995597c5d5012ea6/third_party/WebKit/LayoutTests/platform/linux/compositing/overflow/nested-border-radius-clipping-expected.png
[modify] https://crrev.com/393cf62456bcd37c4dd4dd2c995597c5d5012ea6/third_party/WebKit/LayoutTests/platform/linux/compositing/overflow/scaled-mask-expected.png
[modify] https://crrev.com/393cf62456bcd37c4dd4dd2c995597c5d5012ea6/third_party/WebKit/LayoutTests/platform/linux/compositing/overflow/tiled-mask-expected.png
[modify] https://crrev.com/393cf62456bcd37c4dd4dd2c995597c5d5012ea6/third_party/WebKit/LayoutTests/platform/linux/compositing/overflow/update-widget-positions-on-nested-frames-and-scrollers-expected.png
[modify] https://crrev.com/393cf62456bcd37c4dd4dd2c995597c5d5012ea6/third_party/WebKit/LayoutTests/platform/linux/compositing/shadows/shadow-drawing-expected.png
[modify] https://crrev.com/393cf62456bcd37c4dd4dd2c995597c5d5012ea6/third_party/WebKit/LayoutTests/platform/linux/compositing/sibling-positioning-expected.png
[add] https://crrev.com/393cf62456bcd37c4dd4dd2c995597c5d5012ea6/third_party/WebKit/LayoutTests/platform/linux/compositing/squashing/squashing-print-expected.png
[modify] https://crrev.com/393cf62456bcd37c4dd4dd2c995597c5d5012ea6/third_party/WebKit/LayoutTests/platform/linux/compositing/video/video-controls-layer-creation-expected.png
[modify] https://crrev.com/393cf62456bcd37c4dd4dd2c995597c5d5012ea6/third_party/WebKit/LayoutTests/platform/linux/css1/basic/inheritance-expected.png
[modify] https://crrev.com/393cf62456bcd37c4dd4dd2c995597c5d5012ea6/third_party/WebKit/LayoutTests/platform/linux/css1/box_properties/acid_test-expected.png
[modify] https://crrev.com/393cf62456bcd37c4dd4dd2c995597c5d5012ea6/third_party/WebKit/LayoutTests/platform/linux/css1/box_properties/border-expected.png
[modify] https://crrev.com/393cf62456bcd37c4dd4dd2c995597c5d5012ea6/third_party/WebKit/LayoutTests/platfor
Project Member

Comment 8 by bugdroid1@chromium.org, Mar 12 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/81312634f326ffe7fa8c4736e67074d07fa83120

commit 81312634f326ffe7fa8c4736e67074d07fa83120
Author: fmalita <fmalita@chromium.org>
Date: Sun Mar 12 19:22:01 2017

Cleanup after SK_SUPPORT_LEGACY_BROKEN_LERP removal

Re-rebaseline some flakes picked up in
http://crrev.com/393cf62456bcd37c4dd4dd2c995597c5d5012ea6.

BUG= 696216 
TBR=
NOTRY=true

Review-Url: https://codereview.chromium.org/2746753002
Cr-Commit-Position: refs/heads/master@{#456304}

[modify] https://crrev.com/81312634f326ffe7fa8c4736e67074d07fa83120/third_party/WebKit/LayoutTests/TestExpectations

Project Member

Comment 9 by bugdroid1@chromium.org, Mar 12 2017

Project Member

Comment 10 by bugdroid1@chromium.org, Mar 13 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c6c164eedf4cfe2d90096e44904eb7a440d8489d

commit c6c164eedf4cfe2d90096e44904eb7a440d8489d
Author: Rebaseline Bot <blink-rebaseline-bot@chromium.org>
Date: Mon Mar 13 09:03:28 2017

Auto-rebaseline for r456304

Build: https://build.chromium.org/p/chromium.infra.cron/builders/rebaseline-o-matic/builds/630838

https://chromium.googlesource.com/chromium/src/+/81312634f326f

BUG= 696216 
TBR=fmalita@chromium.org

Review-Url: https://codereview.chromium.org/2744203002 .
Cr-Commit-Position: refs/heads/master@{#456341}

[modify] https://crrev.com/c6c164eedf4cfe2d90096e44904eb7a440d8489d/third_party/WebKit/LayoutTests/TestExpectations
[modify] https://crrev.com/c6c164eedf4cfe2d90096e44904eb7a440d8489d/third_party/WebKit/LayoutTests/platform/android/svg/W3C-SVG-1.1-SE/coords-dom-02-f-expected.png
[modify] https://crrev.com/c6c164eedf4cfe2d90096e44904eb7a440d8489d/third_party/WebKit/LayoutTests/platform/android/svg/batik/text/textAnchor3-expected.png
[modify] https://crrev.com/c6c164eedf4cfe2d90096e44904eb7a440d8489d/third_party/WebKit/LayoutTests/platform/linux/svg/W3C-SVG-1.1/animate-elem-02-t-expected.png
[modify] https://crrev.com/c6c164eedf4cfe2d90096e44904eb7a440d8489d/third_party/WebKit/LayoutTests/platform/linux/virtual/mojo-loading/http/tests/webfont/popup-menu-load-webfont-after-open-expected.png
[delete] https://crrev.com/9ee093506e077bc10ba25be2dd0584336c5f130c/third_party/WebKit/LayoutTests/platform/mac-mac10.10/svg/W3C-SVG-1.1/fonts-elem-07-b-expected.png
[add] https://crrev.com/c6c164eedf4cfe2d90096e44904eb7a440d8489d/third_party/WebKit/LayoutTests/platform/mac-mac10.11/virtual/mojo-loading/http/tests/webfont/popup-menu-load-webfont-after-open-expected.png
[modify] https://crrev.com/c6c164eedf4cfe2d90096e44904eb7a440d8489d/third_party/WebKit/LayoutTests/platform/mac-mac10.9/fast/table/backgr_border-table-row-group-expected.png
[modify] https://crrev.com/c6c164eedf4cfe2d90096e44904eb7a440d8489d/third_party/WebKit/LayoutTests/platform/mac-mac10.9/fast/table/backgr_position-table-row-group-expected.png
[modify] https://crrev.com/c6c164eedf4cfe2d90096e44904eb7a440d8489d/third_party/WebKit/LayoutTests/platform/mac-mac10.9/fast/table/backgr_simple-table-expected.png
[delete] https://crrev.com/9ee093506e077bc10ba25be2dd0584336c5f130c/third_party/WebKit/LayoutTests/platform/mac-mac10.9/svg/W3C-SVG-1.1/fonts-elem-07-b-expected.png
[delete] https://crrev.com/9ee093506e077bc10ba25be2dd0584336c5f130c/third_party/WebKit/LayoutTests/platform/mac-mac10.9/svg/wicd/test-scalable-background-image2-expected.png
[add] https://crrev.com/c6c164eedf4cfe2d90096e44904eb7a440d8489d/third_party/WebKit/LayoutTests/platform/mac-retina/virtual/mojo-loading/http/tests/webfont/popup-menu-load-webfont-after-open-expected.png
[modify] https://crrev.com/c6c164eedf4cfe2d90096e44904eb7a440d8489d/third_party/WebKit/LayoutTests/platform/mac/fast/table/backgr_border-table-row-group-expected.png
[modify] https://crrev.com/c6c164eedf4cfe2d90096e44904eb7a440d8489d/third_party/WebKit/LayoutTests/platform/mac/fast/table/backgr_position-table-row-group-expected.png
[modify] https://crrev.com/c6c164eedf4cfe2d90096e44904eb7a440d8489d/third_party/WebKit/LayoutTests/platform/mac/fast/table/backgr_simple-table-expected.png
[add] https://crrev.com/c6c164eedf4cfe2d90096e44904eb7a440d8489d/third_party/WebKit/LayoutTests/platform/mac/virtual/mojo-loading/http/tests/webfont/popup-menu-load-webfont-after-open-expected.png
[modify] https://crrev.com/c6c164eedf4cfe2d90096e44904eb7a440d8489d/third_party/WebKit/LayoutTests/platform/win7/fast/table/backgr_border-table-row-group-expected.png

Project Member

Comment 11 by bugdroid1@chromium.org, Mar 13 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c81b87fafaf8470819b51c4b159ff16e6af6a6f3

commit c81b87fafaf8470819b51c4b159ff16e6af6a6f3
Author: Rebaseline Bot <blink-rebaseline-bot@chromium.org>
Date: Mon Mar 13 09:06:04 2017

Auto-rebaseline for r456305

Build: https://build.chromium.org/p/chromium.infra.cron/builders/rebaseline-o-matic/builds/630839

https://chromium.googlesource.com/chromium/src/+/06df7d3387118

BUG= 696216 
TBR=fmalita@chromium.org

Review-Url: https://codereview.chromium.org/2749523002 .
Cr-Commit-Position: refs/heads/master@{#456342}

[modify] https://crrev.com/c81b87fafaf8470819b51c4b159ff16e6af6a6f3/third_party/WebKit/LayoutTests/TestExpectations
[modify] https://crrev.com/c81b87fafaf8470819b51c4b159ff16e6af6a6f3/third_party/WebKit/LayoutTests/platform/mac-mac10.11/fast/forms/select/menulist-appearance-rtl-expected.png
[delete] https://crrev.com/c6c164eedf4cfe2d90096e44904eb7a440d8489d/third_party/WebKit/LayoutTests/platform/mac-mac10.11/fast/forms/select/menulist-appearance-rtl-expected.txt
[modify] https://crrev.com/c81b87fafaf8470819b51c4b159ff16e6af6a6f3/third_party/WebKit/LayoutTests/platform/mac-retina/fast/forms/select/menulist-appearance-rtl-expected.png
[delete] https://crrev.com/c6c164eedf4cfe2d90096e44904eb7a440d8489d/third_party/WebKit/LayoutTests/platform/mac-retina/fast/forms/select/menulist-appearance-rtl-expected.txt
[modify] https://crrev.com/c81b87fafaf8470819b51c4b159ff16e6af6a6f3/third_party/WebKit/LayoutTests/platform/mac/fast/forms/select/menulist-appearance-rtl-expected.png
[modify] https://crrev.com/c81b87fafaf8470819b51c4b159ff16e6af6a6f3/third_party/WebKit/LayoutTests/platform/mac/fast/forms/select/menulist-appearance-rtl-expected.txt
[modify] https://crrev.com/c81b87fafaf8470819b51c4b159ff16e6af6a6f3/third_party/WebKit/LayoutTests/platform/win/fast/forms/select/menulist-appearance-rtl-expected.png
[modify] https://crrev.com/c81b87fafaf8470819b51c4b159ff16e6af6a6f3/third_party/WebKit/LayoutTests/platform/win/fast/forms/select/menulist-appearance-rtl-expected.txt

Project Member

Comment 12 by bugdroid1@chromium.org, Mar 13 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/88df6d34a5e8b26544b5f0d0c127846b24c1f3cf

commit 88df6d34a5e8b26544b5f0d0c127846b24c1f3cf
Author: fmalita <fmalita@chromium.org>
Date: Mon Mar 13 14:00:58 2017

Clean up some layout test suppressions

Remove/delete suppressions added for the SK_SUPPORT_LEGACY_BROKEN_LERP
rebaseline.

TBR=
BUG= 696216 

Review-Url: https://codereview.chromium.org/2746123002
Cr-Commit-Position: refs/heads/master@{#456368}

[modify] https://crrev.com/88df6d34a5e8b26544b5f0d0c127846b24c1f3cf/third_party/WebKit/LayoutTests/TestExpectations

Project Member

Comment 13 by bugdroid1@chromium.org, Mar 13 2017

The following revision refers to this bug:
  https://skia.googlesource.com/skia/+/52fe583a7b21ee1cb04e95b05db9946be899b26d

commit 52fe583a7b21ee1cb04e95b05db9946be899b26d
Author: Florin Malita <fmalita@chromium.org>
Date: Mon Mar 13 15:08:29 2017

Remove SK_SUPPORT_LEGACY_BROKEN_LERP support

Chromium change landed.

BUG= chromium:696216 

CQ_INCLUDE_TRYBOTS=skia.primary:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD

Change-Id: I3e67392b0fdad8c5a3ad256e4f190123dff6c846
Reviewed-on: https://skia-review.googlesource.com/9551
Reviewed-by: Mike Reed <reed@google.com>
Reviewed-by: Mike Klein <mtklein@chromium.org>
Commit-Queue: Florin Malita <fmalita@chromium.org>

[modify] https://crrev.com/52fe583a7b21ee1cb04e95b05db9946be899b26d/src/opts/SkColor_opts_SSE2.h
[modify] https://crrev.com/52fe583a7b21ee1cb04e95b05db9946be899b26d/src/core/SkSpriteBlitter_RGB16.cpp
[modify] https://crrev.com/52fe583a7b21ee1cb04e95b05db9946be899b26d/src/opts/SkBlitRow_opts_arm_neon.cpp
[modify] https://crrev.com/52fe583a7b21ee1cb04e95b05db9946be899b26d/src/core/SkBlitter_ARGB32.cpp
[modify] https://crrev.com/52fe583a7b21ee1cb04e95b05db9946be899b26d/include/core/SkColorPriv.h

Status: Fixed (was: Assigned)
Project Member

Comment 15 by bugdroid1@chromium.org, Mar 13 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/50894a3a0a999f4eaa02b4c4e8e833f56a8721db

commit 50894a3a0a999f4eaa02b4c4e8e833f56a8721db
Author: skia-deps-roller@chromium.org <skia-deps-roller@chromium.org>
Date: Mon Mar 13 17:32:41 2017

Roll src/third_party/skia/ d69e1827b..841101d34 (7 commits)

https://skia.googlesource.com/skia.git/+log/d69e1827b90e..841101d348bb

$ git log d69e1827b..841101d34 --date=short --no-merges --format='%ad %ae %s'
2017-03-10 mtklein SkColorSpaceXformCanvas
2017-03-10 reed use AutoRestore instead of making a copy of the clipstack
2017-03-13 fmalita Remove SK_SUPPORT_LEGACY_BROKEN_LERP support
2017-03-13 bsalomon Changes to GrProcessorSet::FragmentProcessorAnalysis to prepare for deferred pipeline creation.
2017-03-13 brianosman Treat cross context images as Ganesh-created resources
2017-03-10 halcanary FuzzCanvas: rename functions, cleanup
2017-03-13 fmalita Remove run count field from SkTextBlob.

Created with:
  roll-dep src/third_party/skia
BUG= 696216 


Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls


CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
TBR=borenet@chromium.org

Change-Id: Ic0af479ba3bc8db693d99a19d235fb64272e50e6
Reviewed-on: https://chromium-review.googlesource.com/453288
Reviewed-by: Skia Deps Roller <skia-deps-roller@chromium.org>
Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#456414}
[modify] https://crrev.com/50894a3a0a999f4eaa02b4c4e8e833f56a8721db/DEPS

Sign in to add a comment