TestCompositorFrameSink should use CompositorFrameSinkSupport |
||||
Issue descriptioncc/test/test_compositor_frame_sink.cc currently uses SurfaceFactory directly. In order to improve test coverage of CompositorFrameSinkSupport as we turn on surface references and surface synchronization, and as we add new functionality to CompositorFrameSinkSupport, we should probably update TestCompositorFrameSink to use CompositorFrameSinkSupport as well.
,
Feb 28 2017
I worked on this, but now multiple tests are flaking and one consistently fails. I know one problem is that we used to return resources immediately but now in CompositorFrameSinkSupport we accumulate them, but there could be other problems as well.
,
Feb 28 2017
This is good feedback. This is precisely why we should do this task :-)
,
Mar 3 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0834fe043155e4fa29304939380d5b90a3ad3658 commit 0834fe043155e4fa29304939380d5b90a3ad3658 Author: samans <samans@chromium.org> Date: Fri Mar 03 17:03:22 2017 Fixing flakiness of TextureLayerMailboxIsActivatedDuringCommit BUG= 641613 , 696203 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel Review-Url: https://codereview.chromium.org/2729183002 Cr-Commit-Position: refs/heads/master@{#454599} [modify] https://crrev.com/0834fe043155e4fa29304939380d5b90a3ad3658/cc/layers/texture_layer_unittest.cc
,
Mar 9 2017
This CL finishes the job. I forgot to add a bug number to it. https://codereview.chromium.org/2724383002/
,
Mar 9 2017
,
Jun 13 2017
,
Feb 26 2018
|
||||
►
Sign in to add a comment |
||||
Comment 1 by samans@chromium.org
, Feb 27 2017Status: Assigned (was: Available)