Issue metadata
Sign in to add a comment
|
Page info dialog remains visible when navigating between pages |
||||||||||||||||||||||||
Issue descriptionChrome Version: 57.0.2987.54 OS: 10.12 What steps will reproduce the problem? (1) Visit apple.com (2) Type permission.site in omnibox and press Return (3) Click (i) to get site info dialog (4) Cmd-[ to go back What is the expected result? Site info dialog should hide What happens instead? Site info dialog remains visible, and continues to remain visible as you Cmd-[/] back and forth between those pages. When the dialog first becomes visible it says 0 cookies. Then when you go back to apple.com it says 38. Then if you go back to permission.site it stays a 38 (it doesn't go back to 0). At one point when it had a non-zero number I clicked the cookies link but the collected cookies dialog listed nothing.
,
Apr 27 2017
This isn't just the page info dialog, the bookmark have this issue too
,
May 8 2017
,
May 22 2017
On Windows, you can't navigate when a dialog is up. We should do the same for Mac
,
May 22 2017
How easy is that to do? In addition to Option-Cmd Left/Right Arrow you have to capture Cmd 1 & Cmd 0 (first and last tab), and any other keyboard operations that take you to a different tab in the same window.
,
May 22 2017
Trying to figure out what Windows is doing for that
,
May 24 2017
This is a duplicate: Issue 715845 Going to check with ellyjones to see how far she worked on this issue
,
May 24 2017
,
May 24 2017
,
May 26 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f582e25a561c090b75b0dc1c96f9d8136ad6991b commit f582e25a561c090b75b0dc1c96f9d8136ad6991b Author: Elly Fong-Jones <ellyjones@chromium.org> Date: Fri May 26 16:03:58 2017 views: dismiss page info bubble on page navigations & tab switches On Mac, this bubble does not consume keyboard events, so global browser hotkeys still work. In those cases, the dialog will not lose focus while navigating or switching tabs, so the page info bubble needs to listen for those changes and dismiss itself. BUG= 715845 , 696136 Change-Id: I1fdd6f5440218cb0d55c2236fa3f9b99212fd087 Reviewed-on: https://chromium-review.googlesource.com/514163 Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by: Ben Wells <benwells@chromium.org> Cr-Commit-Position: refs/heads/master@{#475019} [modify] https://crrev.com/f582e25a561c090b75b0dc1c96f9d8136ad6991b/chrome/browser/ui/views/page_info/page_info_bubble_view.cc [modify] https://crrev.com/f582e25a561c090b75b0dc1c96f9d8136ad6991b/chrome/browser/ui/views/page_info/page_info_bubble_view.h
,
May 26 2017
Unduping because this occurs without the secondary-md-ui flag.
,
May 26 2017
,
May 26 2017
I'm unable to reproduce this without the secondary-md-ui flag
,
May 26 2017
Never mind, I got it
,
May 30 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d7e0d1bdb5264108007d74c40646b17761fd41a2 commit d7e0d1bdb5264108007d74c40646b17761fd41a2 Author: spqchan <spqchan@chromium.org> Date: Tue May 30 21:13:11 2017 [Mac] Hide the page info when navigating Bug: 696136 Change-Id: I2f6e51444eeafe70b491f560f48cf47e524822dd Reviewed-on: https://chromium-review.googlesource.com/517420 Reviewed-by: Avi Drissman <avi@chromium.org> Commit-Queue: Sarah Chan <spqchan@chromium.org> Cr-Commit-Position: refs/heads/master@{#475675} [modify] https://crrev.com/d7e0d1bdb5264108007d74c40646b17761fd41a2/chrome/browser/ui/cocoa/page_info/page_info_bubble_controller.h [modify] https://crrev.com/d7e0d1bdb5264108007d74c40646b17761fd41a2/chrome/browser/ui/cocoa/page_info/page_info_bubble_controller.mm
,
May 30 2017
Looks like ellyjones@'s changes fixed the dialog for tab changes (thanks!), but not navigation for the non-secondary MD dialog. Anyway this fix should fix it. Will request a merge after this gets baked into canary
,
Jun 1 2017
,
Jun 1 2017
Your change meets the bar and is auto-approved for M60. Please go ahead and merge the CL to branch 3112 manually. Please contact milestone owner if you have questions. Owners: amineer@(Android), cmasso@(iOS), josafat@(ChromeOS), bustamante@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jun 1 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/305e599ee3cbe43839027e5284fa34403e91fafc commit 305e599ee3cbe43839027e5284fa34403e91fafc Author: spqchan <spqchan@chromium.org> Date: Thu Jun 01 17:46:09 2017 [Mac] Hide the page info when navigating Bug: 696136 Change-Id: I2f6e51444eeafe70b491f560f48cf47e524822dd Reviewed-on: https://chromium-review.googlesource.com/517420 Reviewed-by: Avi Drissman <avi@chromium.org> Commit-Queue: Sarah Chan <spqchan@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#475675} Review-Url: https://codereview.chromium.org/2921693002 . Cr-Commit-Position: refs/branch-heads/3112@{#96} Cr-Branched-From: b6460e24cf59f429d69de255538d0fc7a425ccf9-refs/heads/master@{#474897} [modify] https://crrev.com/305e599ee3cbe43839027e5284fa34403e91fafc/chrome/browser/ui/cocoa/page_info/page_info_bubble_controller.h [modify] https://crrev.com/305e599ee3cbe43839027e5284fa34403e91fafc/chrome/browser/ui/cocoa/page_info/page_info_bubble_controller.mm
,
Jun 1 2017
,
Jun 6 2017
Tested the issue on Mac OS 10.12.5 using chrome latest Dev M60-60.0.3112.20 by following steps mentioned in the original comment. Observed that site info dialog working as expected. Hence adding TE-Verified label. Please find the screenshot for reference. Thank you! |
|||||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||||
Comment 1 by shrike@chromium.org
, Apr 27 2017Summary: Page info dialog remains visible when navigating between pages (was: Site info dialog remains visible when navigating between pages)