New issue
Advanced search Search tips

Issue 696134 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: May 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome
Pri: 3
Type: Bug

Blocking:
issue 615435



Sign in to add a comment

Select All always present

Project Member Reported by amaralp@chromium.org, Feb 25 2017

Issue description

Chrome Version: M58 (previous ones too)
OS: Windows/ChromeOS/Linux

What steps will reproduce the problem?
(1) Right click in an empty textbox
(2) Notice "Select All" is available in context menu

What is the expected result?
"Select All" should be grayed out (what Firefox does)
What happens instead?
"Select All" is not grayed out and can be clicked
 
Blocking: 615435

Comment 2 by yosin@chromium.org, Mar 2 2017

Enable/Disable of "Select All" menu item should be represented by Document::queryCommandEnabled("SelectAll") defined in [1].

I observe:
 - always enabled: Mac TextEdit and Win Notepad.
 - wordpad: disabled for empty, enabled for non-empty even if all text is selected.

[1] src/third_party/WebKit/Source/core/editing/commands/EditorCommand.cpp

Comment 3 by yosin@chromium.org, Mar 2 2017

- Firefox: disabled for empty, enabled for non-empty text even if all text is selected.
Project Member

Comment 4 by bugdroid1@chromium.org, Mar 17 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c9178af4426d3a2fc543bd77e929cea2562d8d4c

commit c9178af4426d3a2fc543bd77e929cea2562d8d4c
Author: amaralp <amaralp@chromium.org>
Date: Fri Mar 17 00:09:31 2017

Select All present even all selectable text has been selected

When you right click in an empty text box "Select All" isn't grayed out. Also if you
were to use select all to select all text and then right click you "Select All"
would not be grayed out even though all text is already selected. This will also be
used in fixing Clank bug:  crbug.com/615435 

BUG= 696134 

Review-Url: https://codereview.chromium.org/2712603007
Cr-Commit-Position: refs/heads/master@{#457617}

[add] https://crrev.com/c9178af4426d3a2fc543bd77e929cea2562d8d4c/third_party/WebKit/LayoutTests/editing/selection/select_all/select_all_contenteditable.html
[add] https://crrev.com/c9178af4426d3a2fc543bd77e929cea2562d8d4c/third_party/WebKit/LayoutTests/editing/selection/select_all/select_all_input.html
[add] https://crrev.com/c9178af4426d3a2fc543bd77e929cea2562d8d4c/third_party/WebKit/LayoutTests/editing/selection/select_all/select_all_textarea.html
[modify] https://crrev.com/c9178af4426d3a2fc543bd77e929cea2562d8d4c/third_party/WebKit/Source/core/editing/commands/EditorCommand.cpp
[modify] https://crrev.com/c9178af4426d3a2fc543bd77e929cea2562d8d4c/third_party/WebKit/Source/web/ContextMenuClientImpl.cpp
[modify] https://crrev.com/c9178af4426d3a2fc543bd77e929cea2562d8d4c/third_party/WebKit/Source/web/tests/WebFrameTest.cpp

Status: Fixed (was: Started)

Sign in to add a comment