Remove special Open-WebAPK logic in AppBannerInfoBarDelegateAndroid::Create() |
|||
Issue descriptionRemove special Open-WebAPK logic in AppBannerInfoBarDelegateAndroid::Create() This logic should no longer be necessary after https://codereview.chromium.org/2707993003/ lands
,
Mar 14 2017
,
Mar 23 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5e8963652e6ed98c45ddbbe23a72db8b5b52d25b commit 5e8963652e6ed98c45ddbbe23a72db8b5b52d25b Author: zpeng <zpeng@chromium.org> Date: Thu Mar 23 14:04:32 2017 Remove unused "open WebAPK" logic in AppBannerInfoBarDelegateAndroid. https://codereview.chromium.org/2707993003/ changes the menu item of "Add to home screen" to "Open [WebAPK]" if the WebAPK is already installed, making "open WebAPK" logic in AppBannerInfoBarDelegateAndroid obselete. BUG= 696133 Review-Url: https://codereview.chromium.org/2751423002 Cr-Commit-Position: refs/heads/master@{#459070} [modify] https://crrev.com/5e8963652e6ed98c45ddbbe23a72db8b5b52d25b/chrome/browser/android/banners/app_banner_infobar_delegate_android.cc [modify] https://crrev.com/5e8963652e6ed98c45ddbbe23a72db8b5b52d25b/chrome/browser/android/banners/app_banner_infobar_delegate_android.h [modify] https://crrev.com/5e8963652e6ed98c45ddbbe23a72db8b5b52d25b/chrome/browser/android/webapk/webapk_metrics.h
,
Apr 7 2017
Anything left here or it can be closed?
,
Apr 7 2017
Closing issue |
|||
►
Sign in to add a comment |
|||
Comment 1 by pkotw...@chromium.org
, Feb 25 2017