WebAPK banner is shown for non WebAPK compatible Web Manifests |
|||
Issue descriptionRepro steps: 1) In chrome://flags, enable --bypass-app-banner-engagement-checks 2) Relaunch Chrome 3) Navigate the current tab (not a new tab) to https://userid:password@pwa.rocks Expected: The banner does not show because a WebAPK cannot be created for URLs with password and username fields Actual: The banner is shown. Tapping the "Add to homescreen" button attempts to install a WebAPK. If you open a new tab and navigate it to https://userid:password@pwa.rocks the banner is not shown
,
Feb 25 2017
This behavior occurs because the AppBannerManagerAndroid constructor is called when the Web Contents are created. When the initial web contents are created the value of ChromeWebApkHost::CanInstallWebApk() has not been computed yet
,
Mar 14 2017
This bug was fixed by fixing https://codereview.chromium.org/2730653002/ Better repro steps 1) In chrome://flags, enable --bypass-app-banner-engagement-checks 2) Relaunch Chrome 3) Navigate the current tab (not a new tab) via dev tools to https://userid:password@pwa.rocks Expected: The banner does not show because a WebAPK cannot be created for URLs with password and username fields Actual: The banner is shown. Tapping the "Add to homescreen" button attempts to install a WebAPK. If you open a new tab and navigate it to https://userid:password@pwa.rocks the banner is not shown |
|||
►
Sign in to add a comment |
|||
Comment 1 by pkotw...@chromium.org
, Feb 25 2017Labels: OS-Android
Owner: pkotw...@chromium.org
Status: Started (was: Untriaged)