New issue
Advanced search Search tips

Issue 696125 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jan 19
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 3
Type: Task



Sign in to add a comment

Remove deprecated keys for CRWNavigationItemStorage.

Project Member Reported by kkhorimoto@chromium.org, Feb 25 2017

Issue description

Currently two legacy serialization keys are supported:

kNavigationItemStorageURLDeperecatedKey
kNavigationItemStorageUseDesktopUserAgentDeprecatedKey

We should remove these after a reasonable amount of time.  I'm setting the milestone for this process to occur on M60, which is two releases after the new serialization keys are introduced.
 
Components: UI>Browser>Navigation
Labels: -Type-Bug Type-Feature
Labels: -Type-Feature Type-Task
Cc: kkhorimoto@chromium.org mrefaat@chromium.org
Owner: ----
Status: Available (was: Assigned)
Labels: Proj-Not-WKBackForwardList
Project Member

Comment 6 by sheriffbot@chromium.org, Jul 12

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: Hotlist-GoodFirstBug
Status: Available (was: Untriaged)

Comment 8 by eugene...@chromium.org, Jan 17 (6 days ago)

Cc: -eugene...@chromium.org
Owner: eugene...@chromium.org
Status: Started (was: Available)
Project Member

Comment 9 by bugdroid1@chromium.org, Jan 19 (5 days ago)

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a777a9c86ec21e73d487a90394163b2cb689e4b2

commit a777a9c86ec21e73d487a90394163b2cb689e4b2
Author: Eugene But <eugenebut@google.com>
Date: Sat Jan 19 01:05:21 2019

Remove deprecated keys for CRWNavigationItemStorage.

Bug:  696125 
Change-Id: I3e4dbfa65735ea0462f86ea8dfb69e05510a2e9c
Reviewed-on: https://chromium-review.googlesource.com/c/1416690
Auto-Submit: Eugene But <eugenebut@chromium.org>
Reviewed-by: Kurt Horimoto <kkhorimoto@chromium.org>
Commit-Queue: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#624393}
[modify] https://crrev.com/a777a9c86ec21e73d487a90394163b2cb689e4b2/ios/web/crw_navigation_item_storage.mm
[modify] https://crrev.com/a777a9c86ec21e73d487a90394163b2cb689e4b2/ios/web/navigation/crw_navigation_item_storage_unittest.mm
[modify] https://crrev.com/a777a9c86ec21e73d487a90394163b2cb689e4b2/ios/web/public/crw_navigation_item_storage.h

Comment 10 by eugene...@chromium.org, Jan 19 (4 days ago)

Status: Fixed (was: Started)

Sign in to add a comment