udev autosuspend rules: Add missing comma |
||||||||||
Issue description
The generated udev autosuspend rules for USB devices contain an error:
ATTR{idVendor}=="1d6b", ATTR{idProduct}=="0001"GOTO="autosuspend_enable"
should be
ATTR{idVendor}=="1d6b", ATTR{idProduct}=="0001", GOTO="autosuspend_enable"
I think I ate the comma when fixing a line break formatting issue in the script code :/
,
Feb 27 2017
,
Feb 28 2017
This bug requires manual review: We are only 13 days from stable. Please contact the milestone owner if you have questions. Owners: amineer@(clank), cmasso@(bling), ketakid@(cros), govind@(desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Mar 17 2017
Approving merge to M57 Chrome OS. mka@ can you please merge to M57 by eod today?
,
Mar 17 2017
Approving merge to M57 Chrome OS. please merge by eod today.
,
Mar 17 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform2/+/e4780ea00442f0a315db719f5f94b30a59075b0a commit e4780ea00442f0a315db719f5f94b30a59075b0a Author: Matthias Kaehlcke <mka@chromium.org> Date: Fri Mar 17 18:08:36 2017 power: Fix udev autosuspend rules for USB devices BUG= chromium:696124 TEST=emerge-gru power_manager scp /build/gru/lib/udev/rules.d/99-autosuspend.rules ${DUT}:/lib/udev/rules.d/ reboot DUT / restart udev plug security key ("gnubby") cat /sys/bus/usb/devices/${USBDEV}/power/control => auto plug USB mass storage device cat /sys/bus/usb/devices/${USBDEV}/power/control => on Change-Id: I3c1a6fa34688a07f3f593ed6bd957e8228fe50a8 Reviewed-on: https://chromium-review.googlesource.com/446960 Commit-Ready: Matthias Kaehlcke <mka@chromium.org> Tested-by: Matthias Kaehlcke <mka@chromium.org> Reviewed-by: Dan Erat <derat@chromium.org> Reviewed-by: Todd Broch <tbroch@chromium.org> (cherry picked from commit a61d2475dd6467fc31f39149cf0d4b71eca339e0) Reviewed-on: https://chromium-review.googlesource.com/456621 Reviewed-by: Matthias Kaehlcke <mka@chromium.org> Commit-Queue: Matthias Kaehlcke <mka@chromium.org> [modify] https://crrev.com/e4780ea00442f0a315db719f5f94b30a59075b0a/power_manager/udev/gen_autosuspend_rules.py
,
Mar 18 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform2/+/df7c936f281d39075296b6dd7730938d3cfab104 commit df7c936f281d39075296b6dd7730938d3cfab104 Author: Matthias Kaehlcke <mka@chromium.org> Date: Sat Mar 18 00:45:52 2017 power: Fix udev autosuspend rules for USB devices BUG= chromium:696124 TEST=emerge-gru power_manager scp /build/gru/lib/udev/rules.d/99-autosuspend.rules ${DUT}:/lib/udev/rules.d/ reboot DUT / restart udev plug security key ("gnubby") cat /sys/bus/usb/devices/${USBDEV}/power/control => auto plug USB mass storage device cat /sys/bus/usb/devices/${USBDEV}/power/control => on Change-Id: I3c1a6fa34688a07f3f593ed6bd957e8228fe50a8 Reviewed-on: https://chromium-review.googlesource.com/446960 Commit-Ready: Matthias Kaehlcke <mka@chromium.org> Tested-by: Matthias Kaehlcke <mka@chromium.org> Reviewed-by: Dan Erat <derat@chromium.org> Reviewed-by: Todd Broch <tbroch@chromium.org> (cherry picked from commit a61d2475dd6467fc31f39149cf0d4b71eca339e0) Reviewed-on: https://chromium-review.googlesource.com/456621 Reviewed-by: Matthias Kaehlcke <mka@chromium.org> Commit-Queue: Matthias Kaehlcke <mka@chromium.org> (cherry picked from commit e4780ea00442f0a315db719f5f94b30a59075b0a) Reviewed-on: https://chromium-review.googlesource.com/456625 Tested-by: REDDEIAH RAJU KONDURU <rkonduru@google.com> Reviewed-by: Kishan Kunduru <kkunduru@chromium.org> Reviewed-by: Hisham Yehia <hyehia@google.com> Commit-Queue: Hisham Yehia <hyehia@google.com> [modify] https://crrev.com/df7c936f281d39075296b6dd7730938d3cfab104/power_manager/udev/gen_autosuspend_rules.py
,
Mar 21 2017
This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible! If all merges have been completed, please remove any remaining Merge-Approved labels from this issue. Thanks for your time! To disable nags, add the Disable-Nags label. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Mar 21 2017
,
Aug 1 2017
,
Jan 22 2018
|
||||||||||
►
Sign in to add a comment |
||||||||||
Comment 1 by bugdroid1@chromium.org
, Feb 27 2017