New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 696109 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Apr 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 1
Type: Bug

Blocking:
issue 664704



Sign in to add a comment

ViewportDataGrid does not properly indent items if they have their parents change

Project Member Reported by allada@chromium.org, Feb 25 2017

Issue description

See title.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Mar 28 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8309530bfed7acbabd6a64adc53c5c7f2102e745

commit 8309530bfed7acbabd6a64adc53c5c7f2102e745
Author: allada <allada@chromium.org>
Date: Tue Mar 28 00:53:30 2017

[Devtools] DataGrid & ViewportDataGrid now should resetNode for children

This patch should ensure that ViewportDataGrid and DataGrid play nice
with eachother when removing and adding items to the dom. The core issue
was that _depth in DataGrid was not being cleared when handled by
ViewportDataGrid. This is not a long term solution, but is something
meant to let us get by until we can refactor DataGrid.

R=caseq,dgozman
BUG= 696109 

Review-Url: https://codereview.chromium.org/2781593003
Cr-Commit-Position: refs/heads/master@{#459959}

[add] https://crrev.com/8309530bfed7acbabd6a64adc53c5c7f2102e745/third_party/WebKit/LayoutTests/http/tests/inspector-unit/datagrid-items-attached-to-dom-expected.txt
[add] https://crrev.com/8309530bfed7acbabd6a64adc53c5c7f2102e745/third_party/WebKit/LayoutTests/http/tests/inspector-unit/datagrid-items-attached-to-dom.js
[add] https://crrev.com/8309530bfed7acbabd6a64adc53c5c7f2102e745/third_party/WebKit/LayoutTests/http/tests/inspector-unit/viewport-datagrid-items-attached-to-dom-expected.txt
[add] https://crrev.com/8309530bfed7acbabd6a64adc53c5c7f2102e745/third_party/WebKit/LayoutTests/http/tests/inspector-unit/viewport-datagrid-items-attached-to-dom.js
[add] https://crrev.com/8309530bfed7acbabd6a64adc53c5c7f2102e745/third_party/WebKit/LayoutTests/http/tests/inspector-unit/viewport-datagrid-items-expandable-attached-to-dom-expected.txt
[add] https://crrev.com/8309530bfed7acbabd6a64adc53c5c7f2102e745/third_party/WebKit/LayoutTests/http/tests/inspector-unit/viewport-datagrid-items-expandable-attached-to-dom.js
[modify] https://crrev.com/8309530bfed7acbabd6a64adc53c5c7f2102e745/third_party/WebKit/Source/devtools/front_end/data_grid/DataGrid.js
[modify] https://crrev.com/8309530bfed7acbabd6a64adc53c5c7f2102e745/third_party/WebKit/Source/devtools/front_end/data_grid/ViewportDataGrid.js

Comment 2 by allada@chromium.org, Apr 17 2017

Status: Fixed (was: Assigned)

Sign in to add a comment