New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 696091 link

Starred by 1 user

Issue metadata

Status: Archived
Owner:
Closed: May 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug



Sign in to add a comment

suite report generator should hit slave db rather than master

Project Member Reported by akes...@chromium.org, Feb 25 2017

Issue description

Related to crbug.com/695287

Evidence points to suite report generator causing undue extra load on master db, causing sporadic overload.
 
I've got a change inflight which will allow --afe to be specified to dump_suite_report to switch to a different AFE.  Is an option for TKO required?
Owner: davidri...@chromium.org
Excellent.

Afaik tko overload is not a problem so far, though hitting a readonly replica for that sounds like a prudent idea.
Cc: shuqianz@chromium.org
Will shuqianz handle the change to tko/parse or should I?  If me, what's the official name for the slave DB?
Ping on this bug.
Cc: dshi@chromium.org
So the --afe option will allow us to hit a different rpc server (right? I'm pretty sure your script is making afe rpcs, not direct db queries?)

If so I don't think that will actually help us hit a slave db.

We'd need to make the rpc server smart enough to route read-only requests to the slave db (or, allow the rpc client to pass in a hint about which backend db they want to hit).

+dshi for comment.
Where's the RPC server code?  Is it autotest/files/frontend?

Comment 8 by dshi@chromium.org, Mar 2 2017

The rpc code is in frontend/afe/rpc_interface.py

We need a new afe role with some special shadow config setting for it to point to slave db.
Are there AFE slave replicas already?

Are there consistency issues with operations that might interleave reads and writes and having those operations hit different database instances?
This change looks like it reverts functionality which previously did this.
https://chromium-review.googlesource.com/223393
Labels: -current-issue
dshi@: Can you respond to c#9?

Comment 13 by dshi@chromium.org, Mar 10 2017

No, secondary AFE role to point to secondary db server is not implemented yet. We need to create a new role for it (most likely just deploying new shadow config file).

The delay between master and slave db should be minimum, like <1min
Labels: -Pri-2 Pri-3
De-prioritizing since suite report is making use of new index.
Components: -Infra>Client>ChromeOS Infra>Client>ChromeOS>CI
Status: Archived (was: Untriaged)
Components: -Infra>Client>ChromeOS>CI Infra>Client>ChromeOS>Test

Sign in to add a comment