Omnibox Metrics: Log Eligibility for Contextual Zero Suggest |
||||||||||
Issue descriptionIt's a pain to figure out how many users don't get contextual zero suggest because their settings prevent it. We should add logging: - log on profile open or focus (not sure which, probably the former) whether the user is *ever* eligible for contextual zero suggest - log on focus whether this focus event was eligible for zero suggest. perhaps only log if the user is eligible in general? (if we only log based on the user is eligible in general, then then can see how often temporary exclusion take effect such as the user is on an https page or the user has an incognito window open)
,
Mar 3 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7e53e414ae9db0bcb229b4b63053f6748fa93681 commit 7e53e414ae9db0bcb229b4b63053f6748fa93681 Author: mpearson <mpearson@chromium.org> Date: Fri Mar 03 02:54:45 2017 Omnibox - Zero Suggest - Log When/Whether Contextual Search is Possible This will allow us to estimate the "headroom", i.e., how many people and how many focus events could we actually help with contextual suggestions. No functional changes (intended). TEST=using about:histograms BUG= 696077 Review-Url: https://codereview.chromium.org/2724303002 Cr-Commit-Position: refs/heads/master@{#454483} [modify] https://crrev.com/7e53e414ae9db0bcb229b4b63053f6748fa93681/components/omnibox/browser/zero_suggest_provider.cc [modify] https://crrev.com/7e53e414ae9db0bcb229b4b63053f6748fa93681/components/omnibox/browser/zero_suggest_provider.h [modify] https://crrev.com/7e53e414ae9db0bcb229b4b63053f6748fa93681/tools/metrics/histograms/histograms.xml
,
Mar 3 2017
,
Mar 3 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/40a050ad605fa870a7f7c5da8c3b0f78bfb4d58f commit 40a050ad605fa870a7f7c5da8c3b0f78bfb4d58f Author: alph <alph@chromium.org> Date: Fri Mar 03 07:21:25 2017 Revert "Omnibox - Zero Suggest - Log When/Whether Contextual Search is Possible" This reverts commit 7e53e414ae9db0bcb229b4b63053f6748fa93681. Broke Linux build sizes step. https://build.chromium.org/p/chromium/builders/Linux%20x64/builds/34352 BUG= 696077 NOTRY=true TBR=mpearson@chromium.org,pkasting@chromium.org,isherman@chromium.org Review-Url: https://codereview.chromium.org/2726283004 Cr-Commit-Position: refs/heads/master@{#454536} [modify] https://crrev.com/40a050ad605fa870a7f7c5da8c3b0f78bfb4d58f/components/omnibox/browser/zero_suggest_provider.cc [modify] https://crrev.com/40a050ad605fa870a7f7c5da8c3b0f78bfb4d58f/components/omnibox/browser/zero_suggest_provider.h [modify] https://crrev.com/40a050ad605fa870a7f7c5da8c3b0f78bfb4d58f/tools/metrics/histograms/histograms.xml
,
Mar 3 2017
,
Mar 3 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3d89cdcd61c6b95d514e2c9ed86e929483e0cc76 commit 3d89cdcd61c6b95d514e2c9ed86e929483e0cc76 Author: mpearson <mpearson@chromium.org> Date: Fri Mar 03 21:15:45 2017 Reland - Omnibox - Zero Suggest - Log When/Whether Contextual Search is Possible Reland https://codereview.chromium.org/2724303002 after changing one static initializer from a std::string to a const char[]. See original changelist description for more details: --- This will allow us to estimate the "headroom", i.e., how many people and how many focus events could we actually help with contextual suggestions. No functional changes (intended). TEST=using about:histograms --- TBR=pkasting TBR=isherman BUG= 696077 Review-Url: https://codereview.chromium.org/2726413002 Cr-Commit-Position: refs/heads/master@{#454676} [modify] https://crrev.com/3d89cdcd61c6b95d514e2c9ed86e929483e0cc76/components/omnibox/browser/zero_suggest_provider.cc [modify] https://crrev.com/3d89cdcd61c6b95d514e2c9ed86e929483e0cc76/components/omnibox/browser/zero_suggest_provider.h [modify] https://crrev.com/3d89cdcd61c6b95d514e2c9ed86e929483e0cc76/tools/metrics/histograms/histograms.xml
,
Mar 3 2017
Hopefully it sticks this time. :-)
,
Mar 6 2017
,
Mar 6 2017
This bug requires manual review: Reverts referenced in bugdroid comments after merge request. Please contact the milestone owner if you have questions. Owners: amineer@(clank), cmasso@(bling), bhthompson@(cros), govind@(desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Mar 6 2017
,
Mar 6 2017
,
Mar 6 2017
Before we approved merge to M58, could you please confirm change is well baked/verified in Canary, having enough automation coverage and safe to merge to M58?
,
Mar 6 2017
Confirmed: the UMA metrics we're getting back look plausible on canary. (Logging these metrics is the only effect of the change.)
,
Mar 6 2017
Approving merge to M58 branch 3029 based on comment #13. Thank you.
,
Mar 6 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2aeff9e947dad536f1f4229c8e4dde7f955f4577 commit 2aeff9e947dad536f1f4229c8e4dde7f955f4577 Author: Mark Pearson <mpearson@chromium.org> Date: Mon Mar 06 23:33:05 2017 Reland - Omnibox - Zero Suggest - Log When/Whether Contextual Search is Possible Reland https://codereview.chromium.org/2724303002 after changing one static initializer from a std::string to a const char[]. See original changelist description for more details: --- This will allow us to estimate the "headroom", i.e., how many people and how many focus events could we actually help with contextual suggestions. No functional changes (intended). TEST=using about:histograms --- TBR=pkasting TBR=isherman BUG= 696077 (cherry picked from commit 3d89cdcd61c6b95d514e2c9ed86e929483e0cc76) Review-Url: https://codereview.chromium.org/2726413002 Cr-Original-Commit-Position: refs/heads/master@{#454676} Cr-Commit-Position: refs/branch-heads/3029@{#32} Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471} [modify] https://crrev.com/2aeff9e947dad536f1f4229c8e4dde7f955f4577/components/omnibox/browser/zero_suggest_provider.cc [modify] https://crrev.com/2aeff9e947dad536f1f4229c8e4dde7f955f4577/components/omnibox/browser/zero_suggest_provider.h [modify] https://crrev.com/2aeff9e947dad536f1f4229c8e4dde7f955f4577/tools/metrics/histograms/histograms.xml
,
Mar 7 2017
|
||||||||||
►
Sign in to add a comment |
||||||||||
Comment 1 by mpear...@chromium.org
, Mar 1 2017Status: Started (was: Assigned)