New issue
Advanced search Search tips

Issue 696066 link

Starred by 1 user
Status: WontFix
Owner:
thakis@chromium.org
Closed: Feb 2017
Cc:
m...@chromium.org
h...@chromium.org
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression



Sign in to add a comment

0.6% regression in sizes at 452880:452892

Project Member Reported by m...@chromium.org, Feb 24 2017 
Suspect changes (bisecting to determine which):

5187e38 Revert of build: Enable auto raw pointer deduction check on linux. (patchset #2 id:20001 of https://codereview.chromium.org/2697873004/ ) by vmpstr · 4 hours ago

c702a81 Roll clang 289944:295762. by thakis · 4 hours ago

4075255 build: Enable auto raw pointer deduction check on linux. by vmpstr · 5 hours ago

Comment 1 by m...@chromium.org, Feb 24 2017 

All graphs for this bug:
  https://chromeperf.appspot.com/group_report?bug_id=696066

Original alerts at time of bug-filing:
  https://chromeperf.appspot.com/group_report?keys=agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDghKeM8wsM


Bot(s) for this bug's original alert(s):

linux

Comment 2 by m...@chromium.org, Feb 24 2017

Owner: thakis@chromium.org
Status: Assigned (was: Untriaged)
Actually, perf bots can't due bisects on sizes. Since vmpstr's change both landed and was reverted in the same range; I'm suspecting the clang roll could be the cause.

Regardless, the regression is pretty small. So, if we're fine with minor codegen differences; I suppose we can just WontFix this.

thakis: WDYT?

Comment 3 by thakis@chromium.org, Feb 27 2017

Cc: h...@chromium.org
Seems likely that this was the last clang roll. WontFix is probably the way to go, but +hans who's been tracking binary size.

Comment 4 by h...@chromium.org, Feb 28 2017

Status: WontFix (was: Assigned)
I had a look but couldn't see anything in my graph.

Since the diff is so small, and the range of commits is so large, I don't think this is worth investigating more.

Comment 5 by benhenry@chromium.org, Mar 11 2017

Labels: Binary-Size

Comment 6 by benhenry@chromium.org, May 9 2017

Labels: -binary-size Performance-Size
►

Sign in to add a comment