New issue
Advanced search Search tips

Issue 696058 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Apr 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Sticky position elements which do not move should not be promoted.

Project Member Reported by flackr@chromium.org, Feb 24 2017

Issue description

What steps will reproduce the problem?
(1) Visit a page with a sticky position element having no defined top, bottom, left or right.

What is the expected result?
It should be treated exactly as a relative position element.

What happens instead?
It is promoted into a layer because of its sticky position even though it will never move. If an ancestor scroller is promoted, we will also promote sticky elements in scrollers that don't scroll.

Please use labels and text to provide additional information.


For graphics-related bugs, please copy/paste the contents of the about:gpu
page at the end of this report.

 
Project Member

Comment 1 by bugdroid1@chromium.org, Apr 3 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b445984eba859a4e3febed02d619776e4afd3dff

commit b445984eba859a4e3febed02d619776e4afd3dff
Author: flackr <flackr@chromium.org>
Date: Mon Apr 03 17:00:57 2017

Only automatically promote sticky position elements which move with scroll.

BUG= 696058 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2776563003
Cr-Commit-Position: refs/heads/master@{#461457}

[modify] https://crrev.com/b445984eba859a4e3febed02d619776e4afd3dff/third_party/WebKit/Source/core/frame/FrameView.cpp
[modify] https://crrev.com/b445984eba859a4e3febed02d619776e4afd3dff/third_party/WebKit/Source/core/layout/LayoutBox.cpp
[modify] https://crrev.com/b445984eba859a4e3febed02d619776e4afd3dff/third_party/WebKit/Source/core/layout/compositing/CompositedLayerMappingTest.cpp
[modify] https://crrev.com/b445984eba859a4e3febed02d619776e4afd3dff/third_party/WebKit/Source/core/layout/compositing/CompositingReasonFinder.cpp
[modify] https://crrev.com/b445984eba859a4e3febed02d619776e4afd3dff/third_party/WebKit/Source/core/layout/compositing/CompositingReasonFinder.h
[modify] https://crrev.com/b445984eba859a4e3febed02d619776e4afd3dff/third_party/WebKit/Source/core/layout/compositing/CompositingReasonFinderTest.cpp
[modify] https://crrev.com/b445984eba859a4e3febed02d619776e4afd3dff/third_party/WebKit/Source/core/layout/compositing/CompositingRequirementsUpdater.cpp
[modify] https://crrev.com/b445984eba859a4e3febed02d619776e4afd3dff/third_party/WebKit/Source/core/paint/PaintLayer.cpp
[modify] https://crrev.com/b445984eba859a4e3febed02d619776e4afd3dff/third_party/WebKit/Source/core/paint/PaintLayer.h
[modify] https://crrev.com/b445984eba859a4e3febed02d619776e4afd3dff/third_party/WebKit/Source/core/paint/PaintLayerTest.cpp

Status: Fixed (was: Started)

Sign in to add a comment