New issue
Advanced search Search tips

Issue 696053 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner: ----
Closed: Apr 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Please make trybot failure emails link to the right logs

Project Member Reported by cbiesin...@chromium.org, Feb 24 2017

Issue description

When trybot fails, we get emails like this:
"""
Try jobs failed on following builders:
chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/372823)
"""

But now that logdog is on, that link is not so useful. Can we make it point to logdog instead?
 

Comment 1 by d...@chromium.org, Feb 24 2017

Yeah this is important. I'll probably not get around to it this week, but I'll look into it next week. Thanks for bringing it up.
Components: -Infra>Platform>LogDog Infra>Platform>Milo
Labels: Pri-2
Status: Available (was: Untriaged)
It should probably link to milo instead of logdog, moving components. Definitely agree we should do this.
Labels: -Pri-2 Pri-1
Since I'd like to flip all of the chromium builders over this week, let's fix this ASAP.
Cc: d...@chromium.org no...@chromium.org hinoka@chromium.org
dnj / hinoka / nodir - can one of you look into this?
The link above is still correct, it just happens to be 2 weeks old and past the buildbot archive limitation.  dnj@ made a change to point all buildbot build logs to logdog instead, so this shouldn't be as big of an issue.

But I can look into getting the links swapped.
Er, right :).

Comment 7 by hinoka@chromium.org, Mar 15 2017

Okay, it looks like the CQ gets the URL from buildbucket, which gets it from buildbot when it calls start() the build.

There are a couple things we can do
1. Build a buildbot url -> milo url converter in the CQ or buildbucket
2. Have buildbot emit milo urls

Anyone have an opinion on how to do this?  I'm inclined to make this a buildbucket change, because:
1. It'll propagate to the other places served by buildbucket 
2. No master restarts required to pick this up

Anyone have an opinion on this?

Comment 8 by no...@chromium.org, Mar 16 2017

Labels: Type-Bug-Regression
i am reluctant to introduce hacks in a presumably clean code, so I'd make a change in buildbot-buildbucket integration https://cs.chromium.org/chromium/build/scripts/master/buildbucket/integration.py?q=buildbucket/in+package:%5Echromium$&l=613

yes, it will require master restarts, but not many masters are affected either

Comment 9 by no...@chromium.org, Mar 20 2017

Components: Infra>Platform>Milo>Buildbot

Comment 10 by no...@chromium.org, Mar 20 2017

Components: -Infra>Platform>Milo
Project Member

Comment 11 by sheriffbot@chromium.org, Apr 6 2018

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Status: Fixed (was: Untriaged)
I assume this has since been fixed. Please reopen if not and I'll find someone to help.

Sign in to add a comment