New issue
Advanced search Search tips

Issue 696043 link

Starred by 1 user
Status: Assigned
Owner:
forshaw@chromium.org
Cc:
wfh@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 3
Type: Feature



Sign in to add a comment

Sandbox: Improve handling of DLL hooks to handle non-fatal errors

Project Member Reported by forshaw@chromium.org, Feb 24 2017 
On Windows 10.10240 there was a case of the hooks for DRM (specifically GetCertificateByHandle and GetCertificateSizeByHandle) failing because these APIs were only introduced in TH2. This caused the patching to fail which only exhibited itself in Debug builds testing Flash. In this case neither of these APIs were needed to complete the operation of the hooks so should have at least failed silently or been easier to detect.

We should look improving the handling of these hooks to better handle this sort of situation.
Project Member

Comment 1 by bugdroid1@chromium.org, Feb 24 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/692a736b8eb29f607f29cfdfacb77aa9d3fa4109

commit 692a736b8eb29f607f29cfdfacb77aa9d3fa4109
Author: brucedawson <brucedawson@chromium.org>
Date: Fri Feb 24 23:34:12 2017

Adjust version checks for GetCertificate* patching

The functions GetCertificateByHandle and GetCertificateSizeByHandle need
patching but only when they exist. An incorrect version check meant that
Chrome tried to patch then on Windows 10.0.10240 which would then fail
on debug builds.

BUG=696043
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win10_chromium_x64_rel_ng

Review-Url: https://codereview.chromium.org/2720443002
Cr-Commit-Position: refs/heads/master@{#452995}

[modify] https://crrev.com/692a736b8eb29f607f29cfdfacb77aa9d3fa4109/sandbox/win/src/process_mitigations_win32k_dispatcher.cc
►

Sign in to add a comment