[WebPayments] Refactor interactive_ui_tests to browser_tests using EventGenerator |
||||
Issue descriptionQuoting tapted@'s advice: Also it's probably worth investigating not using an interactive_ui_test at all -- they're pretty notorious for flakes, and can't be parallelised on the bots. Unless you specifically need to test native event dispatch (e.g. to the macOS MainMenu like I had to in that CL), or things to do with actually focusing new windows, you can get a much more robust test using ui::test::EventGenerator. We should do this for the interactive_ui_tests for PaymentRequest, since none of them should have the native event demands that Trent discussed. This also seems like the clearest path towards resolving some of the more confusing Mac test failures we've seen.
,
Feb 24 2017
,
Mar 6 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/87a17804ec5928ea8f3def2e7ddc7d262f5007c4 commit 87a17804ec5928ea8f3def2e7ddc7d262f5007c4 Author: mathp <mathp@chromium.org> Date: Mon Mar 06 16:53:02 2017 [Payments] Convert interactive tests to browsertests * Enables the tests on Mac * Now in the browser_tests target * No longer uses interactive test utils (not linked in browser_tests) BUG= 696029 TEST=browser_tests Review-Url: https://codereview.chromium.org/2734693002 Cr-Commit-Position: refs/heads/master@{#454877} [rename] https://crrev.com/87a17804ec5928ea8f3def2e7ddc7d262f5007c4/chrome/browser/ui/views/payments/credit_card_editor_view_controller_browsertest.cc [rename] https://crrev.com/87a17804ec5928ea8f3def2e7ddc7d262f5007c4/chrome/browser/ui/views/payments/payment_method_view_controller_browsertest.cc [rename] https://crrev.com/87a17804ec5928ea8f3def2e7ddc7d262f5007c4/chrome/browser/ui/views/payments/payment_request_browsertest.cc [rename] https://crrev.com/87a17804ec5928ea8f3def2e7ddc7d262f5007c4/chrome/browser/ui/views/payments/payment_request_browsertest_base.cc [rename] https://crrev.com/87a17804ec5928ea8f3def2e7ddc7d262f5007c4/chrome/browser/ui/views/payments/payment_request_browsertest_base.h [rename] https://crrev.com/87a17804ec5928ea8f3def2e7ddc7d262f5007c4/chrome/browser/ui/views/payments/payment_sheet_view_controller_browsertest.cc [modify] https://crrev.com/87a17804ec5928ea8f3def2e7ddc7d262f5007c4/chrome/browser/ui/views/payments/view_stack.h [modify] https://crrev.com/87a17804ec5928ea8f3def2e7ddc7d262f5007c4/chrome/test/BUILD.gn [modify] https://crrev.com/87a17804ec5928ea8f3def2e7ddc7d262f5007c4/components/payments/content/payment_request_web_contents_manager.h
,
Mar 6 2017
,
Jun 27 2017
|
||||
►
Sign in to add a comment |
||||
Comment 1 by tmartino@chromium.org
, Feb 24 2017