New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 696017 link

Starred by 2 users
Status: Fixed
Owner:
█ twif...@chromium.org
Last visit > 30 days ago
Closed: Feb 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android
Pri: 3
Type: Bug



Sign in to add a comment

Fix top_resources_count + experiments.

Project Member Reported by twif...@chromium.org, Feb 24 2017 
top_resources_count includes resources that were excluded due to the
PrecacheResourceSelection that was chosen for to the field trial group.
Changes it so only selected resources get counted against that cap.
Project Member

Comment 1 by bugdroid1@chromium.org, Feb 25 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3fffa417af5b70accf1fe290b60de87c419be5df

commit 3fffa417af5b70accf1fe290b60de87c419be5df
Author: twifkak <twifkak@chromium.org>
Date: Sat Feb 25 02:40:21 2017

precache: Fix top_resources_count + experiments.

top_resources_count includes resources that were excluded due to the
PrecacheResourceSelection that was chosen for to the field trial group.
This changes it so only selected resources get counted against that cap.

Note that total_resources_count does not have this problem, so nothing
needs to be fixed there.

BUG= 696017 

Review-Url: https://codereview.chromium.org/2707053005
Cr-Commit-Position: refs/heads/master@{#453051}

[modify] https://crrev.com/3fffa417af5b70accf1fe290b60de87c419be5df/components/precache/core/precache_fetcher.cc
[modify] https://crrev.com/3fffa417af5b70accf1fe290b60de87c419be5df/components/precache/core/precache_fetcher_unittest.cc

Comment 2 by twif...@chromium.org, Feb 25 2017

Status: Fixed (was: Started)
►

Sign in to add a comment