New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 696012 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Feb 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android
Pri: 3
Type: Feature



Sign in to add a comment

Allow experiment bitsets of any size.

Project Member Reported by twif...@chromium.org, Feb 24 2017

Issue description

Add bytes-typed field to PrecacheResourceSelection, which allows for an arbitrarily-sized bit vector, and thus doesn't limit the number of resources per site to 64.
 

Comment 1 Deleted

Status: Fixed (was: Started)
This was submitted as https://codereview.chromium.org/2710673004/.
The content of the strangely deleted comment:

Comment #1 on  issue 696012  by bugdroid1@chromium.org: Allow experiment bitsets of any size.
https://bugs.chromium.org/p/chromium/issues/detail?id=696012#c1

The following revision refers to this bug:
https://chromium.googlesource.com/chromium/src.git/+/b5a09c31d9b7af63c2b82194200bbb3ed9c5a878

commit b5a09c31d9b7af63c2b82194200bbb3ed9c5a878
Author: twifkak <twifkak@chromium.org>
Date: Fri Feb 24 21:18:18 2017

precache: Allow experiment bitsets of any size.

Add bytes-typed field to PrecacheResourceSelection, which allows for an
arbitrarily-sized bit vector, and thus doesn't limit the number of
resources per site to 64.

BUG= 696012 

Review-Url: https://codereview.chromium.org/2710673004
Cr-Commit-Position: refs/heads/master@{#452921}

[modify] https://crrev.com/b5a09c31d9b7af63c2b82194200bbb3ed9c5a878/components/precache/core/precache_fetcher.cc
[modify] https://crrev.com/b5a09c31d9b7af63c2b82194200bbb3ed9c5a878/components/precache/core/precache_fetcher_unittest.cc
[modify] https://crrev.com/b5a09c31d9b7af63c2b82194200bbb3ed9c5a878/components/precache/core/proto/precache.proto

Sign in to add a comment