New issue
Advanced search Search tips

Issue 696009 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Apr 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

[Mac RTL] Header of security bubble isn't aligned correctly

Project Member Reported by a...@chromium.org, Feb 24 2017

Issue description

as in pictures
 
Screen Shot 2017-02-24 at 4.03.20 PM.png
77.3 KB View Download
Screen Shot 2017-02-24 at 4.03.27 PM.png
80.5 KB View Download

Comment 1 by a...@chromium.org, Feb 24 2017

Interestingly enough, the RTL layout correctness for the rest of the bubble isn't guarded by the "experimental RTL" flag, but straight up "is this an RTL language" flag.

Comment 2 by lgrey@chromium.org, Feb 24 2017

I think that flag was introduced in August/September-ish (some time shortly before I joined the team), so basically anything that made an effort at RTL before the current push wouldn't take it into account.

Comment 3 by a...@chromium.org, Feb 24 2017

Cc: lgrey@chromium.org
Owner: a...@chromium.org
Status: Started (was: Untriaged)
Project Member

Comment 4 by bugdroid1@chromium.org, Apr 28 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ae182230f56e92bc952ba62c8d6800e56f206008

commit ae182230f56e92bc952ba62c8d6800e56f206008
Author: avi <avi@chromium.org>
Date: Fri Apr 28 22:34:37 2017

[Mac RTL] Fix the RTLness of the website settings bubble header.

BUG= 696009 

Review-Url: https://codereview.chromium.org/2714193004
Cr-Commit-Position: refs/heads/master@{#468159}

[modify] https://crrev.com/ae182230f56e92bc952ba62c8d6800e56f206008/chrome/browser/ui/cocoa/page_info/page_info_bubble_controller.mm

Comment 5 by a...@chromium.org, Apr 28 2017

Status: Fixed (was: Started)

Sign in to add a comment