Nocompile tests broken after clang roll |
||
Issue description
FAILED: obj/base/base_nocompile_tests/bind_unittest_nc.o
/b/c/goma_client/gomacc ../../third_party/llvm-build/Release+Asserts/bin/clang++ -MMD -MF obj/base/base_nocompile_tests/bind_unittest_nc.o.d -DV8_DEPRECATION_WARNINGS -DUSE_UDEV -DUI_COMPOSITOR_IMAGE_TRANSPORT -DUSE_AURA=1 -DUSE_PANGO=1 -DUSE_CAIRO=1 -DUSE_GLIB=1 -DUSE_NSS_CERTS=1 -DUSE_X11=1 -DFULL_SAFE_BROWSING -DSAFE_BROWSING_CSD -DSAFE_BROWSING_DB_LOCAL -DCHROMIUM_BUILD -DENABLE_MEDIA_ROUTER=1 -DFIELDTRIAL_TESTING_ENABLED -DCR_CLANG_REVISION=\"295793-1\" -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -DNDEBUG -DNVALGRIND -DDYNAMIC_ANNOTATIONS_ENABLED=0 -DGLIB_VERSION_MAX_ALLOWED=GLIB_VERSION_2_32 -DGLIB_VERSION_MIN_REQUIRED=GLIB_VERSION_2_26 -DGTEST_HAS_POSIX_RE=0 -DGTEST_LANG_CXX11=1 -DUNIT_TEST -I../.. -Igen -I../../build/linux/debian_wheezy_amd64-sysroot/usr/include/glib-2.0 -I../../build/linux/debian_wheezy_amd64-sysroot/usr/lib/x86_64-linux-gnu/glib-2.0/include -I../../testing/gtest/include -fno-strict-aliasing --param=ssp-buffer-size=4 -fstack-protector -Wno-builtin-macro-redefined -D__DATE__= -D__TIME__= -D__TIMESTAMP__= -funwind-tables -fPIC -pipe -B../../third_party/binutils/Linux_x64/Release/bin -fcolor-diagnostics -m64 -march=x86-64 -pthread -Wall -Werror -Wextra -Wno-missing-field-initializers -Wno-unused-parameter -Wno-c++11-narrowing -Wno-covered-switch-default -Wno-deprecated-register -Wno-unneeded-internal-declaration -Wno-inconsistent-missing-override -Wno-shift-negative-value -Wno-undefined-var-template -Wno-nonportable-include-path -Wno-address-of-packed-member -Wno-block-capture-autoreleasing -Wno-unused-lambda-capture -Wno-user-defined-warnings -O2 -fno-ident -fdata-sections -ffunction-sections -g0 --sysroot=../../build/linux/debian_wheezy_amd64-sysroot -fvisibility=hidden -Xclang -load -Xclang ../../third_party/llvm-build/Release+Asserts/lib/libFindBadConstructs.so -Xclang -add-plugin -Xclang find-bad-constructs -Xclang -plugin-arg-find-bad-constructs -Xclang check-ipc -Wheader-hygiene -Wstring-conversion -Wtautological-overlap-compare -fvisibility-inlines-hidden -std=gnu++11 -fno-rtti -fno-exceptions -c gen/base/bind_unittest_nc.cc -o obj/base/base_nocompile_tests/bind_unittest_nc.o
gen/base/bind_unittest_nc.cc:24:2: error: "NCTEST_DISALLOW_CAPTURING_LAMBDA Failed: Expectations [r'fatal error: implicit instantiation of undefined template 'base::internal::FunctorTraits<\(lambda at (\.\./)+base/bind_unittest.nc:[0-9]+:[0-9]+\), void>''] did not match output."
#error "NCTEST_DISALLOW_CAPTURING_LAMBDA Failed: Expectations [r'fatal error: implicit instantiation of undefined template 'base::internal::FunctorTraits<\(lambda at (\.\./)+base/bind_unittest.nc:[0-9]+:[0-9]+\), void>''] did not match output."
^
gen/base/bind_unittest_nc.cc:25:2: error: "compile line: /b/c/b/linux_clobber/src/tools/../third_party/llvm-build/Release+Asserts/bin/clang++ -Wall -Werror -Wfatal-errors -I../../ --sysroot ../../build/linux/debian_wheezy_amd64-sysroot -DNCTEST_DISALLOW_CAPTURING_LAMBDA -std=c++11 -o /dev/null -c -x c++ ../../base/bind_unittest.nc"
#error "compile line: /b/c/b/linux_clobber/src/tools/../third_party/llvm-build/Release+Asserts/bin/clang++ -Wall -Werror -Wfatal-errors -I../../ --sysroot ../../build/linux/debian_wheezy_amd64-sysroot -DNCTEST_DISALLOW_CAPTURING_LAMBDA -std=c++11 -o /dev/null -c -x c++ ../../base/bind_unittest.nc"
^
gen/base/bind_unittest_nc.cc:26:2: error: "NCTEST_DISALLOW_CAPTURING_LAMBDA stderr:"
#error "NCTEST_DISALLOW_CAPTURING_LAMBDA stderr:"
^
gen/base/bind_unittest_nc.cc:27:2: error: " ../../base/bind_unittest.nc:210:9: fatal error: lambda capture 'i' is not used [-Wunused-lambda-capture]"
#error " ../../base/bind_unittest.nc:210:9: fatal error: lambda capture 'i' is not used [-Wunused-lambda-capture]"
^
gen/base/bind_unittest_nc.cc:28:2: error: " Bind([i]() {});"
#error " Bind([i]() {});"
^
gen/base/bind_unittest_nc.cc:29:2: error: " ^"
#error " ^"
^
gen/base/bind_unittest_nc.cc:30:2: error: " 1 error generated."
#error " 1 error generated."
^
gen/base/b
https://build.chromium.org/p/chromium/builders/Linux%20x64/builds/33915
Started after my clang roll in that build. No try job caught this, and it probably just needs some rebasing. Disabling nocompile to get bots green for now
,
Feb 24 2017
Issue 681136 looks related. https://bugs.chromium.org/p/chromium/issues/detail?id=681136#c31 might be able to fix this.
,
Feb 24 2017
,
Feb 24 2017
Or just disabling the warning. The real bug here is that I didn't see this on either my try runs for the clang roll, or on the clang tot waterfall (https://build.chromium.org/p/chromium.fyi/console?category=clang%20tot).
,
Feb 24 2017
Not catching this in try runs is indeed more concerning. Do we reassign owner and components to reflect the changed emphasis here?
,
Feb 24 2017
Reassigning components sounds fine, but I don't know who else would own this.
,
Feb 24 2017
Two bots in CQ (linux_chromium_rel_ng and linux_chromium_compile_dbg_ng) should be red if nocompile test has failures. However, the clang roll (https://codereview.chromium.org/2708203002) didn't fail. I did see "LINK ./base_nocompile_tests" in the compile log, so it's not wrongly skipped. Still looking.
,
Feb 27 2017
Clang ToT bots not catching the regression might be due to this temporary disabling: https://codereview.chromium.org/2645593002 I think it's time to revert it since https://codereview.chromium.org/2716913002/ has landed.
,
Feb 27 2017
Why try run failed to catch the regression is still under investigation. I made one broken CL https://codereview.chromium.org/2718773002/ to test it. The following bots couldn't catch it: linux_chromium_dbg_32_ng linux_chromium_compile_dbg_32_ng linux_chromium_dbg_ng linux_chromium_compile_dbg_ng The following bots do: linux_chromium_trusty_dbg_ng linux_chromium_trusty_rel_ng linux_chromium_rel_ng linux_chromium_compile_rel_ng
,
Mar 3 2017
Hi, wychen or others with permission to change status, Please close this bug if appropriate: See https://codereview.chromium.org/2716913002/ which fixed nocompile tests. HTH. Clemmitt Sigler
,
Mar 3 2017
Why try bot didn't catch the regression is not fully resolved, so open for now.
,
Mar 14 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3e08d0dd8c897cc06417cc3528f15e3ded54d46b commit 3e08d0dd8c897cc06417cc3528f15e3ded54d46b Author: wychen <wychen@chromium.org> Date: Tue Mar 14 02:25:44 2017 Revert "Temporarily disable nocompile tests on Linux ToT bots." This reverts commit a3fd65856d4f56e3ee07f2e7db42047f87ff4eef. Revert https://codereview.chromium.org/2645593002 because nocompile tests don't trigger unused-lambda-capture warning anymore. BUG= 681136 , 695991 Review-Url: https://codereview.chromium.org/2715313002 Cr-Commit-Position: refs/heads/master@{#456582} [modify] https://crrev.com/3e08d0dd8c897cc06417cc3528f15e3ded54d46b/tools/mb/mb_config.pyl |
||
►
Sign in to add a comment |
||
Comment 1 by bugdroid1@chromium.org
, Feb 24 2017