New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 695987 link

Starred by 2 users

Issue metadata

Status: Assigned
Owner:
Last visit > 30 days ago
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 3
Type: Bug

Blocking:
issue 620813



Sign in to add a comment

Measure the impact of system instability of chrome instability.

Project Member Reported by manzagop@chromium.org, Feb 24 2017

Issue description

The clean exit beacon mechanism[1] is sensitive to system instability (crash, power failure). We'd like to distinguish the cases.

[1] https://cs.chromium.org/chromium/src/components/metrics/clean_exit_beacon.h
 
Project Member

Comment 1 by bugdroid1@chromium.org, Mar 8 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/deb62bfb3b4c7c2b78d6b6205766d9cf10ca39a0

commit deb62bfb3b4c7c2b78d6b6205766d9cf10ca39a0
Author: manzagop <manzagop@chromium.org>
Date: Wed Mar 08 17:00:01 2017

Bound the impact of system instability on chrome instability.

Add to stability reports whether the containing system session was clean. This information is derived in the following way:
- add a timestamp to the stability file when chrome starts
- when processing unclean chrome shutdowns, inspect the system event logs for the past X sessions and interpret the stability file timestamps in that context

The log inspection and analysis is in system_session_analyzer_win*, the rest is plumbing.

BUG=695987

Review-Url: https://codereview.chromium.org/2715903003
Cr-Commit-Position: refs/heads/master@{#455476}

[modify] https://crrev.com/deb62bfb3b4c7c2b78d6b6205766d9cf10ca39a0/chrome/browser/chrome_browser_field_trials_desktop.cc
[modify] https://crrev.com/deb62bfb3b4c7c2b78d6b6205766d9cf10ca39a0/components/browser_watcher/BUILD.gn
[add] https://crrev.com/deb62bfb3b4c7c2b78d6b6205766d9cf10ca39a0/components/browser_watcher/fetch_system_session_events_main_win.cc
[modify] https://crrev.com/deb62bfb3b4c7c2b78d6b6205766d9cf10ca39a0/components/browser_watcher/postmortem_report_collector.cc
[modify] https://crrev.com/deb62bfb3b4c7c2b78d6b6205766d9cf10ca39a0/components/browser_watcher/postmortem_report_collector.h
[modify] https://crrev.com/deb62bfb3b4c7c2b78d6b6205766d9cf10ca39a0/components/browser_watcher/postmortem_report_collector_unittest.cc
[modify] https://crrev.com/deb62bfb3b4c7c2b78d6b6205766d9cf10ca39a0/components/browser_watcher/stability_data_names.cc
[modify] https://crrev.com/deb62bfb3b4c7c2b78d6b6205766d9cf10ca39a0/components/browser_watcher/stability_data_names.h
[modify] https://crrev.com/deb62bfb3b4c7c2b78d6b6205766d9cf10ca39a0/components/browser_watcher/stability_report.proto
[add] https://crrev.com/deb62bfb3b4c7c2b78d6b6205766d9cf10ca39a0/components/browser_watcher/system_session_analyzer_win.cc
[add] https://crrev.com/deb62bfb3b4c7c2b78d6b6205766d9cf10ca39a0/components/browser_watcher/system_session_analyzer_win.h
[add] https://crrev.com/deb62bfb3b4c7c2b78d6b6205766d9cf10ca39a0/components/browser_watcher/system_session_analyzer_win_unittest.cc
[modify] https://crrev.com/deb62bfb3b4c7c2b78d6b6205766d9cf10ca39a0/components/browser_watcher/watcher_metrics_provider_win.cc
[modify] https://crrev.com/deb62bfb3b4c7c2b78d6b6205766d9cf10ca39a0/tools/metrics/histograms/histograms.xml

Sign in to add a comment