New issue
Advanced search Search tips

Issue 695986 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 2
Type: Feature



Sign in to add a comment

[devtools] add command for toggling FPS meter

Reported by kaycebas...@gmail.com, Feb 24 2017

Issue description

UserAgent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_12_3) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/58.0.3021.0 Safari/537.36

Steps to reproduce the problem:
1. open command menu (ctrl + shift + p)
2. type "FPS"

What is the expected behavior?
Option for toggling the FPS meter is present

What went wrong?
Not implemented

Did this work before? No 

Chrome version: 58.0.3021.0  Channel: canary
OS Version: OS X 10.12.3
Flash Version: 

source: https://twitter.com/Eramdam/status/835219774447611904

 
Labels: -Type-Bug Type-Feature
Status: Untriaged (was: Unconfirmed)
Marking it as 'Untriaged' since this is a new feature request.
Owner: l...@chromium.org
Status: Assigned (was: Untriaged)
@luoe: Please also add command menu for all items in the rendering menu. They all could be converted to reuse session settings that you are introducing.

Comment 3 by l...@chromium.org, Mar 10 2017

renderingSettings.png
66.4 KB View Download
Project Member

Comment 4 by bugdroid1@chromium.org, May 31 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b28399760d8a875871a0a156543a2f5069dcdd47

commit b28399760d8a875871a0a156543a2f5069dcdd47
Author: luoe <luoe@chromium.org>
Date: Wed May 31 00:51:49 2017

DevTools: add rendering overlay options to command menu

This CL adds existing rendering controls to show paint flashing, FPS meter,
layout borders, scroll performance bottlenecks, and CSS media type emulation
into the command menu.

BUG= 695986 

Review-Url: https://codereview.chromium.org/2839413002
Cr-Commit-Position: refs/heads/master@{#475710}

[modify] https://crrev.com/b28399760d8a875871a0a156543a2f5069dcdd47/third_party/WebKit/LayoutTests/inspector/quick-open/command-menu-expected.txt
[modify] https://crrev.com/b28399760d8a875871a0a156543a2f5069dcdd47/third_party/WebKit/Source/devtools/front_end/common/Settings.js
[modify] https://crrev.com/b28399760d8a875871a0a156543a2f5069dcdd47/third_party/WebKit/Source/devtools/front_end/main/RenderingOptions.js
[modify] https://crrev.com/b28399760d8a875871a0a156543a2f5069dcdd47/third_party/WebKit/Source/devtools/front_end/main/renderingOptions.css
[modify] https://crrev.com/b28399760d8a875871a0a156543a2f5069dcdd47/third_party/WebKit/Source/devtools/front_end/sdk/EmulationModel.js
[modify] https://crrev.com/b28399760d8a875871a0a156543a2f5069dcdd47/third_party/WebKit/Source/devtools/front_end/sdk/module.json
[modify] https://crrev.com/b28399760d8a875871a0a156543a2f5069dcdd47/third_party/WebKit/Source/devtools/front_end/settings/SettingsScreen.js
[modify] https://crrev.com/b28399760d8a875871a0a156543a2f5069dcdd47/third_party/WebKit/Source/devtools/front_end/ui/SettingsUI.js

Comment 5 by l...@chromium.org, Jun 5 2017

Status: Fixed (was: Assigned)

Comment 6 by kayce@google.com, Jun 16 2017

Labels: DevTools-Release-Notes-Feature

Comment 7 by kayce@google.com, Jul 6 2017

Labels: DevTools-Release-Notes-Feature-61

Sign in to add a comment