New issue
Advanced search Search tips
Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Feb 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment
link

Issue 695979: Fire pointer events for disabled form controls

Reported by dtapu...@chromium.org, Feb 24 2017 Project Member

Issue description

It appears we followed the broken mouse model of not firing events for disabled form controls.

We really should be firing events regardless of state.

See issue:
https://github.com/w3c/pointerevents/issues/177
 

Comment 1 by dtapu...@chromium.org, Feb 24 2017

Cc: mustaq@chromium.org nzolghadr@chromium.org
Components: Blink>Input
Labels: -Pri-3 Hotlist-Input-Dev Hotlist-Interop Pri-2
Owner: dtapu...@chromium.org
Status: Assigned (was: Untriaged)

Comment 2 by rbyers@chromium.org, Feb 24 2017

Cc: domenic@chromium.org
This looks trivial: https://cs.chromium.org/chromium/src/third_party/WebKit/Source/core/dom/Node.cpp?rcl=cb12cafde748de82eb55f491054eb2cd84fed63c&l=2075

The isMouseEvent check just needs a '&& !isPointerEvent' clause.

So I agree we should just fix this.  But can we also track investigating / fixing the mouse event case too?  It may be easy to restrict this wart to 'click' events.

Comment 3 by rbyers@chromium.org, Feb 24 2017

Cc: rbyers@chromium.org

Comment 4 by dtapu...@chromium.org, Feb 24 2017

rbyers@ the code is actually here: https://cs.chromium.org/chromium/src/third_party/WebKit/Source/core/events/PointerEvent.cpp?q=PointerEvent.cpp&l=86

And PointerEvent.h has a virtual isMouseEvent() that returns false; so that piece of code is really nothing relevant.

I put up a change here: https://codereview.chromium.org/2716063002/ just need to write a layout test for it.

Comment 5 by rbyers@chromium.org, Feb 24 2017

Ah, thanks - guess I should stop pretending I know this code anymore ;-)

Comment 6 by dtapu...@chromium.org, Feb 24 2017

hey I commented on the public bug that I didn't know where it was.. had to debug. The mouse code looks entirely confusing like people just littered isDisabledFormControl in various spots.

Comment 8 by dtapu...@chromium.org, Feb 27 2017

Status: Fixed (was: Assigned)

Comment 9 by rbyers@chromium.org, Mar 8 2017

Labels: M-58

Sign in to add a comment