MediaNotification should always show for the last active tab |
|||||||
Issue descriptionThere is an issue when there are two tabs. 1. Tab A starts playing audio, we show notification for Tab A 2. Tab B starts playing audio, we show notification for Tab B 3. Tab A lost audio focus and we update the notification for Tab A We should block 3 if the new update is from a tab that is paused and the tab id mismatches.
,
Feb 27 2017
,
Feb 27 2017
Your change meets the bar and is auto-approved for M57. Please go ahead and merge the CL to branch 2987 manually. Please contact milestone owner if you have questions. Owners: amineer@(clank), cmasso@(bling), ketakid@(cros), govind@(desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Feb 27 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5dfc4b56d28e35a36a63c77bad993850f966a3fd commit 5dfc4b56d28e35a36a63c77bad993850f966a3fd Author: Zhiqiang Zhang <zqzhang@google.com> Date: Mon Feb 27 14:54:20 2017 [Media>UI] Fix a media notification update issue when audio focus changes between tabs There's a issue which is caused by the asynchronousness of audio focus. When tab B gains focus from tab A, we will first receive the event that A becomes playing, and then B becomes paused. We should ignore the notification updates when the tab id mismatches the current notification and the tab is paused. BUG= 695967 Review-Url: https://codereview.chromium.org/2714993002 Cr-Commit-Position: refs/heads/master@{#453206} (cherry picked from commit 1ee77687069628ebd0bba3ff791a5ee6c8d17b41) Review-Url: https://codereview.chromium.org/2717293003 . Cr-Commit-Position: refs/branch-heads/2987@{#695} Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943} [modify] https://crrev.com/5dfc4b56d28e35a36a63c77bad993850f966a3fd/chrome/android/java/src/org/chromium/chrome/browser/media/ui/MediaNotificationManager.java [modify] https://crrev.com/5dfc4b56d28e35a36a63c77bad993850f966a3fd/chrome/android/javatests/src/org/chromium/chrome/browser/media/ui/NotificationTitleUpdatedTest.java
,
Feb 28 2017
,
Mar 2 2017
Hi kravula, Steps to verify: 1. Navigate to https://xxyzzzq.github.io/sandbox/media-session/full-test.html, click "play/pause". The playback should start. 2. Observe the notification. 3. Open a new tab, navigate to https://xxyzzzq.github.io/sandbox/media-session/simple-audio.html. Play the audio. The playback should start. 4. Observe the notification. Behavior before the fix: The media notification in step 4 is the same with step 2 Behavior after the fix: The media notification in step 4 should be different (showing title "Simple Audio Test page" and with a image saying "I am a FavIcon")
,
Mar 2 2017
Verified in M57-57.0.2987.88 build with above verification steps. |
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by bugdroid1@chromium.org
, Feb 27 2017