New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 695964 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: May 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Feature

Blocked on:
issue skia:6553

Blocking:
issue 634542



Sign in to add a comment

Move color managed canvas layout tests to fast/canvas

Project Member Reported by zakerinasab@chromium.org, Feb 24 2017

Issue description


When the color correct rendering is enabled by default, move the layout tests from virtual/color_space/fast/canvas/color-space to fast/canvas/color-space.

 

Comment 1 by junov@chromium.org, Feb 24 2017

This needs to happen before canvas color spaces are launched to ensure adequate test coverage on the GPU-accelerated and display list code paths.
Labels: -Type-Bug Type-Feature
Blocking: 634542
Blockedon: -634542 skia:6553
This requires GPU-backed SkImage to work for for kRespect TransferFnBehavior, which still seems to be missing. See: SkImage_Gpu::onMakeColorSpace().
Project Member

Comment 5 by bugdroid1@chromium.org, May 22 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3043a5ceb86386b72ae45d73e98b2502106d66e1

commit 3043a5ceb86386b72ae45d73e98b2502106d66e1
Author: Reza.Zakerinasab <zakerinasab@chromium.org>
Date: Tue May 22 16:47:44 2018

Move color managed canvas layout tests to fast/canvas

This CL fixes the issue with accelerated images color conversion by
converting accelerated images to software images. It also moves
color managed canvas layout tests to fast/canvas.

Bug:  695964 ,  844145 
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I115cb30260bffdc6201894089f134cbcfe24bdf6
Reviewed-on: https://chromium-review.googlesource.com/1064566
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Reviewed-by: Fernando Serboncini <fserb@chromium.org>
Commit-Queue: Mohammad Reza Zakerinasab <zakerinasab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#560652}
[modify] https://crrev.com/3043a5ceb86386b72ae45d73e98b2502106d66e1/third_party/WebKit/LayoutTests/FlagExpectations/enable-blink-gen-property-trees
[modify] https://crrev.com/3043a5ceb86386b72ae45d73e98b2502106d66e1/third_party/WebKit/LayoutTests/FlagExpectations/enable-slimming-paint-v2
[modify] https://crrev.com/3043a5ceb86386b72ae45d73e98b2502106d66e1/third_party/WebKit/LayoutTests/SlowTests
[modify] https://crrev.com/3043a5ceb86386b72ae45d73e98b2502106d66e1/third_party/WebKit/LayoutTests/SmokeTests
[modify] https://crrev.com/3043a5ceb86386b72ae45d73e98b2502106d66e1/third_party/WebKit/LayoutTests/VirtualTestSuites
[rename] https://crrev.com/3043a5ceb86386b72ae45d73e98b2502106d66e1/third_party/WebKit/LayoutTests/fast/canvas/color-space/canvas-colorManaged-toBlob-toDataURL.html
[rename] https://crrev.com/3043a5ceb86386b72ae45d73e98b2502106d66e1/third_party/WebKit/LayoutTests/fast/canvas/color-space/canvas-colorspace-arguments.html
[rename] https://crrev.com/3043a5ceb86386b72ae45d73e98b2502106d66e1/third_party/WebKit/LayoutTests/fast/canvas/color-space/canvas-createImageBitmap-linear-rgb.html
[rename] https://crrev.com/3043a5ceb86386b72ae45d73e98b2502106d66e1/third_party/WebKit/LayoutTests/fast/canvas/color-space/canvas-createImageBitmap-p3.html
[rename] https://crrev.com/3043a5ceb86386b72ae45d73e98b2502106d66e1/third_party/WebKit/LayoutTests/fast/canvas/color-space/canvas-createImageBitmap-rec2020.html
[rename] https://crrev.com/3043a5ceb86386b72ae45d73e98b2502106d66e1/third_party/WebKit/LayoutTests/fast/canvas/color-space/canvas-createPutGetImageData-colorManaged.html
[rename] https://crrev.com/3043a5ceb86386b72ae45d73e98b2502106d66e1/third_party/WebKit/LayoutTests/fast/canvas/color-space/canvas-drawImage-linear-rgb.html
[rename] https://crrev.com/3043a5ceb86386b72ae45d73e98b2502106d66e1/third_party/WebKit/LayoutTests/fast/canvas/color-space/canvas-drawImage-p3.html
[rename] https://crrev.com/3043a5ceb86386b72ae45d73e98b2502106d66e1/third_party/WebKit/LayoutTests/fast/canvas/color-space/canvas-drawImage-rec2020.html
[rename] https://crrev.com/3043a5ceb86386b72ae45d73e98b2502106d66e1/third_party/WebKit/LayoutTests/fast/canvas/color-space/canvas-getImageData-linear-rgb.html
[rename] https://crrev.com/3043a5ceb86386b72ae45d73e98b2502106d66e1/third_party/WebKit/LayoutTests/fast/canvas/color-space/canvas-getImageData-p3.html
[rename] https://crrev.com/3043a5ceb86386b72ae45d73e98b2502106d66e1/third_party/WebKit/LayoutTests/fast/canvas/color-space/canvas-getImageData-rec2020.html
[rename] https://crrev.com/3043a5ceb86386b72ae45d73e98b2502106d66e1/third_party/WebKit/LayoutTests/fast/canvas/color-space/imageData-colorManagedBehavior.html
[rename] https://crrev.com/3043a5ceb86386b72ae45d73e98b2502106d66e1/third_party/WebKit/LayoutTests/fast/canvas/color-space/imageData-colorSpace.html
[rename] https://crrev.com/3043a5ceb86386b72ae45d73e98b2502106d66e1/third_party/WebKit/LayoutTests/fast/canvas/color-space/imagedata-no-color-settings-crash.html
[rename] https://crrev.com/3043a5ceb86386b72ae45d73e98b2502106d66e1/third_party/WebKit/LayoutTests/fast/canvas/color-space/resources/pattern-semitransparent-p3d65.png
[rename] https://crrev.com/3043a5ceb86386b72ae45d73e98b2502106d66e1/third_party/WebKit/LayoutTests/fast/canvas/color-space/resources/pattern-semitransparent-rec2020.png
[rename] https://crrev.com/3043a5ceb86386b72ae45d73e98b2502106d66e1/third_party/WebKit/LayoutTests/fast/canvas/color-space/resources/pattern-semitransparent-srgb.png
[rename] https://crrev.com/3043a5ceb86386b72ae45d73e98b2502106d66e1/third_party/WebKit/LayoutTests/fast/canvas/color-space/resources/pattern-srgb-fullcolor.ogv
[rename] https://crrev.com/3043a5ceb86386b72ae45d73e98b2502106d66e1/third_party/WebKit/LayoutTests/fast/canvas/color-space/resources/pattern-srgb-transparent.bmp
[rename] https://crrev.com/3043a5ceb86386b72ae45d73e98b2502106d66e1/third_party/WebKit/LayoutTests/fast/canvas/color-space/resources/pattern-srgb-transparent.ico
[rename] https://crrev.com/3043a5ceb86386b72ae45d73e98b2502106d66e1/third_party/WebKit/LayoutTests/fast/canvas/color-space/resources/pattern-srgb-transparent.png
[rename] https://crrev.com/3043a5ceb86386b72ae45d73e98b2502106d66e1/third_party/WebKit/LayoutTests/fast/canvas/color-space/resources/pattern-srgb-transparent.webp
[rename] https://crrev.com/3043a5ceb86386b72ae45d73e98b2502106d66e1/third_party/WebKit/LayoutTests/fast/canvas/color-space/resources/pattern-srgb.bmp
[rename] https://crrev.com/3043a5ceb86386b72ae45d73e98b2502106d66e1/third_party/WebKit/LayoutTests/fast/canvas/color-space/resources/pattern-srgb.gif
[rename] https://crrev.com/3043a5ceb86386b72ae45d73e98b2502106d66e1/third_party/WebKit/LayoutTests/fast/canvas/color-space/resources/pattern-srgb.ico
[rename] https://crrev.com/3043a5ceb86386b72ae45d73e98b2502106d66e1/third_party/WebKit/LayoutTests/fast/canvas/color-space/resources/pattern-srgb.jpg
[rename] https://crrev.com/3043a5ceb86386b72ae45d73e98b2502106d66e1/third_party/WebKit/LayoutTests/fast/canvas/color-space/resources/pattern-srgb.png
[rename] https://crrev.com/3043a5ceb86386b72ae45d73e98b2502106d66e1/third_party/WebKit/LayoutTests/fast/canvas/color-space/resources/pattern-srgb.svg
[rename] https://crrev.com/3043a5ceb86386b72ae45d73e98b2502106d66e1/third_party/WebKit/LayoutTests/fast/canvas/color-space/resources/pattern-srgb.webp
[rename] https://crrev.com/3043a5ceb86386b72ae45d73e98b2502106d66e1/third_party/WebKit/LayoutTests/fast/canvas/color-space/transferFromImageBitmap.html
[delete] https://crrev.com/52a43db150731a4c6d445ba8bde976c268e99033/third_party/WebKit/LayoutTests/virtual/color_space/fast/canvas/color-space/README.txt
[modify] https://crrev.com/3043a5ceb86386b72ae45d73e98b2502106d66e1/third_party/blink/renderer/platform/graphics/static_bitmap_image.cc

Status: Fixed (was: Assigned)

Sign in to add a comment