Linux Chrome 58 un-minimize animation is dizzying
Reported by
ivan@ludios.org,
Feb 24 2017
|
||||||||
Issue descriptionUserAgent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/56.0.2924.87 Safari/537.36 Steps to reproduce the problem: 1. Install google-chrome-unstable on xubuntu 2. Run google-chrome-unstable 3. Click on taskbar button for Chrome to minimize it, click again to un-minimize Chrome 4. Observe zoom + fade animation every time Chrome is un-minimized What is the expected behavior? No zoom-fade animation, as before What went wrong? Zoom-fade animation is kind of dizzying, superfluous, and doesn't resemble anything else on the xubuntu desktop, where everything else un-minimizes instantly Did this work before? N/A Chrome version: 58.0.3018.3 Channel: dev OS Version: Ubuntu 16.0.4.2 Flash Version: I'm the kind of person who digs through http://peter.sh/experiments/chromium-command-line-switches/ and finds that --wm-window-animations-disabled can disable this, but most users will not be so lucky. I don't know why this animation is here, anyway. Was this intended for Chrome OS?
,
Feb 27 2017
,
Feb 27 2017
Bisect results: You are probably looking for a change made after 448202 (known good), but no later than 448204 (first known bad). CHANGELOG URL: https://chromium.googlesource.com/chromium/src/+log/beb5158bcaf3a72957e6f14873ec439c737d5c6e..5d64ae77225a34b5e439216e5cf3ea643b9ea29b
,
Feb 27 2017
Assigning to sadrul as per #3 https://chromium.googlesource.com/chromium/src/+/5d64ae77225a34b5e439216e5cf3ea643b9ea29b
,
Apr 16 2017
Still present on 58.0.3029.68 beta (64-bit)
,
Apr 22 2017
And now we got that effect by default in Chrome 58 stable packages. It can really trigger epilepsy attack if someone had white window backgrounds (and 99% peple have).
,
Apr 24 2017
I started getting this today. It is extremely annoying. And since the documentation on command line switches is not great, you need to edit /usr/share/applications/google-chrome.desktop and insert --wm-window-animations-disabled to all Exec= lines. On my machine, here is the result (showing just the Exec lines): Exec=/usr/bin/google-chrome-stable --wm-window-animations-disabled %U Exec=/usr/bin/google-chrome-stable --wm-window-animations-disabled Exec=/usr/bin/google-chrome-stable --wm-window-animations-disabled --incognito
,
Apr 27 2017
This animation looks totally alien to the system, I though it was a graphical glitch but it didn't go off after restarting the browser. If it has to stay, then please at least add option to disable it in advanced settings. 58.0.3029.81
,
Apr 27 2017
+sky Does Chrome add animations on desktop? I thought --wm-window-animations-disabled would only affect CrOs.
,
Apr 28 2017
If this issue is not resolved within Chrome itself, should it be also reported to xubuntu and other similar projects ?
,
Apr 28 2017
It's certainly possible linux is picking up some animations. Generally we disable animations for top level windows as the desktop os does that. Code for that is here: https://chromium.googlesource.com/chromium/src/+/master/ui/views/widget/desktop_aura/desktop_native_widget_aura.cc#411
,
May 3 2017
Same issue on MATE 1.14.1 Problem: Chromium main window un-minimize is animated, overrides global desktop settings. Expected: All window animations should be controlled by the desktop ONLY. If other applications start doing the same, each with their own different animation, switching windows will become a huge mess visually. Chromium Version 58.0.3029.81 Built on Ubuntu, running on LinuxMint 18 (64-bit) Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Ubuntu
,
May 16 2017
Why isn't an equivalent of --wm-window-animations-disabled available in chrome://flags/ ? I thought this was where we could disable all experiments.
,
Jun 1 2017
I have a hard time understanding how this made it to release without nobody noticing. Thanks to #13 comment adding this option on startup fixes it until this get solved. For info we are still on 14.04 and same issue starting at 58 public release.
,
Jul 12 2017
,
Jul 12 2017
The issue is that the code that sky@ linked to which is meant to disable animations for top level windows doesn't work because params.remove_standard_frame is true (at least on Linux when not using system title bar and borders). My guess as to why this was triggered by crrev.com/2669303005 (I have manually confirmed that is was) is that before that CL, there was an extra window but its type was set to LAYER_NOT_DRAWN which somehow prevented it's child (content_window_) from being animated. Note: another workaround is to enable "Use system title bar and borders" in Settings, and then restart your browser (the restart is important).
,
Jul 13 2017
Taking over, as Sadrul isn't working on it at the moment.
,
Jul 18 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7fc2c028635ad8448348b0afe989892a9e18b37a commit 7fc2c028635ad8448348b0afe989892a9e18b37a Author: Tim Brown <timbrown@chromium.org> Date: Tue Jul 18 23:58:04 2017 Disable TYPE_WINDOW animations on X11 We were using "remove_standard_frame" to determine whether to show animations on TYPE_WINDOW. However in X11, the animations are always handled by the window manager, whether there is a custom frame or not. Bug: 695943 Change-Id: Ie5cf516feea77b18476cd73290fcfe0a30cac008 Reviewed-on: https://chromium-review.googlesource.com/570670 Reviewed-by: Scott Violet <sky@chromium.org> Reviewed-by: Thomas Anderson <thomasanderson@chromium.org> Commit-Queue: Tim Brown <timbrown@chromium.org> Cr-Commit-Position: refs/heads/master@{#487673} [modify] https://crrev.com/7fc2c028635ad8448348b0afe989892a9e18b37a/ui/views/widget/desktop_aura/desktop_native_widget_aura.cc [modify] https://crrev.com/7fc2c028635ad8448348b0afe989892a9e18b37a/ui/views/widget/desktop_aura/desktop_window_tree_host_win.cc [modify] https://crrev.com/7fc2c028635ad8448348b0afe989892a9e18b37a/ui/views/widget/desktop_aura/desktop_window_tree_host_x11.cc
,
Jul 19 2017
,
Jul 26 2017
Tested the issue on Ubuntu 14.04 using chrome latest Dev M61-61.0.3163.13 by following steps mentioned in the original comment.Please find the screen shot & cast of the issue. @timbrown: Could you please let me know if i have missed anything and please confirm us if this is the expected behaviour of the issue. Thank you!
,
Jul 26 2017
Yes, that is the expected behavior (there is no second restore animation with a white background when you restore). |
||||||||
►
Sign in to add a comment |
||||||||
Comment 1 by thomasanderson@chromium.org
, Feb 27 2017Labels: Needs-Bisect