New issue
Advanced search Search tips

Issue 695939 link

Starred by 11 users

Issue metadata

Status: Fixed
Owner:
Closed: Feb 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Task

Blocked on:
issue 736308
issue 764589

Blocking:
issue 372197
issue 611453
issue 724929
issue 665094
issue 711060



Sign in to add a comment

Support Fetch keepalive flag and enforce limit on inflight keepalive bytes

Project Member Reported by igrigo...@google.com, Feb 24 2017

Issue description

https://github.com/whatwg/fetch/pull/419

> Requests with keepalive flag set are allowed to outlive the environment
> settings object. We want to make sure that such requests do not
> negatively impact the user experience when a page is unloaded, etc.
> 
> This limits the amount of (body) bytes that can be inflight at any point
> when the request has the keepalive flag set; this flag is set by
> sendBeacon.

What is the expected result?

Chrome should support the keepalive flag & enforce the inflight byte limit.

p.s. this is also used by sendBeacon: https://github.com/w3c/beacon/pull/39
 
Owner: yhirano@chromium.org
Status: Assigned (was: Untriaged)
Here's a note about requirement discussion with some customers:
- starting without non-simple methods. Just HEAD is important now.
- cross-origin redirect is a requirement. Need cookies to be set in the response for the beacons.

HEAD is a CORS-safelisted method.
Yes. Therefore "starting without non-simple methods"
Ah, thank you.
Additional memo: The first target doesn't include a request with preflight.
Project Member

Comment 9 by bugdroid1@chromium.org, May 3 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bb924e1897f5b4c67325dbfbdf2441e7f0686d53

commit bb924e1897f5b4c67325dbfbdf2441e7f0686d53
Author: yhirano <yhirano@chromium.org>
Date: Wed May 03 18:42:19 2017

Separate preaload matching from MemoryCache

This change decouples preload matching from MemoryCache lookup. With this change,
preload matching is done for ResourceFetcher::prealods_.

This is the first step and part of the second step in the design document[1].

1: https://docs.google.com/document/d/1oq8ixPnaDxuAlKUTRQ3WoYHlJenVkzNU9xnkuZX_dWM/edit#

BUG= 695939 

Review-Url: https://codereview.chromium.org/2834733003
Cr-Commit-Position: refs/heads/master@{#469046}

[modify] https://crrev.com/bb924e1897f5b4c67325dbfbdf2441e7f0686d53/third_party/WebKit/LayoutTests/fast/dom/HTMLLinkElement/link-and-subresource-test-expected.txt
[modify] https://crrev.com/bb924e1897f5b4c67325dbfbdf2441e7f0686d53/third_party/WebKit/LayoutTests/http/tests/preload/multiple-meta-csp.html
[modify] https://crrev.com/bb924e1897f5b4c67325dbfbdf2441e7f0686d53/third_party/WebKit/LayoutTests/http/tests/resources/srcset-helper.js
[modify] https://crrev.com/bb924e1897f5b4c67325dbfbdf2441e7f0686d53/third_party/WebKit/LayoutTests/permissionclient/image-permissions-expected.txt
[modify] https://crrev.com/bb924e1897f5b4c67325dbfbdf2441e7f0686d53/third_party/WebKit/Source/core/loader/DocumentLoader.cpp
[modify] https://crrev.com/bb924e1897f5b4c67325dbfbdf2441e7f0686d53/third_party/WebKit/Source/core/loader/LinkLoaderTest.cpp
[modify] https://crrev.com/bb924e1897f5b4c67325dbfbdf2441e7f0686d53/third_party/WebKit/Source/platform/loader/BUILD.gn
[add] https://crrev.com/bb924e1897f5b4c67325dbfbdf2441e7f0686d53/third_party/WebKit/Source/platform/loader/fetch/PreloadKey.h
[modify] https://crrev.com/bb924e1897f5b4c67325dbfbdf2441e7f0686d53/third_party/WebKit/Source/platform/loader/fetch/ResourceFetcher.cpp
[modify] https://crrev.com/bb924e1897f5b4c67325dbfbdf2441e7f0686d53/third_party/WebKit/Source/platform/loader/fetch/ResourceFetcher.h
[modify] https://crrev.com/bb924e1897f5b4c67325dbfbdf2441e7f0686d53/third_party/WebKit/Source/platform/loader/fetch/ResourceFetcherTest.cpp

Project Member

Comment 10 by bugdroid1@chromium.org, May 11 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/97c0d877b1aff4ac84138c3eab71d994ead93b14

commit 97c0d877b1aff4ac84138c3eab71d994ead93b14
Author: yhirano <yhirano@chromium.org>
Date: Thu May 11 05:39:25 2017

Revert "Separate preaload matching from MemoryCache"

This CL reverts [1] due to performance regressions.

1: https://chromium.googlesource.com/chromium/src/+/bb924e1897f5b4c67325dbfbdf2441e7f0686d53

BUG= 695939 ,  719502 
TBR=japhet@chromium.org

Review-Url: https://codereview.chromium.org/2867333002
Cr-Commit-Position: refs/heads/master@{#470825}

[modify] https://crrev.com/97c0d877b1aff4ac84138c3eab71d994ead93b14/third_party/WebKit/LayoutTests/fast/dom/HTMLLinkElement/link-and-subresource-test-expected.txt
[modify] https://crrev.com/97c0d877b1aff4ac84138c3eab71d994ead93b14/third_party/WebKit/LayoutTests/http/tests/preload/multiple-meta-csp.html
[modify] https://crrev.com/97c0d877b1aff4ac84138c3eab71d994ead93b14/third_party/WebKit/LayoutTests/http/tests/resources/srcset-helper.js
[modify] https://crrev.com/97c0d877b1aff4ac84138c3eab71d994ead93b14/third_party/WebKit/LayoutTests/permissionclient/image-permissions-expected.txt
[modify] https://crrev.com/97c0d877b1aff4ac84138c3eab71d994ead93b14/third_party/WebKit/Source/core/loader/DocumentLoader.cpp
[modify] https://crrev.com/97c0d877b1aff4ac84138c3eab71d994ead93b14/third_party/WebKit/Source/core/loader/LinkLoaderTest.cpp
[modify] https://crrev.com/97c0d877b1aff4ac84138c3eab71d994ead93b14/third_party/WebKit/Source/platform/loader/BUILD.gn
[delete] https://crrev.com/053f34e3a33c62ff262483e92223971aae60de9d/third_party/WebKit/Source/platform/loader/fetch/PreloadKey.h
[modify] https://crrev.com/97c0d877b1aff4ac84138c3eab71d994ead93b14/third_party/WebKit/Source/platform/loader/fetch/ResourceFetcher.cpp
[modify] https://crrev.com/97c0d877b1aff4ac84138c3eab71d994ead93b14/third_party/WebKit/Source/platform/loader/fetch/ResourceFetcher.h
[modify] https://crrev.com/97c0d877b1aff4ac84138c3eab71d994ead93b14/third_party/WebKit/Source/platform/loader/fetch/ResourceFetcherTest.cpp

Blocking: 724929
Project Member

Comment 12 by bugdroid1@chromium.org, May 26 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7b4f4eed3448b481f69d9c8bdb2c2769130c2074

commit 7b4f4eed3448b481f69d9c8bdb2c2769130c2074
Author: Yutaka Hirano <yhirano@chromium.org>
Date: Fri May 26 12:59:54 2017

Remove BaseFetchContext::execution_context_

In order to add more flexibility to BaseFetchContext, this CL removes
BaseFetchContext::execution_context_. Instead, this CL adds some pure
virtual functions so that implementations can provide the information
possibly without any ExecutionContext.

Bug:  695939 
Change-Id: I9e19be0858337019bd4612030f5ff8c11ef75379
Reviewed-on: https://chromium-review.googlesource.com/515342
Commit-Queue: Yutaka Hirano <yhirano@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#474990}
[modify] https://crrev.com/7b4f4eed3448b481f69d9c8bdb2c2769130c2074/third_party/WebKit/Source/core/loader/BaseFetchContext.cpp
[modify] https://crrev.com/7b4f4eed3448b481f69d9c8bdb2c2769130c2074/third_party/WebKit/Source/core/loader/BaseFetchContext.h
[modify] https://crrev.com/7b4f4eed3448b481f69d9c8bdb2c2769130c2074/third_party/WebKit/Source/core/loader/BaseFetchContextTest.cpp
[modify] https://crrev.com/7b4f4eed3448b481f69d9c8bdb2c2769130c2074/third_party/WebKit/Source/core/loader/FrameFetchContext.cpp
[modify] https://crrev.com/7b4f4eed3448b481f69d9c8bdb2c2769130c2074/third_party/WebKit/Source/core/loader/FrameFetchContext.h
[modify] https://crrev.com/7b4f4eed3448b481f69d9c8bdb2c2769130c2074/third_party/WebKit/Source/core/loader/WorkerFetchContext.cpp
[modify] https://crrev.com/7b4f4eed3448b481f69d9c8bdb2c2769130c2074/third_party/WebKit/Source/core/loader/WorkerFetchContext.h

Project Member

Comment 13 by bugdroid1@chromium.org, May 29 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7d8a4d97b96a7e1f398424c840668fc17989f5d0

commit 7d8a4d97b96a7e1f398424c840668fc17989f5d0
Author: Yutaka Hirano <yhirano@chromium.org>
Date: Mon May 29 10:27:30 2017

Remove FetchContext::LoadingTaskRunner

This is a preliminary refactoring to implement keepalive fetch operations. In
order to set an appropriate task runner for a url loader, we will need the
request information.

This CL
 - Moves SetLoadingTaskRunner call to the creation timing of the WebURLLoader,
 - Removes FetchContext::LoadingTaskRunner as the task runner for a loader
   can depend on the request, and
 - Provides a request parameter to FetchContext::CreateURLLoader.

Bug:  695939 
Change-Id: I822392da57428b71dc4a3f50cf1b96c40d4a0315
Reviewed-on: https://chromium-review.googlesource.com/517447
Commit-Queue: Yutaka Hirano <yhirano@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#475330}
[modify] https://crrev.com/7d8a4d97b96a7e1f398424c840668fc17989f5d0/third_party/WebKit/Source/core/dom/Document.cpp
[modify] https://crrev.com/7d8a4d97b96a7e1f398424c840668fc17989f5d0/third_party/WebKit/Source/core/loader/FrameFetchContext.cpp
[modify] https://crrev.com/7d8a4d97b96a7e1f398424c840668fc17989f5d0/third_party/WebKit/Source/core/loader/FrameFetchContext.h
[modify] https://crrev.com/7d8a4d97b96a7e1f398424c840668fc17989f5d0/third_party/WebKit/Source/core/loader/PingLoader.cpp
[modify] https://crrev.com/7d8a4d97b96a7e1f398424c840668fc17989f5d0/third_party/WebKit/Source/core/loader/ThreadableLoadingContext.cpp
[modify] https://crrev.com/7d8a4d97b96a7e1f398424c840668fc17989f5d0/third_party/WebKit/Source/core/loader/WorkerFetchContext.cpp
[modify] https://crrev.com/7d8a4d97b96a7e1f398424c840668fc17989f5d0/third_party/WebKit/Source/core/loader/WorkerFetchContext.h
[modify] https://crrev.com/7d8a4d97b96a7e1f398424c840668fc17989f5d0/third_party/WebKit/Source/core/loader/modulescript/ModuleScriptLoaderTest.cpp
[modify] https://crrev.com/7d8a4d97b96a7e1f398424c840668fc17989f5d0/third_party/WebKit/Source/core/loader/resource/FontResourceTest.cpp
[modify] https://crrev.com/7d8a4d97b96a7e1f398424c840668fc17989f5d0/third_party/WebKit/Source/core/loader/resource/ImageResourceTest.cpp
[modify] https://crrev.com/7d8a4d97b96a7e1f398424c840668fc17989f5d0/third_party/WebKit/Source/platform/loader/fetch/FetchContext.h
[modify] https://crrev.com/7d8a4d97b96a7e1f398424c840668fc17989f5d0/third_party/WebKit/Source/platform/loader/fetch/MemoryCacheCorrectnessTest.cpp
[modify] https://crrev.com/7d8a4d97b96a7e1f398424c840668fc17989f5d0/third_party/WebKit/Source/platform/loader/fetch/ResourceFetcher.cpp
[modify] https://crrev.com/7d8a4d97b96a7e1f398424c840668fc17989f5d0/third_party/WebKit/Source/platform/loader/fetch/ResourceFetcher.h
[modify] https://crrev.com/7d8a4d97b96a7e1f398424c840668fc17989f5d0/third_party/WebKit/Source/platform/loader/fetch/ResourceFetcherTest.cpp
[modify] https://crrev.com/7d8a4d97b96a7e1f398424c840668fc17989f5d0/third_party/WebKit/Source/platform/loader/fetch/ResourceLoader.cpp
[modify] https://crrev.com/7d8a4d97b96a7e1f398424c840668fc17989f5d0/third_party/WebKit/Source/platform/loader/testing/MockFetchContext.h

Project Member

Comment 14 by bugdroid1@chromium.org, May 30 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1822bd90bc905e63257be1d2f4b1fca7acc516a7

commit 1822bd90bc905e63257be1d2f4b1fca7acc516a7
Author: Yutaka Hirano <yhirano@chromium.org>
Date: Tue May 30 05:46:10 2017

Remove unused "is_beacon" from PingLoader

The function parameter and the corresponding member variable are completely
useless, as the former is ignored and the latter is always set to true.

Bug:  695939 
Change-Id: I5d101a096beacef112989ce6c624b96ddd62ae06
Reviewed-on: https://chromium-review.googlesource.com/517809
Commit-Queue: Yutaka Hirano <yhirano@chromium.org>
Reviewed-by: Takeshi Yoshino <tyoshino@chromium.org>
Cr-Commit-Position: refs/heads/master@{#475432}
[modify] https://crrev.com/1822bd90bc905e63257be1d2f4b1fca7acc516a7/third_party/WebKit/Source/core/loader/PingLoader.cpp

Project Member

Comment 15 by bugdroid1@chromium.org, May 31 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0b923fff5b586cbbc9665526340bf4305634ee1a

commit 0b923fff5b586cbbc9665526340bf4305634ee1a
Author: Yutaka Hirano <yhirano@chromium.org>
Date: Wed May 31 01:39:30 2017

Remove a task runner setting logic from PingLoader

This CL moves a task runner setting logic from PingLoader to FrameFetchContext.
In order to do that, this CL also introduces "keepalive" member to
ResourceRequest and WebURLRequest.

Bug:  695939 
Change-Id: Id02e025d1d7e4bdfc4372e52b6c0fd4c72937520
Reviewed-on: https://chromium-review.googlesource.com/517450
Commit-Queue: Yutaka Hirano <yhirano@chromium.org>
Reviewed-by: Takeshi Yoshino <tyoshino@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#475725}
[modify] https://crrev.com/0b923fff5b586cbbc9665526340bf4305634ee1a/content/child/web_url_loader_impl.cc
[modify] https://crrev.com/0b923fff5b586cbbc9665526340bf4305634ee1a/third_party/WebKit/Source/core/loader/FrameFetchContext.cpp
[modify] https://crrev.com/0b923fff5b586cbbc9665526340bf4305634ee1a/third_party/WebKit/Source/core/loader/PingLoader.cpp
[modify] https://crrev.com/0b923fff5b586cbbc9665526340bf4305634ee1a/third_party/WebKit/Source/platform/exported/WebURLRequest.cpp
[modify] https://crrev.com/0b923fff5b586cbbc9665526340bf4305634ee1a/third_party/WebKit/Source/platform/loader/fetch/ResourceRequest.cpp
[modify] https://crrev.com/0b923fff5b586cbbc9665526340bf4305634ee1a/third_party/WebKit/Source/platform/loader/fetch/ResourceRequest.h
[modify] https://crrev.com/0b923fff5b586cbbc9665526340bf4305634ee1a/third_party/WebKit/public/platform/WebURLRequest.h

Blocking: 665094
Blocking: 611453
Project Member

Comment 18 by bugdroid1@chromium.org, Jun 1 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ee1c707a83bef0504aaabd120d44fbcef56f7380

commit ee1c707a83bef0504aaabd120d44fbcef56f7380
Author: Yutaka Hirano <yhirano@chromium.org>
Date: Thu Jun 01 21:32:28 2017

Introduce FetchContext::Detach

In order to notify FrameFetchContext of frame detach event, this CL adds a
new function. FrameFetchContext::document_ has been a weak member due to a
reference cycle. This CL also makes the reference strong and break the cycle
explicitly on the event.

Bug:  695939 
Change-Id: I0395c649c1da4797be3f9055ee38c86ff5e6e844
Reviewed-on: https://chromium-review.googlesource.com/516843
Reviewed-by: Nate Chapin <japhet@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Commit-Queue: Yutaka Hirano <yhirano@chromium.org>
Cr-Commit-Position: refs/heads/master@{#476443}
[modify] https://crrev.com/ee1c707a83bef0504aaabd120d44fbcef56f7380/third_party/WebKit/Source/core/loader/FrameFetchContext.cpp
[modify] https://crrev.com/ee1c707a83bef0504aaabd120d44fbcef56f7380/third_party/WebKit/Source/core/loader/FrameFetchContext.h
[modify] https://crrev.com/ee1c707a83bef0504aaabd120d44fbcef56f7380/third_party/WebKit/Source/platform/loader/fetch/FetchContext.h
[modify] https://crrev.com/ee1c707a83bef0504aaabd120d44fbcef56f7380/third_party/WebKit/Source/platform/loader/fetch/ResourceFetcher.cpp

Blocking: 711060
Project Member

Comment 20 by bugdroid1@chromium.org, Jun 12 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cab91726716ca6faa375e88d9125737a2a6d6978

commit cab91726716ca6faa375e88d9125737a2a6d6978
Author: Yutaka Hirano <yhirano@chromium.org>
Date: Mon Jun 12 03:36:17 2017

Make FrameFetchContext detachable

This CL makes FrameFetchContext work after detached from the underlying
frame and document, in order to support use-cases currently covered by PingLoader.

After detached, FrameFetchContext stops notifying, but keeps enforcing
security checks by storing the security information when detached. One important
TODO is ShouldBlockFetchByMixedContentCheck which is not implemented in this CL
because MixedContentChecker requires a real Frame instance.

Bug:  695939 
Change-Id: I0fee9d39cd996a5546fe8378910386d9de7dc27d
Reviewed-on: https://chromium-review.googlesource.com/518743
Commit-Queue: Yutaka Hirano <yhirano@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Mike West <mkwst@chromium.org>
Cr-Commit-Position: refs/heads/master@{#478545}
[modify] https://crrev.com/cab91726716ca6faa375e88d9125737a2a6d6978/third_party/WebKit/Source/core/dom/Document.cpp
[modify] https://crrev.com/cab91726716ca6faa375e88d9125737a2a6d6978/third_party/WebKit/Source/core/html/imports/HTMLImportsController.cpp
[modify] https://crrev.com/cab91726716ca6faa375e88d9125737a2a6d6978/third_party/WebKit/Source/core/loader/FrameFetchContext.cpp
[modify] https://crrev.com/cab91726716ca6faa375e88d9125737a2a6d6978/third_party/WebKit/Source/core/loader/FrameFetchContext.h
[modify] https://crrev.com/cab91726716ca6faa375e88d9125737a2a6d6978/third_party/WebKit/Source/core/loader/FrameFetchContextTest.cpp
[modify] https://crrev.com/cab91726716ca6faa375e88d9125737a2a6d6978/third_party/WebKit/Source/core/loader/FrameLoader.cpp
[modify] https://crrev.com/cab91726716ca6faa375e88d9125737a2a6d6978/third_party/WebKit/Source/core/loader/FrameLoader.h
[modify] https://crrev.com/cab91726716ca6faa375e88d9125737a2a6d6978/third_party/WebKit/Source/web/tests/LocalFrameClientImplTest.cpp

Project Member

Comment 21 by bugdroid1@chromium.org, Jun 14 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d1b870f2cf4bece0726cc8a89aa36f2fe38d73ad

commit d1b870f2cf4bece0726cc8a89aa36f2fe38d73ad
Author: Yutaka Hirano <yhirano@chromium.org>
Date: Wed Jun 14 06:52:53 2017

[FrameFetchContext] Stop consulting ScriptController when detached

FrameFetchContext::Detach can be called during V8 the collection step
and it's not safe to call ScriptController::ShouldBypassMainWorldCSP in
the function. On the other hand,
ScriptController::ShouldBypassMainWorldCSP relies on
v8::Isolate::GetCurrentContext and hence doesn't work correctly when
not directly called from JS. So eturning false when detached won't break
things.

Bug:  695939 , 732755
Change-Id: I1a648fd57d0a31236aa8caf2890ae938f2166f62
Reviewed-on: https://chromium-review.googlesource.com/535255
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Commit-Queue: Yutaka Hirano <yhirano@chromium.org>
Cr-Commit-Position: refs/heads/master@{#479308}
[modify] https://crrev.com/d1b870f2cf4bece0726cc8a89aa36f2fe38d73ad/third_party/WebKit/Source/core/loader/FrameFetchContext.cpp

Project Member

Comment 23 by bugdroid1@chromium.org, Jun 27 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1663db4b63adac8fc9d8b0676d4e0023cdfa63b7

commit 1663db4b63adac8fc9d8b0676d4e0023cdfa63b7
Author: Yutaka Hirano <yhirano@chromium.org>
Date: Tue Jun 27 08:40:14 2017

Have SendBeacon use ResourceFetcher

This CL makes SendBeacon use the standard way to load resources rather
than hacky PingLoaderImpl.

Bug:  695939 
Change-Id: Ice4f09a392337a7920f04f3227177fc8a1681e06
Reviewed-on: https://chromium-review.googlesource.com/541158
Reviewed-by: Mike West <mkwst@chromium.org>
Reviewed-by: Takeshi Yoshino <tyoshino@chromium.org>
Commit-Queue: Yutaka Hirano <yhirano@chromium.org>
Cr-Commit-Position: refs/heads/master@{#482573}
[modify] https://crrev.com/1663db4b63adac8fc9d8b0676d4e0023cdfa63b7/third_party/WebKit/LayoutTests/FlagExpectations/enable-blink-features=LayoutNG
[modify] https://crrev.com/1663db4b63adac8fc9d8b0676d4e0023cdfa63b7/third_party/WebKit/LayoutTests/external/wpt/content-security-policy/connect-src/connect-src-beacon-blocked.sub.html
[delete] https://crrev.com/de0c27b10c909960c3797ffc42159fb81d8c4bbd/third_party/WebKit/LayoutTests/http/tests/security/contentSecurityPolicy/connect-src-beacon-redirect-to-blocked-expected.txt
[delete] https://crrev.com/de0c27b10c909960c3797ffc42159fb81d8c4bbd/third_party/WebKit/LayoutTests/http/tests/security/contentSecurityPolicy/connect-src-beacon-redirect-to-blocked.html
[modify] https://crrev.com/1663db4b63adac8fc9d8b0676d4e0023cdfa63b7/third_party/WebKit/Source/core/loader/PingLoader.cpp
[modify] https://crrev.com/1663db4b63adac8fc9d8b0676d4e0023cdfa63b7/third_party/WebKit/Source/platform/loader/fetch/ResourceFetcher.cpp
[modify] https://crrev.com/1663db4b63adac8fc9d8b0676d4e0023cdfa63b7/third_party/WebKit/Source/platform/loader/fetch/ResourceLoader.cpp
[modify] https://crrev.com/1663db4b63adac8fc9d8b0676d4e0023cdfa63b7/third_party/WebKit/Source/platform/loader/fetch/ResourceLoader.h

Project Member

Comment 25 by bugdroid1@chromium.org, Jun 30 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/647d4a8464b2554053edb74a07bc35e3828df4cd

commit 647d4a8464b2554053edb74a07bc35e3828df4cd
Author: Yutaka Hirano <yhirano@chromium.org>
Date: Fri Jun 30 15:49:35 2017

Handle "same-origin" credentials mode with "no-cors" mode correctly

The spec says "same-origin" credentials mode takes effect even when used
with "no-cors" mode, but in blink::ResourceFetcher it behaves just like
"include".

Currently CSP violation report uses "same-origin" credentials mode is
used with "no-cors" mode, but it doesn't useResourceFetcher.

This CL fixes ResourceFetcher so that CSP violation report can use
ResourceFetcher.

This change is aligned with the consensus made on a fetch API spec
discussion: https://github.com/whatwg/fetch/issues/169

Bug:  695939 
Change-Id: I50537125399909c30d1a5eb293859520c11d7c82
Reviewed-on: https://chromium-review.googlesource.com/554513
Commit-Queue: Yutaka Hirano <yhirano@chromium.org>
Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
Reviewed-by: Takeshi Yoshino <tyoshino@chromium.org>
Cr-Commit-Position: refs/heads/master@{#483713}
[modify] https://crrev.com/647d4a8464b2554053edb74a07bc35e3828df4cd/third_party/WebKit/Source/platform/loader/fetch/ResourceFetcher.cpp

Project Member

Comment 26 by bugdroid1@chromium.org, Jun 30 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3a0905c1392858d49ee03a2081500351d4568320

commit 3a0905c1392858d49ee03a2081500351d4568320
Author: Yutaka Hirano <yhirano@chromium.org>
Date: Fri Jun 30 16:09:00 2017

Remove PingLoaderImpl

This CL retires PingLoaderImpl. Existing customers will use ResouceFetcher
instead.

Bug:  695939 
Change-Id: I93738be6e6000e3dc190abca38991cffbe503c80
Reviewed-on: https://chromium-review.googlesource.com/554530
Reviewed-by: Takeshi Yoshino <tyoshino@chromium.org>
Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
Reviewed-by: Mike West <mkwst@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Commit-Queue: Yutaka Hirano <yhirano@chromium.org>
Cr-Commit-Position: refs/heads/master@{#483720}
[modify] https://crrev.com/3a0905c1392858d49ee03a2081500351d4568320/third_party/WebKit/Source/core/frame/csp/ContentSecurityPolicy.cpp
[modify] https://crrev.com/3a0905c1392858d49ee03a2081500351d4568320/third_party/WebKit/Source/core/loader/PingLoader.cpp

Project Member

Comment 27 by bugdroid1@chromium.org, Jul 14 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4f47f5adab253e87960648f64e15bf5246a4958d

commit 4f47f5adab253e87960648f64e15bf5246a4958d
Author: Yutaka Hirano <yhirano@chromium.org>
Date: Fri Jul 14 01:47:28 2017

Set 'keepalive' flag for ViolationReport requests

Bug:  695939 
Change-Id: I4f3ad7e06d44db7534a8750f3a344ad27bb4f460
Reviewed-on: https://chromium-review.googlesource.com/569328
Reviewed-by: Takeshi Yoshino <tyoshino@chromium.org>
Commit-Queue: Yutaka Hirano <yhirano@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486618}
[modify] https://crrev.com/4f47f5adab253e87960648f64e15bf5246a4958d/third_party/WebKit/Source/core/loader/PingLoader.cpp
[modify] https://crrev.com/4f47f5adab253e87960648f64e15bf5246a4958d/third_party/WebKit/Source/core/loader/PingLoaderTest.cpp

Project Member

Comment 28 by sheriffbot@chromium.org, Jul 26 2017

Labels: Hotlist-Google
Blockedon: 719819
Blockedon: -719819
Blockedon: 736308
Project Member

Comment 32 by bugdroid1@chromium.org, Aug 9 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/901fe7e0eb060b971a61bf37f1a093a5da37bd2d

commit 901fe7e0eb060b971a61bf37f1a093a5da37bd2d
Author: Yutaka Hirano <yhirano@chromium.org>
Date: Wed Aug 09 02:10:37 2017

RDHI::CancelRequestsForRoute must detach only matched detachable loaders

ResourceDispatcherHostImpl::CancelRequestsForRoute detached all
detachable resource loaders whose child id matches with the child id of
the given GlobalFrameRoutingId, but it's too broad. Only detachable
loaders whose GlobalFrameRoutingId matches with the given one should be
detached.

Bug:  695939 
Change-Id: I7d0364ddfae0dfea0a1bca70b8fcd9af1a5fd9e9
Reviewed-on: https://chromium-review.googlesource.com/600148
Reviewed-by: Charlie Harrison <csharrison@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Commit-Queue: Yutaka Hirano <yhirano@chromium.org>
Cr-Commit-Position: refs/heads/master@{#492806}
[modify] https://crrev.com/901fe7e0eb060b971a61bf37f1a093a5da37bd2d/content/browser/loader/resource_dispatcher_host_impl.cc
[modify] https://crrev.com/901fe7e0eb060b971a61bf37f1a093a5da37bd2d/content/browser/loader/resource_dispatcher_host_impl.h
[modify] https://crrev.com/901fe7e0eb060b971a61bf37f1a093a5da37bd2d/content/browser/loader/resource_dispatcher_host_unittest.cc

Project Member

Comment 33 by bugdroid1@chromium.org, Aug 15 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/10f281b7a3ed3d65f68f525c22970d0d8c05eb1a

commit 10f281b7a3ed3d65f68f525c22970d0d8c05eb1a
Author: Yutaka Hirano <yhirano@chromium.org>
Date: Tue Aug 15 07:06:24 2017

Disallow requesting non-redirect keepalive request when detached

This is needed to be aligned with a DCHECK in
FrameFetchContext::CreateURLLoader.

Bug:  695939 
Change-Id: I90c92c1b33fbe15d11ac5cf5907d841d853b5780
Reviewed-on: https://chromium-review.googlesource.com/605152
Reviewed-by: Takeshi Yoshino <tyoshino@chromium.org>
Commit-Queue: Yutaka Hirano <yhirano@chromium.org>
Cr-Commit-Position: refs/heads/master@{#494339}
[modify] https://crrev.com/10f281b7a3ed3d65f68f525c22970d0d8c05eb1a/third_party/WebKit/Source/core/loader/BaseFetchContext.cpp
[modify] https://crrev.com/10f281b7a3ed3d65f68f525c22970d0d8c05eb1a/third_party/WebKit/Source/core/loader/BaseFetchContextTest.cpp

Project Member

Comment 34 by bugdroid1@chromium.org, Aug 16 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/09a9afb9b4ddb236064125dce454322f6e6e1112

commit 09a9afb9b4ddb236064125dce454322f6e6e1112
Author: Yutaka Hirano <yhirano@chromium.org>
Date: Wed Aug 16 09:11:45 2017

Rename RenderProcessHost::*Worker*RefCount

RenderProcessHost has methods to increment shared worker / service worker
ref counts. Because they are working in the same manner and I'm planning
to introduce a similar ref count, this CL unifies them to one.

Bug:  695939 
Change-Id: I4dccba6eaf725fd9e0ee2e31caab4a1c283e34d9
Reviewed-on: https://chromium-review.googlesource.com/615212
Commit-Queue: Yutaka Hirano <yhirano@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#494730}
[modify] https://crrev.com/09a9afb9b4ddb236064125dce454322f6e6e1112/content/browser/browser_context.cc
[modify] https://crrev.com/09a9afb9b4ddb236064125dce454322f6e6e1112/content/browser/renderer_host/render_process_host_impl.cc
[modify] https://crrev.com/09a9afb9b4ddb236064125dce454322f6e6e1112/content/browser/renderer_host/render_process_host_impl.h
[modify] https://crrev.com/09a9afb9b4ddb236064125dce454322f6e6e1112/content/browser/service_worker/service_worker_process_manager.cc
[modify] https://crrev.com/09a9afb9b4ddb236064125dce454322f6e6e1112/content/browser/service_worker/service_worker_process_manager_unittest.cc
[modify] https://crrev.com/09a9afb9b4ddb236064125dce454322f6e6e1112/content/browser/shared_worker/shared_worker_service_impl.cc
[modify] https://crrev.com/09a9afb9b4ddb236064125dce454322f6e6e1112/content/browser/site_per_process_browsertest.cc
[modify] https://crrev.com/09a9afb9b4ddb236064125dce454322f6e6e1112/content/public/browser/render_process_host.h
[modify] https://crrev.com/09a9afb9b4ddb236064125dce454322f6e6e1112/content/public/test/mock_render_process_host.cc
[modify] https://crrev.com/09a9afb9b4ddb236064125dce454322f6e6e1112/content/public/test/mock_render_process_host.h

Project Member

Comment 35 by bugdroid1@chromium.org, Aug 18 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c548d0762fbf7c5482dfcaa8bb611cbc2569e328

commit c548d0762fbf7c5482dfcaa8bb611cbc2569e328
Author: Yutaka Hirano <yhirano@chromium.org>
Date: Fri Aug 18 06:11:15 2017

Prolong ResourceFetcher's lifetime for keepalive loaders

This CL has ResourceFetcher have a SelfKeepAlive member to extend its
lifetime when it has keepalive loaders. Previously ResourceLoader had
the member, but this CL removes it.

This CL also introduces a hard timeout for keepalive loaders.

Bug:  695939 
Change-Id: I19cda1522b2884d8fb07a3f623513b7fa576ce7b
Reviewed-on: https://chromium-review.googlesource.com/609763
Reviewed-by: Takeshi Yoshino <tyoshino@chromium.org>
Commit-Queue: Yutaka Hirano <yhirano@chromium.org>
Cr-Commit-Position: refs/heads/master@{#495476}
[modify] https://crrev.com/c548d0762fbf7c5482dfcaa8bb611cbc2569e328/third_party/WebKit/Source/platform/loader/fetch/ResourceFetcher.cpp
[modify] https://crrev.com/c548d0762fbf7c5482dfcaa8bb611cbc2569e328/third_party/WebKit/Source/platform/loader/fetch/ResourceFetcher.h
[modify] https://crrev.com/c548d0762fbf7c5482dfcaa8bb611cbc2569e328/third_party/WebKit/Source/platform/loader/fetch/ResourceLoader.cpp
[modify] https://crrev.com/c548d0762fbf7c5482dfcaa8bb611cbc2569e328/third_party/WebKit/Source/platform/loader/fetch/ResourceLoader.h

Blocking: 372197
Project Member

Comment 37 by bugdroid1@chromium.org, Aug 23 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/dacc670f59624580b516fb299150c4ea8a7b7f72

commit dacc670f59624580b516fb299150c4ea8a7b7f72
Author: Yutaka Hirano <yhirano@chromium.org>
Date: Wed Aug 23 11:47:23 2017

Revert "Specify correct request mode for SendBeacon"

This reverts commit 0fbc79aab000df51cb43513c03d9c34700edffc8.

Reason for revert: The SendBeacon spec requires us to use the
"no-cors" mode if the request headers are CORS-safelisted. As we
currently block requests with non CORS-safelisted headers, all beacon
requests we make should use the "no-cors" mode.

Original change's description:
> Specify correct request mode for SendBeacon
> 
> Bug:  695939 
> Change-Id: I88421009947673d4508a088f23f2b4e5a0926d67
> Reviewed-on: https://chromium-review.googlesource.com/554423
> Commit-Queue: Yutaka Hirano <yhirano@chromium.org>
> Reviewed-by: Takeshi Yoshino <tyoshino@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#483384}

TBR=tyoshino@chromium.org,yhirano@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug:  695939 ,  757725 
Change-Id: Icd6f11209bf20eae650ecd7a2dd74b853f87b1a7
Reviewed-on: https://chromium-review.googlesource.com/627968
Reviewed-by: Takeshi Yoshino <tyoshino@chromium.org>
Commit-Queue: Yutaka Hirano <yhirano@chromium.org>
Cr-Commit-Position: refs/heads/master@{#496659}
[modify] https://crrev.com/dacc670f59624580b516fb299150c4ea8a7b7f72/third_party/WebKit/LayoutTests/http/tests/sendbeacon/beacon-cross-origin-redirect-expected.txt
[modify] https://crrev.com/dacc670f59624580b516fb299150c4ea8a7b7f72/third_party/WebKit/LayoutTests/http/tests/sendbeacon/resources/save-beacon.php
[modify] https://crrev.com/dacc670f59624580b516fb299150c4ea8a7b7f72/third_party/WebKit/Source/core/loader/PingLoader.cpp

Project Member

Comment 38 by bugdroid1@chromium.org, Aug 24 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c9cad9b36cc265e01b98737bdbcb6bb145f0a31f

commit c9cad9b36cc265e01b98737bdbcb6bb145f0a31f
Author: Yutaka Hirano <yhirano@chromium.org>
Date: Thu Aug 24 13:20:42 2017

Rename SharedWorker.RendererSurviveForWorkerTime

As we will keep the render alive also for keepalive fetch requests, this
CL renames existing SharedWorker.RendererSurviveForWorkerTime.

Bug:  695939 
Change-Id: If69cbb09898b77217caa223338e79b5adfb55f7c
Reviewed-on: https://chromium-review.googlesource.com/616542
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Commit-Queue: Yutaka Hirano <yhirano@chromium.org>
Cr-Commit-Position: refs/heads/master@{#497022}
[modify] https://crrev.com/c9cad9b36cc265e01b98737bdbcb6bb145f0a31f/content/browser/renderer_host/render_process_host_impl.cc
[modify] https://crrev.com/c9cad9b36cc265e01b98737bdbcb6bb145f0a31f/tools/metrics/histograms/histograms.xml

Project Member

Comment 39 by bugdroid1@chromium.org, Sep 1 2017

Labels: merge-merged-3163
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b60787e90053820ff2caf85c8d1d0389a10a0df9

commit b60787e90053820ff2caf85c8d1d0389a10a0df9
Author: Yutaka Hirano <yhirano@chromium.org>
Date: Fri Sep 01 18:04:16 2017

Revert "Specify correct request mode for SendBeacon"

This reverts commit 0fbc79aab000df51cb43513c03d9c34700edffc8.

Reason for revert: The SendBeacon spec requires us to use the
"no-cors" mode if the request headers are CORS-safelisted. As we
currently block requests with non CORS-safelisted headers, all beacon
requests we make should use the "no-cors" mode.

Original change's description:
> Specify correct request mode for SendBeacon
>
> Bug:  695939 
> Change-Id: I88421009947673d4508a088f23f2b4e5a0926d67
> Reviewed-on: https://chromium-review.googlesource.com/554423
> Commit-Queue: Yutaka Hirano <yhirano@chromium.org>
> Reviewed-by: Takeshi Yoshino <tyoshino@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#483384}

TBR=tyoshino@chromium.org, yhirano@chromium.org


(cherry picked from commit dacc670f59624580b516fb299150c4ea8a7b7f72)

Bug:  695939 ,  757725 
Change-Id: Icd6f11209bf20eae650ecd7a2dd74b853f87b1a7
Reviewed-on: https://chromium-review.googlesource.com/627968
Reviewed-by: Takeshi Yoshino <tyoshino@chromium.org>
Commit-Queue: Yutaka Hirano <yhirano@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#496659}
Reviewed-on: https://chromium-review.googlesource.com/647728
Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
Cr-Commit-Position: refs/branch-heads/3163@{#1069}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}
[modify] https://crrev.com/b60787e90053820ff2caf85c8d1d0389a10a0df9/third_party/WebKit/LayoutTests/http/tests/sendbeacon/beacon-cross-origin-redirect-expected.txt
[modify] https://crrev.com/b60787e90053820ff2caf85c8d1d0389a10a0df9/third_party/WebKit/LayoutTests/http/tests/sendbeacon/resources/save-beacon.php
[modify] https://crrev.com/b60787e90053820ff2caf85c8d1d0389a10a0df9/third_party/WebKit/Source/core/loader/PingLoader.cpp

Project Member

Comment 40 by bugdroid1@chromium.org, Sep 6 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f7f2f63629747df4e59c6b63e02f9b02c518b33f

commit f7f2f63629747df4e59c6b63e02f9b02c518b33f
Author: Yutaka Hirano <yhirano@chromium.org>
Date: Wed Sep 06 10:40:08 2017

Keep renderer alive for "keepalive" requests

In order to support "keepalive" property in the fetch spec, we need to
keep a renderer process alive while such requests are pending. This CL
introduces "KeepAliveRendererForKeepaliveRequests" feature. When it
is enabled, WebURLLoaderImpls for requests with keepalive specified
prolongs the renderer process untill a certain time period (default:
30sec) passes since the frame destruction

The feature is disabled by default.

Bug:  695939 
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_site_isolation
Change-Id: I0dd5ee2c1dfd4e694dfcf2f2f62485add7dec249
Reviewed-on: https://chromium-review.googlesource.com/616406
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Takeshi Yoshino <tyoshino@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Commit-Queue: Yutaka Hirano <yhirano@chromium.org>
Cr-Commit-Position: refs/heads/master@{#499928}
[modify] https://crrev.com/f7f2f63629747df4e59c6b63e02f9b02c518b33f/chrome/browser/about_flags.cc
[modify] https://crrev.com/f7f2f63629747df4e59c6b63e02f9b02c518b33f/chrome/browser/flag_descriptions.cc
[modify] https://crrev.com/f7f2f63629747df4e59c6b63e02f9b02c518b33f/chrome/browser/flag_descriptions.h
[modify] https://crrev.com/f7f2f63629747df4e59c6b63e02f9b02c518b33f/content/browser/BUILD.gn
[modify] https://crrev.com/f7f2f63629747df4e59c6b63e02f9b02c518b33f/content/browser/bad_message.h
[add] https://crrev.com/f7f2f63629747df4e59c6b63e02f9b02c518b33f/content/browser/frame_host/keep_alive_handle_factory.cc
[add] https://crrev.com/f7f2f63629747df4e59c6b63e02f9b02c518b33f/content/browser/frame_host/keep_alive_handle_factory.h
[modify] https://crrev.com/f7f2f63629747df4e59c6b63e02f9b02c518b33f/content/browser/frame_host/render_frame_host_impl.cc
[modify] https://crrev.com/f7f2f63629747df4e59c6b63e02f9b02c518b33f/content/browser/frame_host/render_frame_host_impl.h
[modify] https://crrev.com/f7f2f63629747df4e59c6b63e02f9b02c518b33f/content/browser/loader/resource_dispatcher_host_impl.cc
[modify] https://crrev.com/f7f2f63629747df4e59c6b63e02f9b02c518b33f/content/browser/renderer_host/render_process_host_browsertest.cc
[modify] https://crrev.com/f7f2f63629747df4e59c6b63e02f9b02c518b33f/content/child/web_url_loader_impl.cc
[modify] https://crrev.com/f7f2f63629747df4e59c6b63e02f9b02c518b33f/content/child/web_url_loader_impl.h
[modify] https://crrev.com/f7f2f63629747df4e59c6b63e02f9b02c518b33f/content/common/frame.mojom
[modify] https://crrev.com/f7f2f63629747df4e59c6b63e02f9b02c518b33f/content/public/browser/render_process_host.h
[modify] https://crrev.com/f7f2f63629747df4e59c6b63e02f9b02c518b33f/content/public/common/content_features.cc
[modify] https://crrev.com/f7f2f63629747df4e59c6b63e02f9b02c518b33f/content/public/common/content_features.h
[modify] https://crrev.com/f7f2f63629747df4e59c6b63e02f9b02c518b33f/content/renderer/render_frame_impl.cc
[add] https://crrev.com/f7f2f63629747df4e59c6b63e02f9b02c518b33f/content/test/data/send-beacon.html
[modify] https://crrev.com/f7f2f63629747df4e59c6b63e02f9b02c518b33f/content/test/test_render_frame.cc
[modify] https://crrev.com/f7f2f63629747df4e59c6b63e02f9b02c518b33f/tools/metrics/histograms/enums.xml

Project Member

Comment 41 by bugdroid1@chromium.org, Sep 12 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4c0815ca5b45a74b45a27bb7c55e72a5cdef9340

commit 4c0815ca5b45a74b45a27bb7c55e72a5cdef9340
Author: Yutaka Hirano <yhirano@chromium.org>
Date: Tue Sep 12 05:00:05 2017

Fix no-state prefetch handling with KeepAliveRenderer feature

A browser test for no-state prefetch failed for
KeepAliveRendererForKeepaliveRequests feature, which meant a bug. This
CL fixed the mishandling. With this CL, "keepalive" flag is
transferred from the renderer to the browser, and the feature affects
only requests with "keepalive" flag.

The non-state prefetch browser tests are now run in both settings
(i.e., with/without the feature).

Bug:  695939 
Change-Id: I77c42cce95346f034af3ef4b7496908affc3074d
Reviewed-on: https://chromium-review.googlesource.com/656741
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Yutaka Hirano <yhirano@chromium.org>
Cr-Commit-Position: refs/heads/master@{#501181}
[modify] https://crrev.com/4c0815ca5b45a74b45a27bb7c55e72a5cdef9340/chrome/browser/prerender/prerender_nostate_prefetch_browsertest.cc
[modify] https://crrev.com/4c0815ca5b45a74b45a27bb7c55e72a5cdef9340/content/browser/devtools/devtools_url_interceptor_request_job.cc
[modify] https://crrev.com/4c0815ca5b45a74b45a27bb7c55e72a5cdef9340/content/browser/loader/async_resource_handler_unittest.cc
[modify] https://crrev.com/4c0815ca5b45a74b45a27bb7c55e72a5cdef9340/content/browser/loader/resource_dispatcher_host_impl.cc
[modify] https://crrev.com/4c0815ca5b45a74b45a27bb7c55e72a5cdef9340/content/browser/loader/resource_dispatcher_host_unittest.cc
[modify] https://crrev.com/4c0815ca5b45a74b45a27bb7c55e72a5cdef9340/content/browser/loader/resource_request_info_impl.cc
[modify] https://crrev.com/4c0815ca5b45a74b45a27bb7c55e72a5cdef9340/content/browser/loader/resource_request_info_impl.h
[modify] https://crrev.com/4c0815ca5b45a74b45a27bb7c55e72a5cdef9340/content/child/web_url_loader_impl.cc
[modify] https://crrev.com/4c0815ca5b45a74b45a27bb7c55e72a5cdef9340/content/common/resource_messages.h
[modify] https://crrev.com/4c0815ca5b45a74b45a27bb7c55e72a5cdef9340/content/public/common/resource_request.h

Project Member

Comment 42 by bugdroid1@chromium.org, Sep 12 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0fc91f55cf308b433218986414d70150087da545

commit 0fc91f55cf308b433218986414d70150087da545
Author: Yutaka Hirano <yhirano@chromium.org>
Date: Tue Sep 12 07:31:08 2017

Add Field Trial Testing Configuration for KeepAliveRendererForKeepaliveRequests

Bug:  695939 
Change-Id: I39a9e9ce3b030ec233a03912a3b55d25fffa46a4
Reviewed-on: https://chromium-review.googlesource.com/652208
Commit-Queue: Yutaka Hirano <yhirano@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#501209}
[modify] https://crrev.com/0fc91f55cf308b433218986414d70150087da545/testing/variations/fieldtrial_testing_config.json

Labels: -Type-Bug Type-Launch-OWP
Labels: migrated-launch-owp Type-Task
This issue has been automatically relabelled type=task because type=launch-owp issues are now officially deprecated. The deprecation is because they were creating confusion about how to get launch approvals, which should be instead done via type=launch issues.

We recommend this issue be used for implementation tracking (for public visibility), but if you already have an issue for that, you may mark this as duplicate.

For more details see here: https://docs.google.com/document/d/1JA6RohjtZQc26bTrGoIE_bSXGXUDQz8vc6G0n_sZJ2o/edit

For any questions, please contact owencm, sshruthi, larforge
Blockedon: 764589
Project Member

Comment 46 by bugdroid1@chromium.org, Oct 11 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9ad71ec1e88be1bf4ed3188afbadadcc4e70e0c6

commit 9ad71ec1e88be1bf4ed3188afbadadcc4e70e0c6
Author: Yutaka Hirano <yhirano@chromium.org>
Date: Wed Oct 11 11:42:55 2017

Enable KeepAliveRendererForKeepaliveRequests

As the finch experiment didn't show significant performance / stability
regressions, this CL enables the feature by default.

This is not a user-facing feature.

Bug:  695939 
Change-Id: I92596eade7c0718356ef6b9b575294ecf7874055
Reviewed-on: https://chromium-review.googlesource.com/708101
Commit-Queue: Yutaka Hirano <yhirano@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Takeshi Yoshino <tyoshino@chromium.org>
Cr-Commit-Position: refs/heads/master@{#507952}
[modify] https://crrev.com/9ad71ec1e88be1bf4ed3188afbadadcc4e70e0c6/content/browser/loader/resource_dispatcher_host_unittest.cc
[modify] https://crrev.com/9ad71ec1e88be1bf4ed3188afbadadcc4e70e0c6/content/public/common/content_features.cc

Project Member

Comment 47 by bugdroid1@chromium.org, Oct 16 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f9e884e8b082b7ea84b5dc3320d42e882a3f323f

commit f9e884e8b082b7ea84b5dc3320d42e882a3f323f
Author: Yutaka Hirano <yhirano@chromium.org>
Date: Mon Oct 16 14:22:59 2017

[Fetch API] Have RequestInit's member variables private

I would like to introduce methods to it and hence I want it to be a
regular class.

Bug:  695939 
Change-Id: Ie073bc753d61f18a210ef1863a6b91f24342e7c2
Reviewed-on: https://chromium-review.googlesource.com/720860
Commit-Queue: Yutaka Hirano <yhirano@chromium.org>
Reviewed-by: Adam Rice <ricea@chromium.org>
Cr-Commit-Position: refs/heads/master@{#509037}
[modify] https://crrev.com/f9e884e8b082b7ea84b5dc3320d42e882a3f323f/third_party/WebKit/Source/modules/fetch/Request.cpp
[modify] https://crrev.com/f9e884e8b082b7ea84b5dc3320d42e882a3f323f/third_party/WebKit/Source/modules/fetch/RequestInit.cpp
[modify] https://crrev.com/f9e884e8b082b7ea84b5dc3320d42e882a3f323f/third_party/WebKit/Source/modules/fetch/RequestInit.h

Project Member

Comment 48 by bugdroid1@chromium.org, Oct 25 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9bcef7f21b943e423d91dab4104422eff753fd35

commit 9bcef7f21b943e423d91dab4104422eff753fd35
Author: Yutaka Hirano <yhirano@chromium.org>
Date: Wed Oct 25 13:49:28 2017

Implement keepalive flag on Request

This CL implements "keepalive" flag on Request behind an experimental
flag. Currently it has some restrictions.

 - Quota is not at all implemented.
 - Non-simple requets are not supported.
 - The request property is not propagated to service worker.

Bug:  695939 
Change-Id: Icafb6268e2c8cde86c6d08e0edb940af7be1c525
Reviewed-on: https://chromium-review.googlesource.com/730443
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Adam Rice <ricea@chromium.org>
Commit-Queue: Yutaka Hirano <yhirano@chromium.org>
Cr-Commit-Position: refs/heads/master@{#511440}
[modify] https://crrev.com/9bcef7f21b943e423d91dab4104422eff753fd35/content/browser/renderer_host/render_process_host_browsertest.cc
[add] https://crrev.com/9bcef7f21b943e423d91dab4104422eff753fd35/content/test/data/fetch-keepalive.html
[delete] https://crrev.com/92d486ea599cf8211a409ce1277c5179a234fca9/third_party/WebKit/LayoutTests/external/wpt/fetch/api/basic/keepalive-expected.txt
[modify] https://crrev.com/9bcef7f21b943e423d91dab4104422eff753fd35/third_party/WebKit/LayoutTests/external/wpt/fetch/api/basic/keepalive.html
[add] https://crrev.com/9bcef7f21b943e423d91dab4104422eff753fd35/third_party/WebKit/LayoutTests/external/wpt/fetch/api/request/request-keepalive-expected.txt
[add] https://crrev.com/9bcef7f21b943e423d91dab4104422eff753fd35/third_party/WebKit/LayoutTests/external/wpt/fetch/api/request/request-keepalive.html
[modify] https://crrev.com/9bcef7f21b943e423d91dab4104422eff753fd35/third_party/WebKit/LayoutTests/external/wpt/fetch/api/resources/keepalive-iframe.html
[modify] https://crrev.com/9bcef7f21b943e423d91dab4104422eff753fd35/third_party/WebKit/LayoutTests/external/wpt/fetch/api/resources/redirect.py
[add] https://crrev.com/9bcef7f21b943e423d91dab4104422eff753fd35/third_party/WebKit/LayoutTests/http/tests/fetch/chromium/keepalive-preflight.html
[modify] https://crrev.com/9bcef7f21b943e423d91dab4104422eff753fd35/third_party/WebKit/LayoutTests/http/tests/fetch/script-tests/request.js
[modify] https://crrev.com/9bcef7f21b943e423d91dab4104422eff753fd35/third_party/WebKit/LayoutTests/http/tests/serviceworker/webexposed/global-interface-listing-service-worker-expected.txt
[delete] https://crrev.com/92d486ea599cf8211a409ce1277c5179a234fca9/third_party/WebKit/LayoutTests/platform/linux/virtual/mojo-blobs/external/wpt/fetch/api/basic/keepalive-expected.txt
[delete] https://crrev.com/92d486ea599cf8211a409ce1277c5179a234fca9/third_party/WebKit/LayoutTests/platform/linux/virtual/outofblink-cors/external/wpt/fetch/api/basic/keepalive-expected.txt
[delete] https://crrev.com/92d486ea599cf8211a409ce1277c5179a234fca9/third_party/WebKit/LayoutTests/platform/mac/virtual/mojo-blobs/external/wpt/fetch/api/basic/keepalive-expected.txt
[delete] https://crrev.com/92d486ea599cf8211a409ce1277c5179a234fca9/third_party/WebKit/LayoutTests/platform/mac/virtual/outofblink-cors/external/wpt/fetch/api/basic/keepalive-expected.txt
[modify] https://crrev.com/9bcef7f21b943e423d91dab4104422eff753fd35/third_party/WebKit/LayoutTests/webexposed/global-interface-listing-dedicated-worker-expected.txt
[modify] https://crrev.com/9bcef7f21b943e423d91dab4104422eff753fd35/third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt
[modify] https://crrev.com/9bcef7f21b943e423d91dab4104422eff753fd35/third_party/WebKit/LayoutTests/webexposed/global-interface-listing-shared-worker-expected.txt
[modify] https://crrev.com/9bcef7f21b943e423d91dab4104422eff753fd35/third_party/WebKit/Source/core/loader/DocumentThreadableLoader.cpp
[modify] https://crrev.com/9bcef7f21b943e423d91dab4104422eff753fd35/third_party/WebKit/Source/core/loader/DocumentThreadableLoader.h
[modify] https://crrev.com/9bcef7f21b943e423d91dab4104422eff753fd35/third_party/WebKit/Source/core/loader/ThreadableLoader.h
[modify] https://crrev.com/9bcef7f21b943e423d91dab4104422eff753fd35/third_party/WebKit/Source/core/loader/WorkerThreadableLoader.cpp
[modify] https://crrev.com/9bcef7f21b943e423d91dab4104422eff753fd35/third_party/WebKit/Source/core/loader/WorkerThreadableLoader.h
[modify] https://crrev.com/9bcef7f21b943e423d91dab4104422eff753fd35/third_party/WebKit/Source/modules/fetch/BlobBytesConsumerTest.cpp
[modify] https://crrev.com/9bcef7f21b943e423d91dab4104422eff753fd35/third_party/WebKit/Source/modules/fetch/FetchManager.cpp
[modify] https://crrev.com/9bcef7f21b943e423d91dab4104422eff753fd35/third_party/WebKit/Source/modules/fetch/FetchRequestData.cpp
[modify] https://crrev.com/9bcef7f21b943e423d91dab4104422eff753fd35/third_party/WebKit/Source/modules/fetch/FetchRequestData.h
[modify] https://crrev.com/9bcef7f21b943e423d91dab4104422eff753fd35/third_party/WebKit/Source/modules/fetch/Request.cpp
[modify] https://crrev.com/9bcef7f21b943e423d91dab4104422eff753fd35/third_party/WebKit/Source/modules/fetch/Request.h
[modify] https://crrev.com/9bcef7f21b943e423d91dab4104422eff753fd35/third_party/WebKit/Source/modules/fetch/Request.idl
[modify] https://crrev.com/9bcef7f21b943e423d91dab4104422eff753fd35/third_party/WebKit/Source/modules/fetch/RequestInit.cpp
[modify] https://crrev.com/9bcef7f21b943e423d91dab4104422eff753fd35/third_party/WebKit/Source/modules/fetch/RequestInit.h
[modify] https://crrev.com/9bcef7f21b943e423d91dab4104422eff753fd35/third_party/WebKit/Source/platform/loader/fetch/Resource.cpp
[modify] https://crrev.com/9bcef7f21b943e423d91dab4104422eff753fd35/third_party/WebKit/Source/platform/loader/fetch/Resource.h
[modify] https://crrev.com/9bcef7f21b943e423d91dab4104422eff753fd35/third_party/WebKit/Source/platform/runtime_enabled_features.json5

Project Member

Comment 49 by bugdroid1@chromium.org, Oct 31 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bc0ba4b97ba5bd411b32f49b81dc7d8a491126e3

commit bc0ba4b97ba5bd411b32f49b81dc7d8a491126e3
Author: Yutaka Hirano <yhirano@chromium.org>
Date: Tue Oct 31 11:24:40 2017

[Fetch API] Propagate "keepalive" property to ServiceWorker

Bug:  695939 
Change-Id: If45e944d34eba2f9cd81f8e0a3e60cebc73e365b
Reviewed-on: https://chromium-review.googlesource.com/737498
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Adam Rice <ricea@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Makoto Shimazu <shimazu@chromium.org>
Commit-Queue: Yutaka Hirano <yhirano@chromium.org>
Cr-Commit-Position: refs/heads/master@{#512801}
[modify] https://crrev.com/bc0ba4b97ba5bd411b32f49b81dc7d8a491126e3/content/browser/loader/resource_dispatcher_host_impl.cc
[modify] https://crrev.com/bc0ba4b97ba5bd411b32f49b81dc7d8a491126e3/content/browser/service_worker/foreign_fetch_request_handler.cc
[modify] https://crrev.com/bc0ba4b97ba5bd411b32f49b81dc7d8a491126e3/content/browser/service_worker/foreign_fetch_request_handler.h
[modify] https://crrev.com/bc0ba4b97ba5bd411b32f49b81dc7d8a491126e3/content/browser/service_worker/foreign_fetch_request_handler_unittest.cc
[modify] https://crrev.com/bc0ba4b97ba5bd411b32f49b81dc7d8a491126e3/content/browser/service_worker/link_header_support_unittest.cc
[modify] https://crrev.com/bc0ba4b97ba5bd411b32f49b81dc7d8a491126e3/content/browser/service_worker/service_worker_context_request_handler_unittest.cc
[modify] https://crrev.com/bc0ba4b97ba5bd411b32f49b81dc7d8a491126e3/content/browser/service_worker/service_worker_controllee_request_handler.cc
[modify] https://crrev.com/bc0ba4b97ba5bd411b32f49b81dc7d8a491126e3/content/browser/service_worker/service_worker_controllee_request_handler.h
[modify] https://crrev.com/bc0ba4b97ba5bd411b32f49b81dc7d8a491126e3/content/browser/service_worker/service_worker_controllee_request_handler_unittest.cc
[modify] https://crrev.com/bc0ba4b97ba5bd411b32f49b81dc7d8a491126e3/content/browser/service_worker/service_worker_data_pipe_reader_unittest.cc
[modify] https://crrev.com/bc0ba4b97ba5bd411b32f49b81dc7d8a491126e3/content/browser/service_worker/service_worker_provider_host.cc
[modify] https://crrev.com/bc0ba4b97ba5bd411b32f49b81dc7d8a491126e3/content/browser/service_worker/service_worker_provider_host.h
[modify] https://crrev.com/bc0ba4b97ba5bd411b32f49b81dc7d8a491126e3/content/browser/service_worker/service_worker_request_handler.cc
[modify] https://crrev.com/bc0ba4b97ba5bd411b32f49b81dc7d8a491126e3/content/browser/service_worker/service_worker_request_handler.h
[modify] https://crrev.com/bc0ba4b97ba5bd411b32f49b81dc7d8a491126e3/content/browser/service_worker/service_worker_request_handler_unittest.cc
[modify] https://crrev.com/bc0ba4b97ba5bd411b32f49b81dc7d8a491126e3/content/browser/service_worker/service_worker_url_request_job.cc
[modify] https://crrev.com/bc0ba4b97ba5bd411b32f49b81dc7d8a491126e3/content/browser/service_worker/service_worker_url_request_job.h
[modify] https://crrev.com/bc0ba4b97ba5bd411b32f49b81dc7d8a491126e3/content/browser/service_worker/service_worker_url_request_job_unittest.cc
[modify] https://crrev.com/bc0ba4b97ba5bd411b32f49b81dc7d8a491126e3/content/browser/service_worker/service_worker_write_to_cache_job_unittest.cc
[modify] https://crrev.com/bc0ba4b97ba5bd411b32f49b81dc7d8a491126e3/content/common/service_worker/service_worker_fetch_request_struct_traits.cc
[modify] https://crrev.com/bc0ba4b97ba5bd411b32f49b81dc7d8a491126e3/content/common/service_worker/service_worker_fetch_request_struct_traits.h
[modify] https://crrev.com/bc0ba4b97ba5bd411b32f49b81dc7d8a491126e3/content/common/service_worker/service_worker_loader_helpers.cc
[modify] https://crrev.com/bc0ba4b97ba5bd411b32f49b81dc7d8a491126e3/content/common/service_worker/service_worker_messages.h
[modify] https://crrev.com/bc0ba4b97ba5bd411b32f49b81dc7d8a491126e3/content/common/service_worker/service_worker_types.h
[modify] https://crrev.com/bc0ba4b97ba5bd411b32f49b81dc7d8a491126e3/content/renderer/service_worker/service_worker_context_client.cc
[modify] https://crrev.com/bc0ba4b97ba5bd411b32f49b81dc7d8a491126e3/third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/fetch-event.https-expected.txt
[modify] https://crrev.com/bc0ba4b97ba5bd411b32f49b81dc7d8a491126e3/third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/fetch-event.https.html
[modify] https://crrev.com/bc0ba4b97ba5bd411b32f49b81dc7d8a491126e3/third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/resources/fetch-event-test-worker.js
[modify] https://crrev.com/bc0ba4b97ba5bd411b32f49b81dc7d8a491126e3/third_party/WebKit/Source/modules/fetch/FetchRequestData.cpp
[modify] https://crrev.com/bc0ba4b97ba5bd411b32f49b81dc7d8a491126e3/third_party/WebKit/Source/platform/exported/WebServiceWorkerRequest.cpp
[modify] https://crrev.com/bc0ba4b97ba5bd411b32f49b81dc7d8a491126e3/third_party/WebKit/Source/platform/mojo/FetchAPIRequestStructTraits.cpp
[modify] https://crrev.com/bc0ba4b97ba5bd411b32f49b81dc7d8a491126e3/third_party/WebKit/Source/platform/mojo/FetchAPIRequestStructTraits.h
[modify] https://crrev.com/bc0ba4b97ba5bd411b32f49b81dc7d8a491126e3/third_party/WebKit/public/platform/modules/fetch/fetch_api_request.mojom
[modify] https://crrev.com/bc0ba4b97ba5bd411b32f49b81dc7d8a491126e3/third_party/WebKit/public/platform/modules/serviceworker/WebServiceWorkerRequest.h

Components: Internals>Network>Service
Components: -Internals>Network>Service Internals>Services>Network
Apologies, applied the wrong component in bulk.

Comment 52 by jam@chromium.org, Nov 7 2017

Components: -Internals>Services>Network
Project Member

Comment 53 by bugdroid1@chromium.org, Dec 21 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b26c46341ba2ae0a995e67b58303617c144ae397

commit b26c46341ba2ae0a995e67b58303617c144ae397
Author: Yutaka Hirano <yhirano@chromium.org>
Date: Thu Dec 21 02:57:59 2017

Remove Settings::maxBeaconTransmission

The entry was introduced by [1] but it's used only by a test, so this
CL removes the entry and the test.

This is a preparation for introducing the quota management intrastructure
for keepalive requests.

1: https://src.chromium.org/viewvc/blink?view=rev&revision=173837

Bug:  695939 
Change-Id: I3b252e07d179e75ef787e6251d0a34abb640ef8c
Reviewed-on: https://chromium-review.googlesource.com/828561
Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
Reviewed-by: Takeshi Yoshino <tyoshino@chromium.org>
Commit-Queue: Yutaka Hirano <yhirano@chromium.org>
Cr-Commit-Position: refs/heads/master@{#525573}
[delete] https://crrev.com/07540c6d850ed6e0fa508d63c20a8ce96d751de6/third_party/WebKit/LayoutTests/http/tests/sendbeacon/beacon-allowance-no-limit.html
[modify] https://crrev.com/b26c46341ba2ae0a995e67b58303617c144ae397/third_party/WebKit/Source/core/frame/Settings.json5
[modify] https://crrev.com/b26c46341ba2ae0a995e67b58303617c144ae397/third_party/WebKit/Source/modules/beacon/NavigatorBeacon.cpp
[modify] https://crrev.com/b26c46341ba2ae0a995e67b58303617c144ae397/third_party/WebKit/Source/modules/beacon/NavigatorBeacon.h

Project Member

Comment 54 by bugdroid1@chromium.org, Dec 21 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c1bf25240713fed00de2963fd26c029213c4edd9

commit c1bf25240713fed00de2963fd26c029213c4edd9
Author: Yutaka Hirano <yhirano@chromium.org>
Date: Thu Dec 21 11:43:27 2017

[Fetch API] Keep track of inflight bytes for requests with keepalive set

This change also fixes a web platform test:

 - Wait for request completion by adding text() calls.
 - Fix incorrect promise usage which led to incorrect results.

Bug:  695939 
Change-Id: I73cc8406ae2a0344327deac3f16738a0b959a4d8
Reviewed-on: https://chromium-review.googlesource.com/826591
Commit-Queue: Yutaka Hirano <yhirano@chromium.org>
Reviewed-by: Takeshi Yoshino <tyoshino@chromium.org>
Cr-Commit-Position: refs/heads/master@{#525670}
[delete] https://crrev.com/cd9fa9101e25e3f69d951e11868e61661b2d2986/third_party/WebKit/LayoutTests/external/wpt/fetch/api/request/request-keepalive-quota-expected.txt
[modify] https://crrev.com/c1bf25240713fed00de2963fd26c029213c4edd9/third_party/WebKit/LayoutTests/external/wpt/fetch/api/request/request-keepalive-quota.html
[modify] https://crrev.com/c1bf25240713fed00de2963fd26c029213c4edd9/third_party/WebKit/LayoutTests/platform/win7/external/wpt/fetch/api/request/request-keepalive-quota-expected.txt
[modify] https://crrev.com/c1bf25240713fed00de2963fd26c029213c4edd9/third_party/WebKit/Source/modules/fetch/Request.cpp
[modify] https://crrev.com/c1bf25240713fed00de2963fd26c029213c4edd9/third_party/WebKit/Source/platform/loader/fetch/ResourceFetcher.cpp
[modify] https://crrev.com/c1bf25240713fed00de2963fd26c029213c4edd9/third_party/WebKit/Source/platform/loader/fetch/ResourceFetcher.h
[modify] https://crrev.com/c1bf25240713fed00de2963fd26c029213c4edd9/third_party/WebKit/Source/platform/loader/fetch/ResourceLoader.cpp
[modify] https://crrev.com/c1bf25240713fed00de2963fd26c029213c4edd9/third_party/WebKit/Source/platform/loader/fetch/ResourceLoader.h

Project Member

Comment 56 by bugdroid1@chromium.org, Dec 27 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1e2bdc6d9ab18d29d98f5c374b7fca87181d5f95

commit 1e2bdc6d9ab18d29d98f5c374b7fca87181d5f95
Author: Yutaka Hirano <yhirano@chromium.org>
Date: Wed Dec 27 05:19:29 2017

Fix fetch/api/request/request-keepalive-quota failures on Windows

We need to read request's body before closing the connection, otherwise
Chrome thinks the connection is reset abruptly.

Bug:  695939 
Change-Id: I27a92003138a8791e1d9bd7622d79ce795d7a1bd
Reviewed-on: https://chromium-review.googlesource.com/844035
Reviewed-by: Hiroshige Hayashizaki <hiroshige@chromium.org>
Commit-Queue: Yutaka Hirano <yhirano@chromium.org>
Cr-Commit-Position: refs/heads/master@{#526209}
[modify] https://crrev.com/1e2bdc6d9ab18d29d98f5c374b7fca87181d5f95/third_party/WebKit/LayoutTests/external/wpt/fetch/api/resources/trickle.py
[delete] https://crrev.com/d591e0da40d48eb1f59c4adeee80b14aaa7f1756/third_party/WebKit/LayoutTests/platform/win7/external/wpt/fetch/api/request/request-keepalive-quota-expected.txt

Project Member

Comment 57 by bugdroid1@chromium.org, Jan 24 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e99228c44d2cceda751d1ad7df650ce5b9742b41

commit e99228c44d2cceda751d1ad7df650ce5b9742b41
Author: Matt Falkenhagen <falken@chromium.org>
Date: Wed Jan 24 02:00:39 2018

S13nServiceWorker: Plumb Request#keepalive to FetchEvent.

This makes one of the failing test cases in fetch-event.https.html pass
when run with NetworkService (but there is no expectation change as
FlagExpectations still must expect Failure due to another test case
failure).

Bug:  804878 ,  695939 
Change-Id: I44c152f14282c2cefa056ece13e8f0bf9703676b
Reviewed-on: https://chromium-review.googlesource.com/881382
Reviewed-by: Makoto Shimazu <shimazu@chromium.org>
Commit-Queue: Matt Falkenhagen <falken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#531401}
[modify] https://crrev.com/e99228c44d2cceda751d1ad7df650ce5b9742b41/content/renderer/service_worker/service_worker_context_client.cc

Project Member

Comment 58 by bugdroid1@chromium.org, Jan 24 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/95d3d52619b90ff049ee28f610d85959833f7ecb

commit 95d3d52619b90ff049ee28f610d85959833f7ecb
Author: Yutaka Hirano <yhirano@chromium.org>
Date: Wed Jan 24 14:31:46 2018

[SendBeacon] Verify that the quota will recover after fetching

Bug:  695939 ,  805348 
Change-Id: I6c0e1643b70a94e37261ef709d58da13fa9b6cdd
Reviewed-on: https://chromium-review.googlesource.com/883063
Commit-Queue: Yutaka Hirano <yhirano@chromium.org>
Reviewed-by: Takeshi Yoshino <tyoshino@chromium.org>
Cr-Commit-Position: refs/heads/master@{#531524}
[modify] https://crrev.com/95d3d52619b90ff049ee28f610d85959833f7ecb/third_party/WebKit/LayoutTests/external/wpt/beacon/beacon-error.window.js

Project Member

Comment 59 by bugdroid1@chromium.org, Feb 18 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/52e9e1de61e5a59d3b42f734755651c18dd4a9d1

commit 52e9e1de61e5a59d3b42f734755651c18dd4a9d1
Author: Yutaka Hirano <yhirano@chromium.org>
Date: Sun Feb 18 16:07:37 2018

Ship keepalive on Fetch API

Intent to ship thread: https://groups.google.com/a/chromium.org/forum/#!topic/Blink-dev/8vqcABTnDF4

Bug:  695939 
Change-Id: I917909f4ee0e5cf2967ac4ed44b137e9a9b6e2a1
Reviewed-on: https://chromium-review.googlesource.com/923442
Reviewed-by: Yoav Weiss <yoav@yoav.ws>
Commit-Queue: Yutaka Hirano <yhirano@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537564}
[modify] https://crrev.com/52e9e1de61e5a59d3b42f734755651c18dd4a9d1/third_party/WebKit/LayoutTests/virtual/stable/http/tests/serviceworker/webexposed/global-interface-listing-service-worker-expected.txt
[modify] https://crrev.com/52e9e1de61e5a59d3b42f734755651c18dd4a9d1/third_party/WebKit/LayoutTests/virtual/stable/webexposed/global-interface-listing-dedicated-worker-expected.txt
[modify] https://crrev.com/52e9e1de61e5a59d3b42f734755651c18dd4a9d1/third_party/WebKit/LayoutTests/virtual/stable/webexposed/global-interface-listing-expected.txt
[modify] https://crrev.com/52e9e1de61e5a59d3b42f734755651c18dd4a9d1/third_party/WebKit/LayoutTests/virtual/stable/webexposed/global-interface-listing-shared-worker-expected.txt
[modify] https://crrev.com/52e9e1de61e5a59d3b42f734755651c18dd4a9d1/third_party/WebKit/Source/platform/runtime_enabled_features.json5

Labels: M-66
Status: Fixed (was: Assigned)

Sign in to add a comment