New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 695931 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2017
Cc:
Components:
EstimatedDays: 1
NextAction: 2017-03-01
OS: Android
Pri: 1
Type: Bug



Sign in to add a comment

Don't cache canMakePayment results.

Project Member Reported by rouslan@chromium.org, Feb 24 2017

Issue description

If a merchant calls PaymentRequest.canMakePayment() for the same method                                                                                                                                                                        
names, multiple times, then the method should return the most up-to-date                                                                                                                                                                       
result every time. This enables the merchant to prompt the use to setup                                                                                                                                                                        
their payment instrument.
 
Project Member

Comment 2 by bugdroid1@chromium.org, Feb 27 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7085ee86276c0f53f36e89ef5372493b621c9374

commit 7085ee86276c0f53f36e89ef5372493b621c9374
Author: rouslan <rouslan@chromium.org>
Date: Mon Feb 27 23:07:58 2017

Don't cache canMakePayment results.

If a merchant calls PaymentRequest.canMakePayment() for the same method
names and method data multiple times, then the method should return the
most up-to-date result every time. This enables the merchant to prompt
the use to setup their payment instrument. Note that different payment
method data will trigger query quota exceeded error instead of returning
cached result from a prior query with different payment method data.

BUG= 695931 

Review-Url: https://codereview.chromium.org/2711263003
Cr-Commit-Position: refs/heads/master@{#453376}

[modify] https://crrev.com/7085ee86276c0f53f36e89ef5372493b621c9374/chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestImpl.java
[modify] https://crrev.com/7085ee86276c0f53f36e89ef5372493b621c9374/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestBasicCardTest.java
[modify] https://crrev.com/7085ee86276c0f53f36e89ef5372493b621c9374/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestPaymentAppCanMakePaymentQueryTest.java

Labels: Merge-Request-57
NextAction: 2017-03-01
Project Member

Comment 5 by sheriffbot@chromium.org, Feb 28 2017

Labels: -Merge-Request-57 Hotlist-Merge-Review Merge-Review-57
This bug requires manual review: We are only 13 days from stable.
Please contact the milestone owner if you have questions.
Owners: amineer@(clank), cmasso@(bling), ketakid@(cros), govind@(desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: -Merge-Review-57 Merge-Rejected-57
I spoke with rouslan@ offline.  This isn't critical for 57, and since it's a large(ish) change for this late in the cycle, we'll wait for 58.
Labels: -M-57 M-58
Status: Fixed (was: Started)
Components: -UI>Browser>Autofill>Payments UI>Browser>Payments

Sign in to add a comment